Skip to content

Comments

feat(rust): eagerly cleanup resources when calling close#6483

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-11-feat_rust_eagerly_cleanup_resources_when_calling_close_
Oct 11, 2025
Merged

feat(rust): eagerly cleanup resources when calling close#6483
graphite-app[bot] merged 1 commit intomainfrom
10-11-feat_rust_eagerly_cleanup_resources_when_calling_close_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Oct 11, 2025

Copy link
Member Author

hyf0 commented Oct 11, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 requested a review from shulaoda October 11, 2025 09:59
@graphite-app graphite-app bot changed the base branch from 10-11-feat_rust_varify_if_bundler_is_closed_for_public_api to graphite-base/6483 October 11, 2025 10:00
@hyf0 hyf0 force-pushed the graphite-base/6483 branch from 5db0a19 to b8f9e7d Compare October 11, 2025 10:13
@hyf0 hyf0 force-pushed the 10-11-feat_rust_eagerly_cleanup_resources_when_calling_close_ branch from 36915ca to b1541cd Compare October 11, 2025 10:13
@graphite-app graphite-app bot changed the base branch from graphite-base/6483 to main October 11, 2025 10:13
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 11, 2025

Merge activity

  • Oct 11, 10:13 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Oct 11, 10:29 AM UTC: hyf0 added this pull request to the Graphite merge queue.
  • Oct 11, 10:43 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 10-11-feat_rust_eagerly_cleanup_resources_when_calling_close_ branch from b1541cd to 0dd43df Compare October 11, 2025 10:30
@netlify
Copy link

netlify bot commented Oct 11, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 0dd43df
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68ea31baa0f9200008de2417

@graphite-app graphite-app bot merged commit 0dd43df into main Oct 11, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 10-11-feat_rust_eagerly_cleanup_resources_when_calling_close_ branch October 11, 2025 10:43
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(b8f9e7d)
  • pr: 10-11-feat_rust_eagerly_cleanup_resources_when_calling_close_(0dd43df)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     69.3±1.57ms        ? ?/sec    1.03     71.5±1.78ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     76.7±1.92ms        ? ?/sec    1.02     78.2±1.82ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    111.6±2.62ms        ? ?/sec    1.00    110.8±2.14ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    127.8±2.11ms        ? ?/sec    1.00    127.3±2.45ms        ? ?/sec
bundle/bundle@threejs                                        1.02     44.8±2.52ms        ? ?/sec    1.00     43.9±0.73ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.03     51.9±1.38ms        ? ?/sec    1.00     50.6±0.79ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    429.9±4.63ms        ? ?/sec    1.00    431.1±4.80ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    493.7±3.63ms        ? ?/sec    1.00    494.0±6.03ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.9±1.30ms        ? ?/sec    1.00     86.8±1.75ms        ? ?/sec
scan/scan@threejs                                            1.02     33.0±1.84ms        ? ?/sec    1.00     32.2±0.45ms        ? ?/sec
scan/scan@threejs10x                                         1.01    333.6±4.46ms        ? ?/sec    1.00    329.3±4.70ms        ? ?/sec

shulaoda pushed a commit that referenced this pull request Oct 13, 2025
## [1.0.0-beta.43] - 2025-10-13

### 🚀 Features

- add filterVitePlugins utility that uses to skip vite plugins using apply: "serve" (#6502) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial can inline entry logic (#6500) by @shulaoda
- rolldown_plugin_vite_html: align get_imported_chunks logic (#6499) by @shulaoda
- rolldown_plugin_vite_html: align HtmlTagDescriptor (#6498) by @shulaoda
- rolldown_plugin_vite_html: align partial utility functions logic (#6497) by @shulaoda
- rolldown_html_vite_html: align partial inject chunk asset links logic (#6496) by @shulaoda
- rolldown_plugin_vite_html: align `processedHtml` logic (#6494) by @shulaoda
- add `nativeMagicString` options (#6469) by @IWANABETHATGUY
- rust: eagerly cleanup resources when calling `close` (#6483) by @hyf0
- rust: varify if bundler is closed for public API (#6481) by @hyf0
- replace [format] placeholder in chunk filename templates (#6476) by @elecmonkey
- implement synchronous JS callback invocation for paths function (#6474) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial transform hook logic (#6471) by @shulaoda
- Support `output.paths` (#6470) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align script urls handle logic (#6466) by @shulaoda
- add validation for `preserveEntrySignatures` with `includeDependenciesRecursively` option (#6468) by @hyf0
- rolldown_plugin_vite_html: align partial logic (#6465) by @shulaoda
- background sourcemap generation for Javascript transform hooks (#6293) by @IWANABETHATGUY
- rolldown_plugin_vite_html: handle style tag (#6464) by @shulaoda
- rolldown_plugin_vite_html: handle inline style attribute (#6463) by @shulaoda
- rolldown_plugin_vite_html: patially handle vite-ignore attribute (#6462) by @shulaoda
- dev/node: expose errors of `on_hmr_updatrs` to node (#6454) by @hyf0
- dev/node: expose errors of `on_output` to node (#6453) by @hyf0
- dev: expose hmr errors on `on_hmr_updatrs` callback (#6443) by @hyf0

### 🐛 Bug Fixes

- fallback sourcemap generation for `experimental.nativeMagicString: false` (#6488) by @IWANABETHATGUY
- take `resolve.modules` into account (#6484) by @Pickachu
- rolldown: increase tokio blocking threads size for watch mode (#6467) by @Brooooooklyn
- use len_utf16 in magic_string CharToByteMapper (#6461) by @IWANABETHATGUY
- pass `advancedChunks#includeDependenciesRecursively` to rust (#6448) by @hyf0
- dev: should compute hmr update correctly for multiple clients (#6442) by @hyf0
- allow specifying packageJsonPath in PluginContext.load (#6439) by @sapphi-red
- use transform.target as default for minify target when `minify: { compress: true }` (#6433) by @sapphi-red

### 🚜 Refactor

- extract background sourcemap handling into separate methods (#6501) by @IWANABETHATGUY
- rust: only expose methods of `Bundler` for public usage (#6480) by @hyf0
- dev/node: use napi object instead clss for `BindingClientHmrUpdate` (#6456) by @hyf0
- dev/node: improve `DevOnHmrUpdates` API (#6455) by @hyf0

### 📚 Documentation

- update team page and add acknowledgements page (#6495) by @hyf0
- restructure website and files (#6492) by @hyf0
- correct incorrect documentation about the config file (#6472) by @jsparkdev
- options: `experimental.strictExecutionOrder` (#6450) by @hyf0
- adding `why-plugin-hook-filter` in depth (#6446) by @IWANABETHATGUY

### ⚡ Performance

- rolldown: replace serde JSON string escape with simd impl (#6475) by @Brooooooklyn

### ⚙️ Miscellaneous Tasks

- docs: redirect removed path to new locations for compatibility (#6493) by @hyf0
- deps: lock file maintenance npm packages (#6490) by @renovate[bot]
- deps: update github-actions (major) (#6415) by @renovate[bot]
- deps: update github-actions (#6489) by @renovate[bot]
- rust: add comment for `DiagnosticOptions#stabilize_path` (#6447) by @hyf0
- rust: remove unused `BindingHmrOutput` (#6457) by @hyf0
- rolldown_plugin_vite_html: tweak `utils.rs` (#6460) by @shulaoda
- change node version to lts (#6435) by @iiio2
- rust/test: split hmr related structs into their own files (#6445) by @hyf0
- deps: update crate-ci/typos action to v1.38.1 (#6452) by @renovate[bot]
- rust/test: render hmr errors (#6444) by @hyf0
- examples: add `"type": "module"` in `package.json` (#6441) by @iiio2

### ❤️ New Contributors

* @Pickachu made their first contribution in [#6484](#6484)
* @elecmonkey made their first contribution in [#6476](#6476)
* @jsparkdev made their first contribution in [#6472](#6472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants