Skip to content

Comments

feat: add nativeMagicString options#6469

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-09-feat_add_nativemagicstring_options
Oct 12, 2025
Merged

feat: add nativeMagicString options#6469
graphite-app[bot] merged 1 commit intomainfrom
10-09-feat_add_nativemagicstring_options

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Oct 9, 2025

This option is used to make #6293 opt-in, sometimes on the JS side, users require that the sourcemap generation be synced, e.g.

public getCombinedSourcemap(): SourceMap {
return JSON.parse(this.inner.getCombinedSourcemap());
}

Copy link
Member Author

IWANABETHATGUY commented Oct 9, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit dd3f0cb
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68ebd42e292fdc000865838c
😎 Deploy Preview https://deploy-preview-6469--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Benchmarks Rust

  • target: main(c4e442e)
  • pr: 10-09-feat_add_nativemagicstring_options(dd3f0cb)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     68.6±1.01ms        ? ?/sec    1.00     68.5±1.59ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     76.1±1.21ms        ? ?/sec    1.00     74.8±1.32ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    113.7±4.44ms        ? ?/sec    1.00    110.4±2.08ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    127.4±1.96ms        ? ?/sec    1.00    126.9±1.73ms        ? ?/sec
bundle/bundle@threejs                                        1.03     44.7±2.53ms        ? ?/sec    1.00     43.4±0.62ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     51.5±0.82ms        ? ?/sec    1.00     50.7±1.56ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    429.4±5.04ms        ? ?/sec    1.00    428.5±6.87ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    496.9±3.95ms        ? ?/sec    1.00    494.5±6.12ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.7±1.40ms        ? ?/sec    1.00     86.4±2.08ms        ? ?/sec
scan/scan@threejs                                            1.02     33.4±2.72ms        ? ?/sec    1.00     32.7±1.80ms        ? ?/sec
scan/scan@threejs10x                                         1.01    332.5±5.07ms        ? ?/sec    1.00    330.3±4.26ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the 10-09-feat_add_nativemagicstring_options branch from e1e6b28 to 9fe7b4a Compare October 12, 2025 15:52
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review October 12, 2025 15:54
@IWANABETHATGUY IWANABETHATGUY force-pushed the 10-09-feat_add_nativemagicstring_options branch from 9fe7b4a to f817d69 Compare October 12, 2025 16:02
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 12, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 10-09-feat_add_nativemagicstring_options branch from f817d69 to dd3f0cb Compare October 12, 2025 16:15
@graphite-app graphite-app bot merged commit dd3f0cb into main Oct 12, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 10-09-feat_add_nativemagicstring_options branch October 12, 2025 16:29
shulaoda pushed a commit that referenced this pull request Oct 13, 2025
## [1.0.0-beta.43] - 2025-10-13

### 🚀 Features

- add filterVitePlugins utility that uses to skip vite plugins using apply: "serve" (#6502) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial can inline entry logic (#6500) by @shulaoda
- rolldown_plugin_vite_html: align get_imported_chunks logic (#6499) by @shulaoda
- rolldown_plugin_vite_html: align HtmlTagDescriptor (#6498) by @shulaoda
- rolldown_plugin_vite_html: align partial utility functions logic (#6497) by @shulaoda
- rolldown_html_vite_html: align partial inject chunk asset links logic (#6496) by @shulaoda
- rolldown_plugin_vite_html: align `processedHtml` logic (#6494) by @shulaoda
- add `nativeMagicString` options (#6469) by @IWANABETHATGUY
- rust: eagerly cleanup resources when calling `close` (#6483) by @hyf0
- rust: varify if bundler is closed for public API (#6481) by @hyf0
- replace [format] placeholder in chunk filename templates (#6476) by @elecmonkey
- implement synchronous JS callback invocation for paths function (#6474) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial transform hook logic (#6471) by @shulaoda
- Support `output.paths` (#6470) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align script urls handle logic (#6466) by @shulaoda
- add validation for `preserveEntrySignatures` with `includeDependenciesRecursively` option (#6468) by @hyf0
- rolldown_plugin_vite_html: align partial logic (#6465) by @shulaoda
- background sourcemap generation for Javascript transform hooks (#6293) by @IWANABETHATGUY
- rolldown_plugin_vite_html: handle style tag (#6464) by @shulaoda
- rolldown_plugin_vite_html: handle inline style attribute (#6463) by @shulaoda
- rolldown_plugin_vite_html: patially handle vite-ignore attribute (#6462) by @shulaoda
- dev/node: expose errors of `on_hmr_updatrs` to node (#6454) by @hyf0
- dev/node: expose errors of `on_output` to node (#6453) by @hyf0
- dev: expose hmr errors on `on_hmr_updatrs` callback (#6443) by @hyf0

### 🐛 Bug Fixes

- fallback sourcemap generation for `experimental.nativeMagicString: false` (#6488) by @IWANABETHATGUY
- take `resolve.modules` into account (#6484) by @Pickachu
- rolldown: increase tokio blocking threads size for watch mode (#6467) by @Brooooooklyn
- use len_utf16 in magic_string CharToByteMapper (#6461) by @IWANABETHATGUY
- pass `advancedChunks#includeDependenciesRecursively` to rust (#6448) by @hyf0
- dev: should compute hmr update correctly for multiple clients (#6442) by @hyf0
- allow specifying packageJsonPath in PluginContext.load (#6439) by @sapphi-red
- use transform.target as default for minify target when `minify: { compress: true }` (#6433) by @sapphi-red

### 🚜 Refactor

- extract background sourcemap handling into separate methods (#6501) by @IWANABETHATGUY
- rust: only expose methods of `Bundler` for public usage (#6480) by @hyf0
- dev/node: use napi object instead clss for `BindingClientHmrUpdate` (#6456) by @hyf0
- dev/node: improve `DevOnHmrUpdates` API (#6455) by @hyf0

### 📚 Documentation

- update team page and add acknowledgements page (#6495) by @hyf0
- restructure website and files (#6492) by @hyf0
- correct incorrect documentation about the config file (#6472) by @jsparkdev
- options: `experimental.strictExecutionOrder` (#6450) by @hyf0
- adding `why-plugin-hook-filter` in depth (#6446) by @IWANABETHATGUY

### ⚡ Performance

- rolldown: replace serde JSON string escape with simd impl (#6475) by @Brooooooklyn

### ⚙️ Miscellaneous Tasks

- docs: redirect removed path to new locations for compatibility (#6493) by @hyf0
- deps: lock file maintenance npm packages (#6490) by @renovate[bot]
- deps: update github-actions (major) (#6415) by @renovate[bot]
- deps: update github-actions (#6489) by @renovate[bot]
- rust: add comment for `DiagnosticOptions#stabilize_path` (#6447) by @hyf0
- rust: remove unused `BindingHmrOutput` (#6457) by @hyf0
- rolldown_plugin_vite_html: tweak `utils.rs` (#6460) by @shulaoda
- change node version to lts (#6435) by @iiio2
- rust/test: split hmr related structs into their own files (#6445) by @hyf0
- deps: update crate-ci/typos action to v1.38.1 (#6452) by @renovate[bot]
- rust/test: render hmr errors (#6444) by @hyf0
- examples: add `"type": "module"` in `package.json` (#6441) by @iiio2

### ❤️ New Contributors

* @Pickachu made their first contribution in [#6484](#6484)
* @elecmonkey made their first contribution in [#6476](#6476)
* @jsparkdev made their first contribution in [#6472](#6472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants