Skip to content

Comments

chore(rust): remove unused BindingHmrOutput#6457

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-08-chore_rust_remove_unused_bindinghmroutput_
Oct 8, 2025
Merged

chore(rust): remove unused BindingHmrOutput#6457
graphite-app[bot] merged 1 commit intomainfrom
10-08-chore_rust_remove_unused_bindinghmroutput_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Oct 8, 2025

No description provided.

Copy link
Member Author

hyf0 commented Oct 8, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 force-pushed the 10-08-chore_rust_remove_unused_bindinghmroutput_ branch from 95a0604 to 102141a Compare October 8, 2025 08:29
@hyf0 hyf0 force-pushed the 10-08-refactor_dev_node_use_napi_object_instead_clss_for_bindingclienthmrupdate_ branch from c726660 to 31053d4 Compare October 8, 2025 08:29
@hyf0 hyf0 requested review from sapphi-red and shulaoda October 8, 2025 08:36
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Benchmarks Rust

  • target: main(daec4f5)
  • pr: 10-08-chore_rust_remove_unused_bindinghmroutput_(8c8ae8c)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     68.6±2.10ms        ? ?/sec    1.00     68.2±1.52ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     77.8±4.68ms        ? ?/sec    1.00     76.0±2.45ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    113.0±2.48ms        ? ?/sec    1.00    113.0±2.30ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    129.4±2.70ms        ? ?/sec    1.00    129.3±2.49ms        ? ?/sec
bundle/bundle@threejs                                        1.01     44.9±2.42ms        ? ?/sec    1.00     44.3±1.13ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     51.9±1.01ms        ? ?/sec    1.01     52.2±0.99ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    431.9±6.41ms        ? ?/sec    1.00    429.9±5.44ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    493.8±5.09ms        ? ?/sec    1.00    495.9±6.78ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.4±1.78ms        ? ?/sec    1.00     87.2±1.66ms        ? ?/sec
scan/scan@threejs                                            1.01     33.1±1.85ms        ? ?/sec    1.00     32.6±0.59ms        ? ?/sec
scan/scan@threejs10x                                         1.01    337.9±6.16ms        ? ?/sec    1.00    335.5±7.41ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 8, 2025

Merge activity

  • Oct 8, 8:43 AM UTC: hyf0 added this pull request to the Graphite merge queue.
  • Oct 8, 8:52 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #6454.
  • Oct 8, 8:52 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #6454.
  • Oct 8, 11:17 AM UTC: hyf0 added this pull request to the Graphite merge queue.
  • Oct 8, 12:02 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #6455.
  • Oct 8, 3:14 PM UTC: hyf0 added this pull request to the Graphite merge queue.
  • Oct 8, 3:29 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test (macos-latest) / Node Test', 'node-test (windows-latest) / Node Test').
  • Oct 8, 6:11 PM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 8, 6:11 PM UTC: hyf0 added this pull request to the Graphite merge queue.
  • Oct 8, 6:25 PM UTC: Merged by the Graphite merge queue.

@hyf0 hyf0 force-pushed the 10-08-refactor_dev_node_use_napi_object_instead_clss_for_bindingclienthmrupdate_ branch from 31053d4 to 857bffa Compare October 8, 2025 09:16
@hyf0 hyf0 force-pushed the 10-08-chore_rust_remove_unused_bindinghmroutput_ branch from 102141a to 38b5c8e Compare October 8, 2025 09:16
@graphite-app graphite-app bot force-pushed the 10-08-refactor_dev_node_use_napi_object_instead_clss_for_bindingclienthmrupdate_ branch from 857bffa to 6d97bb3 Compare October 8, 2025 11:19
graphite-app bot pushed a commit that referenced this pull request Oct 8, 2025
@graphite-app graphite-app bot force-pushed the 10-08-chore_rust_remove_unused_bindinghmroutput_ branch from 38b5c8e to 8747f4e Compare October 8, 2025 11:20
@graphite-app graphite-app bot force-pushed the 10-08-refactor_dev_node_use_napi_object_instead_clss_for_bindingclienthmrupdate_ branch from 6d97bb3 to a90b213 Compare October 8, 2025 15:14
graphite-app bot pushed a commit that referenced this pull request Oct 8, 2025
@graphite-app graphite-app bot force-pushed the 10-08-chore_rust_remove_unused_bindinghmroutput_ branch from 8747f4e to fadf154 Compare October 8, 2025 15:15
Base automatically changed from 10-08-refactor_dev_node_use_napi_object_instead_clss_for_bindingclienthmrupdate_ to main October 8, 2025 15:28
@graphite-app graphite-app bot force-pushed the 10-08-chore_rust_remove_unused_bindinghmroutput_ branch from fadf154 to 8c8ae8c Compare October 8, 2025 18:12
@netlify
Copy link

netlify bot commented Oct 8, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 8c8ae8c
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68e6a97223f7240008cec4d5
😎 Deploy Preview https://deploy-preview-6457--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@graphite-app graphite-app bot merged commit 8c8ae8c into main Oct 8, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 10-08-chore_rust_remove_unused_bindinghmroutput_ branch October 8, 2025 18:25
shulaoda pushed a commit that referenced this pull request Oct 13, 2025
## [1.0.0-beta.43] - 2025-10-13

### 🚀 Features

- add filterVitePlugins utility that uses to skip vite plugins using apply: "serve" (#6502) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial can inline entry logic (#6500) by @shulaoda
- rolldown_plugin_vite_html: align get_imported_chunks logic (#6499) by @shulaoda
- rolldown_plugin_vite_html: align HtmlTagDescriptor (#6498) by @shulaoda
- rolldown_plugin_vite_html: align partial utility functions logic (#6497) by @shulaoda
- rolldown_html_vite_html: align partial inject chunk asset links logic (#6496) by @shulaoda
- rolldown_plugin_vite_html: align `processedHtml` logic (#6494) by @shulaoda
- add `nativeMagicString` options (#6469) by @IWANABETHATGUY
- rust: eagerly cleanup resources when calling `close` (#6483) by @hyf0
- rust: varify if bundler is closed for public API (#6481) by @hyf0
- replace [format] placeholder in chunk filename templates (#6476) by @elecmonkey
- implement synchronous JS callback invocation for paths function (#6474) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial transform hook logic (#6471) by @shulaoda
- Support `output.paths` (#6470) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align script urls handle logic (#6466) by @shulaoda
- add validation for `preserveEntrySignatures` with `includeDependenciesRecursively` option (#6468) by @hyf0
- rolldown_plugin_vite_html: align partial logic (#6465) by @shulaoda
- background sourcemap generation for Javascript transform hooks (#6293) by @IWANABETHATGUY
- rolldown_plugin_vite_html: handle style tag (#6464) by @shulaoda
- rolldown_plugin_vite_html: handle inline style attribute (#6463) by @shulaoda
- rolldown_plugin_vite_html: patially handle vite-ignore attribute (#6462) by @shulaoda
- dev/node: expose errors of `on_hmr_updatrs` to node (#6454) by @hyf0
- dev/node: expose errors of `on_output` to node (#6453) by @hyf0
- dev: expose hmr errors on `on_hmr_updatrs` callback (#6443) by @hyf0

### 🐛 Bug Fixes

- fallback sourcemap generation for `experimental.nativeMagicString: false` (#6488) by @IWANABETHATGUY
- take `resolve.modules` into account (#6484) by @Pickachu
- rolldown: increase tokio blocking threads size for watch mode (#6467) by @Brooooooklyn
- use len_utf16 in magic_string CharToByteMapper (#6461) by @IWANABETHATGUY
- pass `advancedChunks#includeDependenciesRecursively` to rust (#6448) by @hyf0
- dev: should compute hmr update correctly for multiple clients (#6442) by @hyf0
- allow specifying packageJsonPath in PluginContext.load (#6439) by @sapphi-red
- use transform.target as default for minify target when `minify: { compress: true }` (#6433) by @sapphi-red

### 🚜 Refactor

- extract background sourcemap handling into separate methods (#6501) by @IWANABETHATGUY
- rust: only expose methods of `Bundler` for public usage (#6480) by @hyf0
- dev/node: use napi object instead clss for `BindingClientHmrUpdate` (#6456) by @hyf0
- dev/node: improve `DevOnHmrUpdates` API (#6455) by @hyf0

### 📚 Documentation

- update team page and add acknowledgements page (#6495) by @hyf0
- restructure website and files (#6492) by @hyf0
- correct incorrect documentation about the config file (#6472) by @jsparkdev
- options: `experimental.strictExecutionOrder` (#6450) by @hyf0
- adding `why-plugin-hook-filter` in depth (#6446) by @IWANABETHATGUY

### ⚡ Performance

- rolldown: replace serde JSON string escape with simd impl (#6475) by @Brooooooklyn

### ⚙️ Miscellaneous Tasks

- docs: redirect removed path to new locations for compatibility (#6493) by @hyf0
- deps: lock file maintenance npm packages (#6490) by @renovate[bot]
- deps: update github-actions (major) (#6415) by @renovate[bot]
- deps: update github-actions (#6489) by @renovate[bot]
- rust: add comment for `DiagnosticOptions#stabilize_path` (#6447) by @hyf0
- rust: remove unused `BindingHmrOutput` (#6457) by @hyf0
- rolldown_plugin_vite_html: tweak `utils.rs` (#6460) by @shulaoda
- change node version to lts (#6435) by @iiio2
- rust/test: split hmr related structs into their own files (#6445) by @hyf0
- deps: update crate-ci/typos action to v1.38.1 (#6452) by @renovate[bot]
- rust/test: render hmr errors (#6444) by @hyf0
- examples: add `"type": "module"` in `package.json` (#6441) by @iiio2

### ❤️ New Contributors

* @Pickachu made their first contribution in [#6484](#6484)
* @elecmonkey made their first contribution in [#6476](#6476)
* @jsparkdev made their first contribution in [#6472](#6472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants