fix: pass `advancedChunks#includeDependenciesRecursively` to rust by hyf0 · Pull Request #6448 · rolldown/rolldown

hyf0 · 2025-10-07T15:36:54Z

No description provided.

hyf0 · 2025-10-07T15:37:10Z

fix: pass advancedChunks#includeDependenciesRecursively to rust #6448 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-10-07T15:37:48Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`ff1a4b0`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68e53b29f616b90008f0ef3c
😎 Deploy Preview	https://deploy-preview-6448--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

graphite-app · 2025-10-07T16:08:29Z

Merge activity

Oct 7, 4:08 PM UTC: hyf0 added this pull request to the Graphite merge queue.
Oct 7, 4:24 PM UTC: Merged by the Graphite merge queue.

)

pkg-pr-new · 2025-10-07T16:23:13Z

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@6448

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@6448

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@6448

rolldown

npm i https://pkg.pr.new/rolldown@6448

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@6448

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@6448

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@6448

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@6448

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@6448

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@6448

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@6448

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@6448

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@6448

@rolldown/binding-openharmony-arm64

npm i https://pkg.pr.new/@rolldown/binding-openharmony-arm64@6448

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@6448

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@6448

@rolldown/binding-win32-ia32-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-ia32-msvc@6448

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@6448

commit: ff1a4b0

github-actions · 2025-10-07T16:26:03Z

Benchmarks Rust

target: main(35d9c4f)
pr: 10-07-fix_expose_includedependenciesrecursively_to_typescript_wrapper(ff1a4b0)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     72.6±2.83ms        ? ?/sec    1.00     72.0±2.75ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     80.1±2.60ms        ? ?/sec    1.00     78.9±2.28ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    117.8±2.82ms        ? ?/sec    1.01    119.5±2.90ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    135.8±2.60ms        ? ?/sec    1.01    137.1±2.40ms        ? ?/sec
bundle/bundle@threejs                                        1.01     46.1±1.80ms        ? ?/sec    1.00     45.6±1.00ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     55.1±1.27ms        ? ?/sec    1.00     53.9±1.41ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    458.5±6.58ms        ? ?/sec    1.00    456.9±6.41ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    528.9±4.87ms        ? ?/sec    1.00    527.2±5.26ms        ? ?/sec
scan/scan@rome_ts                                            1.02     90.1±1.85ms        ? ?/sec    1.00     88.6±2.08ms        ? ?/sec
scan/scan@threejs                                            1.00     33.2±0.54ms        ? ?/sec    1.01     33.5±2.27ms        ? ?/sec
scan/scan@threejs10x                                         1.01    346.3±5.03ms        ? ?/sec    1.00    343.2±4.57ms        ? ?/sec

hi-ogawa · 2025-10-07T23:25:57Z

I reported includeDependenciesRecursively not being working in #6083. Maybe the issue can be closed if this option works now.

ChristopherPHolder · 2025-10-08T11:09:55Z

The option seems to be working for me at least

@IWANABETHATGUY

## [1.0.0-beta.43] - 2025-10-13 ### 🚀 Features - add filterVitePlugins utility that uses to skip vite plugins using apply: "serve" (#6502) by @IWANABETHATGUY - rolldown_plugin_vite_html: align partial can inline entry logic (#6500) by @shulaoda - rolldown_plugin_vite_html: align get_imported_chunks logic (#6499) by @shulaoda - rolldown_plugin_vite_html: align HtmlTagDescriptor (#6498) by @shulaoda - rolldown_plugin_vite_html: align partial utility functions logic (#6497) by @shulaoda - rolldown_html_vite_html: align partial inject chunk asset links logic (#6496) by @shulaoda - rolldown_plugin_vite_html: align `processedHtml` logic (#6494) by @shulaoda - add `nativeMagicString` options (#6469) by @IWANABETHATGUY - rust: eagerly cleanup resources when calling `close` (#6483) by @hyf0 - rust: varify if bundler is closed for public API (#6481) by @hyf0 - replace [format] placeholder in chunk filename templates (#6476) by @elecmonkey - implement synchronous JS callback invocation for paths function (#6474) by @IWANABETHATGUY - rolldown_plugin_vite_html: align partial transform hook logic (#6471) by @shulaoda - Support `output.paths` (#6470) by @IWANABETHATGUY - rolldown_plugin_vite_html: align script urls handle logic (#6466) by @shulaoda - add validation for `preserveEntrySignatures` with `includeDependenciesRecursively` option (#6468) by @hyf0 - rolldown_plugin_vite_html: align partial logic (#6465) by @shulaoda - background sourcemap generation for Javascript transform hooks (#6293) by @IWANABETHATGUY - rolldown_plugin_vite_html: handle style tag (#6464) by @shulaoda - rolldown_plugin_vite_html: handle inline style attribute (#6463) by @shulaoda - rolldown_plugin_vite_html: patially handle vite-ignore attribute (#6462) by @shulaoda - dev/node: expose errors of `on_hmr_updatrs` to node (#6454) by @hyf0 - dev/node: expose errors of `on_output` to node (#6453) by @hyf0 - dev: expose hmr errors on `on_hmr_updatrs` callback (#6443) by @hyf0 ### 🐛 Bug Fixes - fallback sourcemap generation for `experimental.nativeMagicString: false` (#6488) by @IWANABETHATGUY - take `resolve.modules` into account (#6484) by @Pickachu - rolldown: increase tokio blocking threads size for watch mode (#6467) by @Brooooooklyn - use len_utf16 in magic_string CharToByteMapper (#6461) by @IWANABETHATGUY - pass `advancedChunks#includeDependenciesRecursively` to rust (#6448) by @hyf0 - dev: should compute hmr update correctly for multiple clients (#6442) by @hyf0 - allow specifying packageJsonPath in PluginContext.load (#6439) by @sapphi-red - use transform.target as default for minify target when `minify: { compress: true }` (#6433) by @sapphi-red ### 🚜 Refactor - extract background sourcemap handling into separate methods (#6501) by @IWANABETHATGUY - rust: only expose methods of `Bundler` for public usage (#6480) by @hyf0 - dev/node: use napi object instead clss for `BindingClientHmrUpdate` (#6456) by @hyf0 - dev/node: improve `DevOnHmrUpdates` API (#6455) by @hyf0 ### 📚 Documentation - update team page and add acknowledgements page (#6495) by @hyf0 - restructure website and files (#6492) by @hyf0 - correct incorrect documentation about the config file (#6472) by @jsparkdev - options: `experimental.strictExecutionOrder` (#6450) by @hyf0 - adding `why-plugin-hook-filter` in depth (#6446) by @IWANABETHATGUY ### ⚡ Performance - rolldown: replace serde JSON string escape with simd impl (#6475) by @Brooooooklyn ### ⚙️ Miscellaneous Tasks - docs: redirect removed path to new locations for compatibility (#6493) by @hyf0 - deps: lock file maintenance npm packages (#6490) by @renovate[bot] - deps: update github-actions (major) (#6415) by @renovate[bot] - deps: update github-actions (#6489) by @renovate[bot] - rust: add comment for `DiagnosticOptions#stabilize_path` (#6447) by @hyf0 - rust: remove unused `BindingHmrOutput` (#6457) by @hyf0 - rolldown_plugin_vite_html: tweak `utils.rs` (#6460) by @shulaoda - change node version to lts (#6435) by @iiio2 - rust/test: split hmr related structs into their own files (#6445) by @hyf0 - deps: update crate-ci/typos action to v1.38.1 (#6452) by @renovate[bot] - rust/test: render hmr errors (#6444) by @hyf0 - examples: add `"type": "module"` in `package.json` (#6441) by @iiio2 ### ❤️ New Contributors * @Pickachu made their first contribution in [#6484](#6484) * @elecmonkey made their first contribution in [#6476](#6476) * @jsparkdev made their first contribution in [#6472](#6472)

github-actions bot assigned hyf0 Oct 7, 2025

hyf0 force-pushed the 10-07-fix_expose_includedependenciesrecursively_to_typescript_wrapper branch from eacd579 to ed91e85 Compare October 7, 2025 15:51

hyf0 changed the title ~~fix: expose includeDependenciesRecursively to TypeScript wrapper~~ fix: pass advancedChunks#includeDependenciesRecursively to rust Oct 7, 2025

hyf0 force-pushed the 10-07-fix_expose_includedependenciesrecursively_to_typescript_wrapper branch from ed91e85 to 0e71f54 Compare October 7, 2025 15:54

IWANABETHATGUY approved these changes Oct 7, 2025

View reviewed changes

hyf0 mentioned this pull request Oct 7, 2025

Should emit error when entry chunks generates exports for non-entry modules with preserveEntrySinatures: 'strict' #6449

Closed

hyf0 added the graphite: merge label Oct 7, 2025

fix: pass advancedChunks#includeDependenciesRecursively to rust (#6448

ff1a4b0

)

graphite-app bot force-pushed the 10-07-fix_expose_includedependenciesrecursively_to_typescript_wrapper branch from 0e71f54 to ff1a4b0 Compare October 7, 2025 16:09

hyf0 added the trigger: preview label Oct 7, 2025

Copilot AI mentioned this pull request Oct 7, 2025

feat: Add validation for includeDependenciesRecursively: false with strict entry signatures #6451

Closed

11 tasks

graphite-app bot merged commit ff1a4b0 into main Oct 7, 2025
52 checks passed

graphite-app bot deleted the 10-07-fix_expose_includedependenciesrecursively_to_typescript_wrapper branch October 7, 2025 16:24

graphite-app bot removed the graphite: merge label Oct 7, 2025

github-actions bot mentioned this pull request Oct 13, 2025

release: v1.0.0-beta.43 #6503

Merged

sapphi-red mentioned this pull request Oct 15, 2025

[Bug]: shared chunk is not generated for modules imported by multiple manual chunks #6083

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: pass `advancedChunks#includeDependenciesRecursively` to rust#6448

fix: pass `advancedChunks#includeDependenciesRecursively` to rust#6448
graphite-app[bot] merged 1 commit intomainfrom
10-07-fix_expose_includedependenciesrecursively_to_typescript_wrapper

hyf0 commented Oct 7, 2025

Uh oh!

hyf0 commented Oct 7, 2025

Uh oh!

netlify bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Oct 7, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

hi-ogawa commented Oct 7, 2025

Uh oh!

ChristopherPHolder commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

hyf0 commented Oct 7, 2025

Uh oh!

hyf0 commented Oct 7, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

graphite-app bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

pkg-pr-new bot commented Oct 7, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025

Benchmarks Rust

Uh oh!

hi-ogawa commented Oct 7, 2025

Uh oh!

ChristopherPHolder commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify bot commented Oct 7, 2025 •

edited

Loading

graphite-app bot commented Oct 7, 2025 •

edited

Loading