Skip to content

Comments

chore(rust/test): split hmr related structs into their own files#6445

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-07-chore_rust_test_split_hmr_related_structs_into_their_own_files
Oct 7, 2025
Merged

chore(rust/test): split hmr related structs into their own files#6445
graphite-app[bot] merged 1 commit intomainfrom
10-07-chore_rust_test_split_hmr_related_structs_into_their_own_files

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Oct 7, 2025

  • Friendly to human and AI to open desired files.

Copy link
Member Author

hyf0 commented Oct 7, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review October 7, 2025 13:12
@hyf0 hyf0 requested review from sapphi-red and shulaoda October 7, 2025 13:22
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Benchmarks Rust

  • target: main(a5ae4f4)
  • pr: 10-07-chore_rust_test_split_hmr_related_structs_into_their_own_files(298d7e9)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     67.6±1.48ms        ? ?/sec    1.02     68.8±1.52ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     75.1±1.93ms        ? ?/sec    1.03     77.2±3.55ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    111.6±4.00ms        ? ?/sec    1.02    113.7±2.54ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    127.8±1.88ms        ? ?/sec    1.02    130.5±2.78ms        ? ?/sec
bundle/bundle@threejs                                        1.00     44.1±0.68ms        ? ?/sec    1.03     45.5±1.68ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     50.5±0.91ms        ? ?/sec    1.04     52.3±1.48ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    436.9±9.23ms        ? ?/sec    1.00    435.5±8.01ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    496.3±6.53ms        ? ?/sec    1.02    506.1±7.30ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.3±1.79ms        ? ?/sec    1.01     89.4±2.43ms        ? ?/sec
scan/scan@threejs                                            1.00     32.9±0.52ms        ? ?/sec    1.00     33.0±0.45ms        ? ?/sec
scan/scan@threejs10x                                         1.00    335.3±5.56ms        ? ?/sec    1.02    341.8±4.45ms        ? ?/sec

@graphite-app graphite-app bot changed the base branch from 10-07-chore_rust_test_render_hmr_errors to graphite-base/6445 October 7, 2025 13:37
@hyf0 hyf0 requested a review from IWANABETHATGUY October 7, 2025 16:34
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 7, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Oct 7, 2025
- Friendly to human and AI to open desired files.
@graphite-app graphite-app bot force-pushed the 10-07-chore_rust_test_split_hmr_related_structs_into_their_own_files branch from 9baf04a to b7103b8 Compare October 7, 2025 19:31
@graphite-app graphite-app bot changed the base branch from graphite-base/6445 to 10-07-chore_rust_test_render_hmr_errors October 7, 2025 19:32
Base automatically changed from 10-07-chore_rust_test_render_hmr_errors to main October 7, 2025 19:45
- Friendly to human and AI to open desired files.
@hyf0 hyf0 force-pushed the 10-07-chore_rust_test_split_hmr_related_structs_into_their_own_files branch from b7103b8 to 298d7e9 Compare October 7, 2025 20:46
@netlify
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 298d7e9
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68e57c3b5550b50008109a90

@graphite-app graphite-app bot merged commit 298d7e9 into main Oct 7, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 10-07-chore_rust_test_split_hmr_related_structs_into_their_own_files branch October 7, 2025 21:02
shulaoda pushed a commit that referenced this pull request Oct 13, 2025
## [1.0.0-beta.43] - 2025-10-13

### 🚀 Features

- add filterVitePlugins utility that uses to skip vite plugins using apply: "serve" (#6502) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial can inline entry logic (#6500) by @shulaoda
- rolldown_plugin_vite_html: align get_imported_chunks logic (#6499) by @shulaoda
- rolldown_plugin_vite_html: align HtmlTagDescriptor (#6498) by @shulaoda
- rolldown_plugin_vite_html: align partial utility functions logic (#6497) by @shulaoda
- rolldown_html_vite_html: align partial inject chunk asset links logic (#6496) by @shulaoda
- rolldown_plugin_vite_html: align `processedHtml` logic (#6494) by @shulaoda
- add `nativeMagicString` options (#6469) by @IWANABETHATGUY
- rust: eagerly cleanup resources when calling `close` (#6483) by @hyf0
- rust: varify if bundler is closed for public API (#6481) by @hyf0
- replace [format] placeholder in chunk filename templates (#6476) by @elecmonkey
- implement synchronous JS callback invocation for paths function (#6474) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial transform hook logic (#6471) by @shulaoda
- Support `output.paths` (#6470) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align script urls handle logic (#6466) by @shulaoda
- add validation for `preserveEntrySignatures` with `includeDependenciesRecursively` option (#6468) by @hyf0
- rolldown_plugin_vite_html: align partial logic (#6465) by @shulaoda
- background sourcemap generation for Javascript transform hooks (#6293) by @IWANABETHATGUY
- rolldown_plugin_vite_html: handle style tag (#6464) by @shulaoda
- rolldown_plugin_vite_html: handle inline style attribute (#6463) by @shulaoda
- rolldown_plugin_vite_html: patially handle vite-ignore attribute (#6462) by @shulaoda
- dev/node: expose errors of `on_hmr_updatrs` to node (#6454) by @hyf0
- dev/node: expose errors of `on_output` to node (#6453) by @hyf0
- dev: expose hmr errors on `on_hmr_updatrs` callback (#6443) by @hyf0

### 🐛 Bug Fixes

- fallback sourcemap generation for `experimental.nativeMagicString: false` (#6488) by @IWANABETHATGUY
- take `resolve.modules` into account (#6484) by @Pickachu
- rolldown: increase tokio blocking threads size for watch mode (#6467) by @Brooooooklyn
- use len_utf16 in magic_string CharToByteMapper (#6461) by @IWANABETHATGUY
- pass `advancedChunks#includeDependenciesRecursively` to rust (#6448) by @hyf0
- dev: should compute hmr update correctly for multiple clients (#6442) by @hyf0
- allow specifying packageJsonPath in PluginContext.load (#6439) by @sapphi-red
- use transform.target as default for minify target when `minify: { compress: true }` (#6433) by @sapphi-red

### 🚜 Refactor

- extract background sourcemap handling into separate methods (#6501) by @IWANABETHATGUY
- rust: only expose methods of `Bundler` for public usage (#6480) by @hyf0
- dev/node: use napi object instead clss for `BindingClientHmrUpdate` (#6456) by @hyf0
- dev/node: improve `DevOnHmrUpdates` API (#6455) by @hyf0

### 📚 Documentation

- update team page and add acknowledgements page (#6495) by @hyf0
- restructure website and files (#6492) by @hyf0
- correct incorrect documentation about the config file (#6472) by @jsparkdev
- options: `experimental.strictExecutionOrder` (#6450) by @hyf0
- adding `why-plugin-hook-filter` in depth (#6446) by @IWANABETHATGUY

### ⚡ Performance

- rolldown: replace serde JSON string escape with simd impl (#6475) by @Brooooooklyn

### ⚙️ Miscellaneous Tasks

- docs: redirect removed path to new locations for compatibility (#6493) by @hyf0
- deps: lock file maintenance npm packages (#6490) by @renovate[bot]
- deps: update github-actions (major) (#6415) by @renovate[bot]
- deps: update github-actions (#6489) by @renovate[bot]
- rust: add comment for `DiagnosticOptions#stabilize_path` (#6447) by @hyf0
- rust: remove unused `BindingHmrOutput` (#6457) by @hyf0
- rolldown_plugin_vite_html: tweak `utils.rs` (#6460) by @shulaoda
- change node version to lts (#6435) by @iiio2
- rust/test: split hmr related structs into their own files (#6445) by @hyf0
- deps: update crate-ci/typos action to v1.38.1 (#6452) by @renovate[bot]
- rust/test: render hmr errors (#6444) by @hyf0
- examples: add `"type": "module"` in `package.json` (#6441) by @iiio2

### ❤️ New Contributors

* @Pickachu made their first contribution in [#6484](#6484)
* @elecmonkey made their first contribution in [#6476](#6476)
* @jsparkdev made their first contribution in [#6472](#6472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants