Skip to content

Comments

feat(dev): expose hmr errors on on_hmr_updatrs callback#6443

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-07-feat_dev_expose_hmr_errors_on_on_hmr_updatrs_callback
Oct 7, 2025
Merged

feat(dev): expose hmr errors on on_hmr_updatrs callback#6443
graphite-app[bot] merged 1 commit intomainfrom
10-07-feat_dev_expose_hmr_errors_on_on_hmr_updatrs_callback

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Oct 7, 2025

No description provided.

Copy link
Member Author

hyf0 commented Oct 7, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review October 7, 2025 12:51
@hyf0 hyf0 requested review from sapphi-red and shulaoda October 7, 2025 12:52
@hyf0 hyf0 force-pushed the 10-07-feat_dev_expose_hmr_errors_on_on_hmr_updatrs_callback branch from 1e0ae07 to cab1598 Compare October 7, 2025 13:02
@hyf0 hyf0 force-pushed the 10-07-fix_dev_should_compute_hmr_update_correctly_for_multiple_clients branch from 5a69d11 to a5a0490 Compare October 7, 2025 13:02
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Benchmarks Rust

  • target: 10-07-fix_dev_should_compute_hmr_update_correctly_for_multiple_clients(e76271a)
  • pr: 10-07-feat_dev_expose_hmr_errors_on_on_hmr_updatrs_callback(3cf8f44)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.11     73.3±2.34ms        ? ?/sec    1.00     66.3±1.82ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     77.8±1.51ms        ? ?/sec    1.00     75.2±2.48ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    116.5±2.39ms        ? ?/sec    1.00    114.2±4.22ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.05    134.0±3.91ms        ? ?/sec    1.00    127.1±3.59ms        ? ?/sec
bundle/bundle@threejs                                        1.07     46.1±1.00ms        ? ?/sec    1.00     43.3±0.65ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.04     53.3±1.71ms        ? ?/sec    1.00     51.5±1.00ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    438.7±7.22ms        ? ?/sec    1.00    434.6±7.70ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    511.9±9.68ms        ? ?/sec    1.00   510.2±11.24ms        ? ?/sec
scan/scan@rome_ts                                            1.00     89.8±2.04ms        ? ?/sec    1.00     89.4±2.05ms        ? ?/sec
scan/scan@threejs                                            1.01     33.2±2.02ms        ? ?/sec    1.00     32.8±0.68ms        ? ?/sec
scan/scan@threejs10x                                         1.00    332.2±5.27ms        ? ?/sec    1.03    343.3±7.57ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 7, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 10-07-fix_dev_should_compute_hmr_update_correctly_for_multiple_clients branch from a5a0490 to e76271a Compare October 7, 2025 13:19
@graphite-app graphite-app bot force-pushed the 10-07-feat_dev_expose_hmr_errors_on_on_hmr_updatrs_callback branch from cab1598 to 3cf8f44 Compare October 7, 2025 13:20
Base automatically changed from 10-07-fix_dev_should_compute_hmr_update_correctly_for_multiple_clients to main October 7, 2025 13:33
@graphite-app graphite-app bot merged commit 3cf8f44 into main Oct 7, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 10-07-feat_dev_expose_hmr_errors_on_on_hmr_updatrs_callback branch October 7, 2025 13:36
shulaoda pushed a commit that referenced this pull request Oct 13, 2025
## [1.0.0-beta.43] - 2025-10-13

### 🚀 Features

- add filterVitePlugins utility that uses to skip vite plugins using apply: "serve" (#6502) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial can inline entry logic (#6500) by @shulaoda
- rolldown_plugin_vite_html: align get_imported_chunks logic (#6499) by @shulaoda
- rolldown_plugin_vite_html: align HtmlTagDescriptor (#6498) by @shulaoda
- rolldown_plugin_vite_html: align partial utility functions logic (#6497) by @shulaoda
- rolldown_html_vite_html: align partial inject chunk asset links logic (#6496) by @shulaoda
- rolldown_plugin_vite_html: align `processedHtml` logic (#6494) by @shulaoda
- add `nativeMagicString` options (#6469) by @IWANABETHATGUY
- rust: eagerly cleanup resources when calling `close` (#6483) by @hyf0
- rust: varify if bundler is closed for public API (#6481) by @hyf0
- replace [format] placeholder in chunk filename templates (#6476) by @elecmonkey
- implement synchronous JS callback invocation for paths function (#6474) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial transform hook logic (#6471) by @shulaoda
- Support `output.paths` (#6470) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align script urls handle logic (#6466) by @shulaoda
- add validation for `preserveEntrySignatures` with `includeDependenciesRecursively` option (#6468) by @hyf0
- rolldown_plugin_vite_html: align partial logic (#6465) by @shulaoda
- background sourcemap generation for Javascript transform hooks (#6293) by @IWANABETHATGUY
- rolldown_plugin_vite_html: handle style tag (#6464) by @shulaoda
- rolldown_plugin_vite_html: handle inline style attribute (#6463) by @shulaoda
- rolldown_plugin_vite_html: patially handle vite-ignore attribute (#6462) by @shulaoda
- dev/node: expose errors of `on_hmr_updatrs` to node (#6454) by @hyf0
- dev/node: expose errors of `on_output` to node (#6453) by @hyf0
- dev: expose hmr errors on `on_hmr_updatrs` callback (#6443) by @hyf0

### 🐛 Bug Fixes

- fallback sourcemap generation for `experimental.nativeMagicString: false` (#6488) by @IWANABETHATGUY
- take `resolve.modules` into account (#6484) by @Pickachu
- rolldown: increase tokio blocking threads size for watch mode (#6467) by @Brooooooklyn
- use len_utf16 in magic_string CharToByteMapper (#6461) by @IWANABETHATGUY
- pass `advancedChunks#includeDependenciesRecursively` to rust (#6448) by @hyf0
- dev: should compute hmr update correctly for multiple clients (#6442) by @hyf0
- allow specifying packageJsonPath in PluginContext.load (#6439) by @sapphi-red
- use transform.target as default for minify target when `minify: { compress: true }` (#6433) by @sapphi-red

### 🚜 Refactor

- extract background sourcemap handling into separate methods (#6501) by @IWANABETHATGUY
- rust: only expose methods of `Bundler` for public usage (#6480) by @hyf0
- dev/node: use napi object instead clss for `BindingClientHmrUpdate` (#6456) by @hyf0
- dev/node: improve `DevOnHmrUpdates` API (#6455) by @hyf0

### 📚 Documentation

- update team page and add acknowledgements page (#6495) by @hyf0
- restructure website and files (#6492) by @hyf0
- correct incorrect documentation about the config file (#6472) by @jsparkdev
- options: `experimental.strictExecutionOrder` (#6450) by @hyf0
- adding `why-plugin-hook-filter` in depth (#6446) by @IWANABETHATGUY

### ⚡ Performance

- rolldown: replace serde JSON string escape with simd impl (#6475) by @Brooooooklyn

### ⚙️ Miscellaneous Tasks

- docs: redirect removed path to new locations for compatibility (#6493) by @hyf0
- deps: lock file maintenance npm packages (#6490) by @renovate[bot]
- deps: update github-actions (major) (#6415) by @renovate[bot]
- deps: update github-actions (#6489) by @renovate[bot]
- rust: add comment for `DiagnosticOptions#stabilize_path` (#6447) by @hyf0
- rust: remove unused `BindingHmrOutput` (#6457) by @hyf0
- rolldown_plugin_vite_html: tweak `utils.rs` (#6460) by @shulaoda
- change node version to lts (#6435) by @iiio2
- rust/test: split hmr related structs into their own files (#6445) by @hyf0
- deps: update crate-ci/typos action to v1.38.1 (#6452) by @renovate[bot]
- rust/test: render hmr errors (#6444) by @hyf0
- examples: add `"type": "module"` in `package.json` (#6441) by @iiio2

### ❤️ New Contributors

* @Pickachu made their first contribution in [#6484](#6484)
* @elecmonkey made their first contribution in [#6476](#6476)
* @jsparkdev made their first contribution in [#6472](#6472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants