Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 3, 2025

dce-only minification reverse transformed optional chaining even if target is set to es2019.

refs vitejs/rolldown-vite#440

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit d5bafe0
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68df7092f0f405000801051b
😎 Deploy Preview https://deploy-preview-6402--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Benchmarks Rust

  • target: main(a5ddc2e)
  • pr: 10-03-fix_respect_target_in_dce-only_mode(d5bafe0)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     77.0±2.48ms        ? ?/sec    1.02     78.3±2.30ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     85.6±2.17ms        ? ?/sec    1.00     85.7±2.60ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    120.9±4.50ms        ? ?/sec    1.00    120.1±2.24ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    136.7±3.24ms        ? ?/sec    1.00    137.3±3.64ms        ? ?/sec
bundle/bundle@threejs                                        1.01     48.0±2.89ms        ? ?/sec    1.00     47.7±2.66ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     55.0±2.24ms        ? ?/sec    1.00     54.9±1.08ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    461.4±6.39ms        ? ?/sec    1.00    462.4±6.03ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    529.3±4.85ms        ? ?/sec    1.00    527.8±5.59ms        ? ?/sec
scan/scan@rome_ts                                            1.01     92.0±2.08ms        ? ?/sec    1.00     91.3±1.82ms        ? ?/sec
scan/scan@threejs                                            1.00     33.8±0.52ms        ? ?/sec    1.00     33.7±0.51ms        ? ?/sec
scan/scan@threejs10x                                         1.01    350.5±4.48ms        ? ?/sec    1.00    348.0±5.15ms        ? ?/sec

@sapphi-red sapphi-red self-assigned this Oct 3, 2025
@sapphi-red sapphi-red marked this pull request as ready for review October 3, 2025 03:20
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 3, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Oct 3, 2025
dce-only minification reverse transformed optional chaining even if `target` is set to `es2019`.

refs vitejs/rolldown-vite#440
@graphite-app graphite-app bot force-pushed the 10-03-fix_respect_target_in_dce-only_mode branch from 3801577 to 2e259f7 Compare October 3, 2025 06:34
dce-only minification reverse transformed optional chaining even if `target` is set to `es2019`.

refs vitejs/rolldown-vite#440
@graphite-app graphite-app bot force-pushed the 10-03-fix_respect_target_in_dce-only_mode branch from 2e259f7 to d5bafe0 Compare October 3, 2025 06:43
@graphite-app graphite-app bot merged commit d5bafe0 into main Oct 3, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 10-03-fix_respect_target_in_dce-only_mode branch October 3, 2025 06:57
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
shulaoda pushed a commit that referenced this pull request Oct 7, 2025
## [1.0.0-beta.42] - 2025-10-07

### 🚀 Features

- rolldown: oxc v0.94.0 (#6428) by @Boshen
- add CLI environment flag (#6426) by @IWANABETHATGUY
- dev: use `RebuildStrategy#Auto` by default (#6420) by @hyf0
- rolldown_plugin_vite_html: introduce html plugin state (#6413) by @shulaoda
- dev: expose build errors via `DevOptions#on_output` (#6412) by @hyf0
- dev: add binding for `DevOptions#rebuild_strategy` (#6396) by @hyf0
- dev: add `RebuildStrategy::Auto` to issue rebuild automatically if detecting full reload hmr update (#6395) by @hyf0
- debug: inject `call_id` for `renderChunk` hook (#6392) by @hyf0
- node/dev: add `DevEngine#close` (#6377) by @hyf0
- rust/dev: add `DevEngine#close` (#6376) by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_react_refresh_wrapper: register exports in next microtask (#6423) by @sapphi-red
- plugin/vite-resolve: try original extension before replacing with TS variants (#6421) by @sapphi-red
- node/resolve: take custom package json path into account (#6419) by @hyf0
- dev: call `watchChange` hook (#6403) by @sapphi-red
- use minify options for DCE for dce-only minify (#6402) by @sapphi-red
- respect package.json type field in plugin-resolved modules (#6400) by @hyf0
- returning result of this.resolve in resolveDynamicImport hook impacts bundle size (#6397) by @sapphi-red
- rolldown_plugin_json: avoid generating named exports for `eval` and `arguments` (#6381) by @sapphi-red
- use static property for namespace object (#6383) by @sapphi-red

### 🚜 Refactor

- rust: improve constuction of `PackageJson` and remove unused fields (#6418) by @hyf0
- introduce `BindingResult` to pass errors from rust to js (#6390) by @hyf0
- rust: rename eager_rebuild to rebuild_strategy with enum (#6394) by @hyf0
- rust/binding: use `BindingError` to cover `JsError` and `NativeError` (#6388) by @hyf0
- rust/binding: rename `BindingError` to `NativeError` (#6387) by @hyf0

### 📚 Documentation

- tweak built-in transforms section (#6384) by @sapphi-red

### ⚡ Performance

- dev: avoid frequent `setTimeout` -> `clearTimeout` (#6375) by @sapphi-red

### 🧪 Testing

- hmr: include generated bundle for full reloads in snapshots (#6374) by @sapphi-red
- dev: add test about doing hmr with not being affected by not executed modules (#6360) by @hyf0
- hmr: hmr patch file generation for `this.addWatchFile` (#5219) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.38.0 (#6431) by @renovate[bot]
- deps: update crate-ci/typos action to v1.37.3 (#6429) by @renovate[bot]
- deps: lock file maintenance npm packages (#6417) by @renovate[bot]
- deps: update github-actions (#6414) by @renovate[bot]
- rust/test: sensible heading level for build snapshot of config variant (#6408) by @hyf0
- rust/test: introduce `SnapshotSection` to organize snapshot content (#6407) by @hyf0
- rust/test: extract `ArtifactsSnapshot` and `BuildRoundOutput` into standalone files (#6406) by @hyf0
- rust/test: introduce `ArtifactsSnapshot` to make generating snapshot more clear (#6405) by @hyf0
- deps: update crate-ci/typos action to v1.37.2 (#6409) by @renovate[bot]
- fix `GitHub` casing (#6401) by @iiio2
- rust: remove unused `rolldown_binding_watcher` crate (#6386) by @hyf0
- deps: update crate-ci/typos action to v1.37.1 (#6391) by @renovate[bot]
- node: rename `normalizeErrors` into `aggregateBindingErrorsIntoError` (#6389) by @hyf0
- fix typos (#6382) by @sapphi-red
- deps: update dependency tsdown to v0.15.6 (#6379) by @renovate[bot]
- deps: update crate-ci/typos action to v1.37.0 (#6380) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.11 (#6378) by @renovate[bot]
- add comment to `add_watch_file` that the path should be a normalized absolute path (#6371) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.16.10 (#6373) by @renovate[bot]

Co-authored-by: sapphi-red <[email protected]>
graphite-app bot pushed a commit that referenced this pull request Oct 7, 2025
…{ compress: true }` (#6433)

use transform.target as default for minify target when `minify: { compress: true }` and `minify: { compress: {/* target not specified */} }`.

refs #6402, vitejs/rolldown-vite#440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants