refactor: introduce BindingResult to pass errors from rust to js
#6390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2025
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Benchmarks Rust |
hyf0
force-pushed
the
10-01-refactor_introduce_bindingerrorsor_to_hold_errors
branch
from
664270c to
0730db7
Compare
graphite-app
bot
changed the base branch from
10-01-chore_node_rename_normalizeerrors_into_aggregatebindingerrorsintoerror_
to
graphite-base/6390
hyf0
force-pushed
the
10-01-refactor_introduce_bindingerrorsor_to_hold_errors
branch
from
0730db7 to
84f43b9
Compare
hyf0
force-pushed
the
graphite-base/6390
branch
from
6db427d to
3532484
Compare
hyf0
changed the base branch from
graphite-base/6390
to
10-01-chore_node_rename_normalizeerrors_into_aggregatebindingerrorsintoerror_
hyf0
changed the title
BindingErrorsOr to hold errorsBindingResult to pass errors from rust to js
Base automatically changed from
10-01-chore_node_rename_normalizeerrors_into_aggregatebindingerrorsintoerror_
to
main
October 1, 2025 16:16
hyf0
force-pushed
the
10-01-refactor_introduce_bindingerrorsor_to_hold_errors
branch
from
84f43b9 to
1befe5c
Compare
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
IWANABETHATGUY
approved these changes
Oct 2, 2025
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
…6390) Issues of previous error mechanism: - `BindingOutputs#errors` always got consumed in the js side. It adds unnecessary lazy overhead. - `BindingOutputs#errors` doesn't force develpoers to handle errors. - `BindingOutputs#errors` get handled repeatly due to each function doesn't know about whether its caller handles the error or not. --- This PR introduces `BindingResult` as a unify way, not just for passing `BindingOutput`, to handle errors passed from rust to js. - Errors are forced to handle if you want to use the value - Errors are designed to only need to be handled once. Related might still need to polished, but I want to set a correct direction first.
graphite-app
bot
force-pushed
the
10-01-refactor_introduce_bindingerrorsor_to_hold_errors
branch
from
1befe5c to
3449b6f
Compare
…6390) Issues of previous error mechanism: - `BindingOutputs#errors` always got consumed in the js side. It adds unnecessary lazy overhead. - `BindingOutputs#errors` doesn't force develpoers to handle errors. - `BindingOutputs#errors` get handled repeatly due to each function doesn't know about whether its caller handles the error or not. --- This PR introduces `BindingResult` as a unify way, not just for passing `BindingOutput`, to handle errors passed from rust to js. - Errors are forced to handle if you want to use the value - Errors are designed to only need to be handled once. Related might still need to polished, but I want to set a correct direction first.
graphite-app
bot
force-pushed
the
10-01-refactor_introduce_bindingerrorsor_to_hold_errors
branch
from
3449b6f to
7dec746
Compare
graphite-app
bot
deleted the
10-01-refactor_introduce_bindingerrorsor_to_hold_errors
branch
shulaoda
pushed a commit
that referenced
this pull request
Oct 7, 2025
## [1.0.0-beta.42] - 2025-10-07 ### 🚀 Features - rolldown: oxc v0.94.0 (#6428) by @Boshen - add CLI environment flag (#6426) by @IWANABETHATGUY - dev: use `RebuildStrategy#Auto` by default (#6420) by @hyf0 - rolldown_plugin_vite_html: introduce html plugin state (#6413) by @shulaoda - dev: expose build errors via `DevOptions#on_output` (#6412) by @hyf0 - dev: add binding for `DevOptions#rebuild_strategy` (#6396) by @hyf0 - dev: add `RebuildStrategy::Auto` to issue rebuild automatically if detecting full reload hmr update (#6395) by @hyf0 - debug: inject `call_id` for `renderChunk` hook (#6392) by @hyf0 - node/dev: add `DevEngine#close` (#6377) by @hyf0 - rust/dev: add `DevEngine#close` (#6376) by @hyf0 ### 🐛 Bug Fixes - rolldown_plugin_react_refresh_wrapper: register exports in next microtask (#6423) by @sapphi-red - plugin/vite-resolve: try original extension before replacing with TS variants (#6421) by @sapphi-red - node/resolve: take custom package json path into account (#6419) by @hyf0 - dev: call `watchChange` hook (#6403) by @sapphi-red - use minify options for DCE for dce-only minify (#6402) by @sapphi-red - respect package.json type field in plugin-resolved modules (#6400) by @hyf0 - returning result of this.resolve in resolveDynamicImport hook impacts bundle size (#6397) by @sapphi-red - rolldown_plugin_json: avoid generating named exports for `eval` and `arguments` (#6381) by @sapphi-red - use static property for namespace object (#6383) by @sapphi-red ### 🚜 Refactor - rust: improve constuction of `PackageJson` and remove unused fields (#6418) by @hyf0 - introduce `BindingResult` to pass errors from rust to js (#6390) by @hyf0 - rust: rename eager_rebuild to rebuild_strategy with enum (#6394) by @hyf0 - rust/binding: use `BindingError` to cover `JsError` and `NativeError` (#6388) by @hyf0 - rust/binding: rename `BindingError` to `NativeError` (#6387) by @hyf0 ### 📚 Documentation - tweak built-in transforms section (#6384) by @sapphi-red ### ⚡ Performance - dev: avoid frequent `setTimeout` -> `clearTimeout` (#6375) by @sapphi-red ### 🧪 Testing - hmr: include generated bundle for full reloads in snapshots (#6374) by @sapphi-red - dev: add test about doing hmr with not being affected by not executed modules (#6360) by @hyf0 - hmr: hmr patch file generation for `this.addWatchFile` (#5219) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update crate-ci/typos action to v1.38.0 (#6431) by @renovate[bot] - deps: update crate-ci/typos action to v1.37.3 (#6429) by @renovate[bot] - deps: lock file maintenance npm packages (#6417) by @renovate[bot] - deps: update github-actions (#6414) by @renovate[bot] - rust/test: sensible heading level for build snapshot of config variant (#6408) by @hyf0 - rust/test: introduce `SnapshotSection` to organize snapshot content (#6407) by @hyf0 - rust/test: extract `ArtifactsSnapshot` and `BuildRoundOutput` into standalone files (#6406) by @hyf0 - rust/test: introduce `ArtifactsSnapshot` to make generating snapshot more clear (#6405) by @hyf0 - deps: update crate-ci/typos action to v1.37.2 (#6409) by @renovate[bot] - fix `GitHub` casing (#6401) by @iiio2 - rust: remove unused `rolldown_binding_watcher` crate (#6386) by @hyf0 - deps: update crate-ci/typos action to v1.37.1 (#6391) by @renovate[bot] - node: rename `normalizeErrors` into `aggregateBindingErrorsIntoError` (#6389) by @hyf0 - fix typos (#6382) by @sapphi-red - deps: update dependency tsdown to v0.15.6 (#6379) by @renovate[bot] - deps: update crate-ci/typos action to v1.37.0 (#6380) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.16.11 (#6378) by @renovate[bot] - add comment to `add_watch_file` that the path should be a normalized absolute path (#6371) by @sapphi-red - deps: update dependency rolldown-plugin-dts to v0.16.10 (#6373) by @renovate[bot] Co-authored-by: sapphi-red <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues of previous error mechanism:
BindingOutputs#errorsalways got consumed in the js side. It adds unnecessary lazy overhead.BindingOutputs#errorsdoesn't force develpoers to handle errors.BindingOutputs#errorsget handled repeatly due to each function doesn't know about whether its caller handles the error or not.This PR introduces
BindingResultas a unify way, not just for passingBindingOutput, to handle errors passed from rust to js.Related might still need to polished, but I want to set a correct direction first.