Skip to content

fix: 'asset' module type and CJS format produces warnings and wrong output #6369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Sep 29, 2025
Merged

fix: 'asset' module type and CJS format produces warnings and wrong output #6369

graphite-app merged 1 commit into from
Sep 29, 2025

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Sep 29, 2025 •
edited
Loading

closed #6345

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Sep 29, 2025

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY changed the title fix: 6345 fix: update asset filename format in module type handling Sep 29, 2025
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 29, 2025 03:24
@netlify
Copy link

netlify bot commented Sep 29, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 239951d
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68da1edc649a550008646467

@IWANABETHATGUY IWANABETHATGUY changed the title fix: update asset filename format in module type handling fix: 'asset' module type and CJS format produces warnings and wrong output Sep 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025 •
edited
Loading

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     67.3±2.76ms        ? ?/sec    1.11     74.8±1.95ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     73.1±1.47ms        ? ?/sec    1.12     82.1±2.00ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    109.4±2.43ms        ? ?/sec    1.06    115.7±2.08ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    125.0±1.70ms        ? ?/sec    1.05    131.8±2.06ms        ? ?/sec
bundle/bundle@threejs                                        1.00     43.6±2.74ms        ? ?/sec    1.04     45.3±1.01ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     50.8±1.80ms        ? ?/sec    1.05     53.2±0.82ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    426.1±5.52ms        ? ?/sec    1.04    443.8±5.87ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    487.8±3.25ms        ? ?/sec    1.04    507.4±4.18ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.3±2.46ms        ? ?/sec    1.03     89.0±1.96ms        ? ?/sec
scan/scan@threejs                                            1.00     32.0±0.45ms        ? ?/sec    1.05     33.6±2.25ms        ? ?/sec
scan/scan@threejs10x                                         1.00    331.4±4.32ms        ? ?/sec    1.03    339.9±6.86ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 29, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot merged commit 239951d into main Sep 29, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 09-29-fix_6345 branch September 29, 2025 06:06
@github-actions github-actions bot mentioned this pull request Sep 29, 2025
Merged
shulaoda added a commit that referenced this pull request Sep 30, 2025
@github-actions @shulaoda
release: v1.0.0-beta.41 (#6372)
bc2b152 
## [1.0.0-beta.41] - 2025-09-29

### 🚀 Features

- support `output.generatedCode.symbols` (#6335) by @IWANABETHATGUY
- rolldown: oxc v0.93.0 (#6364) by @Boshen
- rolldown_plugin_vite_html: finish script tag logic (#6355) by @shulaoda
- rolldown_plugin_vite_html: support inline html proxy (#6353) by @shulaoda
- rolldown_plugin_vite_html: transform script tag into js import (#6351) by @shulaoda
- rolldown_plugin_vite_html: overwrite script src url (#6349) by @shulaoda
- rolldown_plugin_vite_html: remove `vite-ignore` attribute (#6348) by @shulaoda
- rolldown_plugin_vite_html: use `html5ever` and `markup5ever_rcdom` (#6327) by @shulaoda
- rust/dev: support `on_output` callback (#6330) by @hyf0
- rust/dev: support `disable_watcher` (#6329) by @hyf0
- dev: introduce client/session concept into dev engine (#6297) by @hyf0

### 🐛 Bug Fixes

- 'asset' module type and CJS format produces warnings and wrong output (#6369) by @IWANABETHATGUY
- inlining constants in CJS by optimization.inlineConst incorrectly inlines non-constant values if the value is assigned more than once (#6328) by @IWANABETHATGUY
- dev: add `hasLatestBuildOutput` instead of `scheduleBuildIfStale` and add edit-reload test (#6321) by @sapphi-red

### 🚜 Refactor

- rust/dev: rename `HmrManager` to `HmrState` and tweak namings (#6358) by @hyf0
- rust/dev: use `Bundler` to expose hmr related methods (#6356) by @hyf0
- rolldown_plugin_vite_html: use `html5gum` instead (#6343) by @shulaoda
- dev: remove deprecated `new` field from HMR options and related configurations (#6337) by @hyf0
- dev: remove unused hmr API (#6336) by @hyf0
- make `cjs_ast_analyzer` immutable for better reuse (#6326) by @IWANABETHATGUY
- simplify logic for determining entry is_lived (#6325) by @IWANABETHATGUY

### ⚡ Performance

- dev: compute depended data incrementally (#6357) by @hyf0

### 🧪 Testing

- rust/hmr: use dev engine to test hmr (#6334) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: update notify (#6368) by @sapphi-red
- deps: lock file maintenance npm packages (#6366) by @renovate[bot]
- deps: update github-actions (#6365) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.9 (#6354) by @renovate[bot]
- deps: update dependency tsdown to v0.15.5 (#6350) by @renovate[bot]
- node: use `catalog:` to unify version of all dependencies (#6339) by @hyf0
- ci: unify node installation via oxc-project/setup-node (#6338) by @Boshen
- deps: update crate-ci/typos action to v1.36.3 (#6341) by @renovate[bot]
- remove unused snapshots (#6331) by @IWANABETHATGUY

Co-authored-by: shulaoda <[email protected]>
@sapphi-red sapphi-red mentioned this pull request Oct 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shulaoda shulaoda shulaoda approved these changes

@hyf0 hyf0 Awaiting requested review from hyf0

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: 'asset' module type and CJS format produces warnings and wrong output

3 participants

@IWANABETHATGUY @shulaoda