Skip to content

refactor(dev): remove unused hmr API #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Sep 25, 2025
Merged

refactor(dev): remove unused hmr API #6336

graphite-app merged 1 commit into from
Sep 25, 2025

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Sep 25, 2025

No description provided.

@hyf0 hyf0 marked this pull request as ready for review September 25, 2025 13:52
@hyf0 hyf0 mentioned this pull request Sep 25, 2025
Merged
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Sep 25, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 force-pushed the 09-25-refactor_dev_remove_unused_hmr_api branch 2 times, most recently from ab379db to 39a12f2 Compare September 25, 2025 14:06
@socket-security
Copy link

socket-security bot commented Sep 25, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Addedstyled-components@​6.1.199410010086100

View full report

@hyf0 hyf0 requested review from sapphi-red and shulaoda September 25, 2025 14:20
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

Benchmarks Rust

  • target: 09-25-test_rust_hmr_use_dev_engine_to_test_hmr(a7d345f)
  • pr: 09-25-refactor_dev_remove_unused_hmr_api(c376f9d)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     74.1±2.17ms        ? ?/sec    1.00     72.6±3.67ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.05     82.3±1.99ms        ? ?/sec    1.00     78.5±2.41ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    115.8±2.72ms        ? ?/sec    1.00    115.3±3.25ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    132.1±1.95ms        ? ?/sec    1.00    131.3±3.55ms        ? ?/sec
bundle/bundle@threejs                                        1.01     46.3±2.76ms        ? ?/sec    1.00     45.9±2.57ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     53.6±0.91ms        ? ?/sec    1.00     52.4±1.00ms        ? ?/sec
bundle/bundle@threejs10x                                     1.04    448.7±6.39ms        ? ?/sec    1.00    432.4±7.70ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.04    514.3±5.12ms        ? ?/sec    1.00    493.3±5.71ms        ? ?/sec
scan/scan@rome_ts                                            1.02     89.6±1.65ms        ? ?/sec    1.00     87.8±1.81ms        ? ?/sec
scan/scan@threejs                                            1.01     33.3±0.82ms        ? ?/sec    1.00     32.8±2.10ms        ? ?/sec
scan/scan@threejs10x                                         1.01    339.3±3.82ms        ? ?/sec    1.00    336.4±6.55ms        ? ?/sec

@hyf0 hyf0 mentioned this pull request Sep 25, 2025
Merged
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 25, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 09-25-test_rust_hmr_use_dev_engine_to_test_hmr branch from 2c03bf0 to a7d345f Compare September 25, 2025 16:26
@graphite-app graphite-app bot force-pushed the 09-25-refactor_dev_remove_unused_hmr_api branch from 39a12f2 to c376f9d Compare September 25, 2025 16:27
Base automatically changed from 09-25-test_rust_hmr_use_dev_engine_to_test_hmr to main September 25, 2025 16:39
@graphite-app graphite-app bot merged commit c376f9d into main Sep 25, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 09-25-refactor_dev_remove_unused_hmr_api branch September 25, 2025 16:41
@github-actions github-actions bot mentioned this pull request Sep 29, 2025
Merged
shulaoda added a commit that referenced this pull request Sep 30, 2025
@github-actions @shulaoda
release: v1.0.0-beta.41 (#6372)
bc2b152 
## [1.0.0-beta.41] - 2025-09-29

### 🚀 Features

- support `output.generatedCode.symbols` (#6335) by @IWANABETHATGUY
- rolldown: oxc v0.93.0 (#6364) by @Boshen
- rolldown_plugin_vite_html: finish script tag logic (#6355) by @shulaoda
- rolldown_plugin_vite_html: support inline html proxy (#6353) by @shulaoda
- rolldown_plugin_vite_html: transform script tag into js import (#6351) by @shulaoda
- rolldown_plugin_vite_html: overwrite script src url (#6349) by @shulaoda
- rolldown_plugin_vite_html: remove `vite-ignore` attribute (#6348) by @shulaoda
- rolldown_plugin_vite_html: use `html5ever` and `markup5ever_rcdom` (#6327) by @shulaoda
- rust/dev: support `on_output` callback (#6330) by @hyf0
- rust/dev: support `disable_watcher` (#6329) by @hyf0
- dev: introduce client/session concept into dev engine (#6297) by @hyf0

### 🐛 Bug Fixes

- 'asset' module type and CJS format produces warnings and wrong output (#6369) by @IWANABETHATGUY
- inlining constants in CJS by optimization.inlineConst incorrectly inlines non-constant values if the value is assigned more than once (#6328) by @IWANABETHATGUY
- dev: add `hasLatestBuildOutput` instead of `scheduleBuildIfStale` and add edit-reload test (#6321) by @sapphi-red

### 🚜 Refactor

- rust/dev: rename `HmrManager` to `HmrState` and tweak namings (#6358) by @hyf0
- rust/dev: use `Bundler` to expose hmr related methods (#6356) by @hyf0
- rolldown_plugin_vite_html: use `html5gum` instead (#6343) by @shulaoda
- dev: remove deprecated `new` field from HMR options and related configurations (#6337) by @hyf0
- dev: remove unused hmr API (#6336) by @hyf0
- make `cjs_ast_analyzer` immutable for better reuse (#6326) by @IWANABETHATGUY
- simplify logic for determining entry is_lived (#6325) by @IWANABETHATGUY

### ⚡ Performance

- dev: compute depended data incrementally (#6357) by @hyf0

### 🧪 Testing

- rust/hmr: use dev engine to test hmr (#6334) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: update notify (#6368) by @sapphi-red
- deps: lock file maintenance npm packages (#6366) by @renovate[bot]
- deps: update github-actions (#6365) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.9 (#6354) by @renovate[bot]
- deps: update dependency tsdown to v0.15.5 (#6350) by @renovate[bot]
- node: use `catalog:` to unify version of all dependencies (#6339) by @hyf0
- ci: unify node installation via oxc-project/setup-node (#6338) by @Boshen
- deps: update crate-ci/typos action to v1.36.3 (#6341) by @renovate[bot]
- remove unused snapshots (#6331) by @IWANABETHATGUY

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shulaoda shulaoda shulaoda approved these changes

@sapphi-red sapphi-red Awaiting requested review from sapphi-red

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hyf0 @shulaoda