-
Notifications
You must be signed in to change notification settings - Fork 678
feat: support output.generatedCode.symbols
#6335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support output.generatedCode.symbols
#6335
Conversation
How to use the Graphite Merge QueueAdd the label graphite: merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
❌ Deploy Preview for rolldown-rs failed.
|
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Benchmarks Rust |
97096a3 to
5cc43d8
Compare
@rolldown/browser
@rolldown/debug
@rolldown/pluginutils
rolldown
@rolldown/binding-android-arm64
@rolldown/binding-darwin-arm64
@rolldown/binding-darwin-x64
@rolldown/binding-freebsd-x64
@rolldown/binding-linux-arm-gnueabihf
@rolldown/binding-linux-arm64-gnu
@rolldown/binding-linux-arm64-musl
@rolldown/binding-linux-x64-gnu
@rolldown/binding-linux-x64-musl
@rolldown/binding-openharmony-arm64
@rolldown/binding-wasm32-wasi
@rolldown/binding-win32-arm64-msvc
@rolldown/binding-win32-ia32-msvc
@rolldown/binding-win32-x64-msvc
commit: |
5cc43d8 to
09c979f
Compare
shulaoda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should add some related descriptions? This isn’t a blocker.
Done |
Merge activity
|
implemented https://rollupjs.org/configuration-options/#output-generatedcode-symbols ### TL;DR Added support for the `generatedCode.symbols` option to control Symbol.toStringTag usage in namespace objects. ### What changed? - Added a new `GeneratedCodeOptions` type with `symbols` and `preset` properties - Updated the `render_namespace_markers` function to use the `symbols` option when determining whether to include Symbol.toStringTag - Modified CJS, IIFE, and UMD format renderers to pass the generated code options - Added tests for the new functionality - Updated CLI help text to include the new options ### How to test? You can test this feature by setting the `generatedCode.symbols` option in your Rolldown config: ``` export default { output: { generatedCode: { symbols: true } } } ``` When enabled, namespace objects will include `Symbol.toStringTag` with a value of 'Module'. ### Why make this change? This change adds support for controlling whether Symbol.toStringTag is used in namespace objects, which is a feature available in other bundlers. Using Symbol.toStringTag can help with debugging by providing better object representation when inspecting modules, but it might not be desired in all environments, especially those targeting older browsers.lghttps://rollupjs.org/configuration-options/#output-generatedcode-symbolslg
09c979f to
621b527
Compare
## [1.0.0-beta.41] - 2025-09-29 ### 🚀 Features - support `output.generatedCode.symbols` (#6335) by @IWANABETHATGUY - rolldown: oxc v0.93.0 (#6364) by @Boshen - rolldown_plugin_vite_html: finish script tag logic (#6355) by @shulaoda - rolldown_plugin_vite_html: support inline html proxy (#6353) by @shulaoda - rolldown_plugin_vite_html: transform script tag into js import (#6351) by @shulaoda - rolldown_plugin_vite_html: overwrite script src url (#6349) by @shulaoda - rolldown_plugin_vite_html: remove `vite-ignore` attribute (#6348) by @shulaoda - rolldown_plugin_vite_html: use `html5ever` and `markup5ever_rcdom` (#6327) by @shulaoda - rust/dev: support `on_output` callback (#6330) by @hyf0 - rust/dev: support `disable_watcher` (#6329) by @hyf0 - dev: introduce client/session concept into dev engine (#6297) by @hyf0 ### 🐛 Bug Fixes - 'asset' module type and CJS format produces warnings and wrong output (#6369) by @IWANABETHATGUY - inlining constants in CJS by optimization.inlineConst incorrectly inlines non-constant values if the value is assigned more than once (#6328) by @IWANABETHATGUY - dev: add `hasLatestBuildOutput` instead of `scheduleBuildIfStale` and add edit-reload test (#6321) by @sapphi-red ### 🚜 Refactor - rust/dev: rename `HmrManager` to `HmrState` and tweak namings (#6358) by @hyf0 - rust/dev: use `Bundler` to expose hmr related methods (#6356) by @hyf0 - rolldown_plugin_vite_html: use `html5gum` instead (#6343) by @shulaoda - dev: remove deprecated `new` field from HMR options and related configurations (#6337) by @hyf0 - dev: remove unused hmr API (#6336) by @hyf0 - make `cjs_ast_analyzer` immutable for better reuse (#6326) by @IWANABETHATGUY - simplify logic for determining entry is_lived (#6325) by @IWANABETHATGUY ### ⚡ Performance - dev: compute depended data incrementally (#6357) by @hyf0 ### 🧪 Testing - rust/hmr: use dev engine to test hmr (#6334) by @hyf0 ### ⚙️ Miscellaneous Tasks - deps: update notify (#6368) by @sapphi-red - deps: lock file maintenance npm packages (#6366) by @renovate[bot] - deps: update github-actions (#6365) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.16.9 (#6354) by @renovate[bot] - deps: update dependency tsdown to v0.15.5 (#6350) by @renovate[bot] - node: use `catalog:` to unify version of all dependencies (#6339) by @hyf0 - ci: unify node installation via oxc-project/setup-node (#6338) by @Boshen - deps: update crate-ci/typos action to v1.36.3 (#6341) by @renovate[bot] - remove unused snapshots (#6331) by @IWANABETHATGUY Co-authored-by: shulaoda <[email protected]>

implemented https://rollupjs.org/configuration-options/#output-generatedcode-symbols
TL;DR
Added support for the
generatedCode.symbolsoption to control Symbol.toStringTag usage in namespace objects.What changed?
GeneratedCodeOptionstype withsymbolsandpresetpropertiesrender_namespace_markersfunction to use thesymbolsoption when determining whether to include Symbol.toStringTagHow to test?
You can test this feature by setting the
generatedCode.symbolsoption in your Rolldown config:When enabled, namespace objects will include
Symbol.toStringTagwith a value of 'Module'.Why make this change?
This change adds support for controlling whether Symbol.toStringTag is used in namespace objects, which is a feature available in other bundlers. Using Symbol.toStringTag can help with debugging by providing better object representation when inspecting modules, but it might not be desired in all environments, especially those targeting older browsers.lghttps://rollupjs.org/configuration-options/#output-generatedcode-symbolslg