Skip to content

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Sep 25, 2025

Test crates/rolldown/tests/rolldown/topics/hmr/generate_patch_error would be handled when solving #6319.

Copy link
Member Author

hyf0 commented Sep 25, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review September 25, 2025 13:11
@netlify
Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit a7d345f
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68d56d45b2e3a60008fb8ffe

@hyf0 hyf0 requested review from sapphi-red and shulaoda September 25, 2025 13:11
@hyf0 hyf0 force-pushed the 09-25-test_rust_hmr_use_dev_engine_to_test_hmr branch from c3a4cba to a4777a6 Compare September 25, 2025 13:12
@hyf0 hyf0 mentioned this pull request Sep 25, 2025
@hyf0 hyf0 force-pushed the 09-25-test_rust_hmr_use_dev_engine_to_test_hmr branch from a4777a6 to 2c03bf0 Compare September 25, 2025 13:19
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Benchmarks Rust

  • target: main(07af74c)
  • pr: 09-25-test_rust_hmr_use_dev_engine_to_test_hmr(a7d345f)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     73.5±2.37ms        ? ?/sec    1.02     75.0±2.69ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     81.3±2.57ms        ? ?/sec    1.00     81.3±3.02ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    116.5±3.60ms        ? ?/sec    1.00    116.0±3.82ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    132.5±2.83ms        ? ?/sec    1.01    133.2±4.16ms        ? ?/sec
bundle/bundle@threejs                                        1.00     46.5±2.58ms        ? ?/sec    1.00     46.5±3.03ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     53.4±1.21ms        ? ?/sec    1.00     52.8±1.01ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    448.4±6.86ms        ? ?/sec    1.00    449.9±8.43ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    517.9±7.41ms        ? ?/sec    1.00    516.1±7.61ms        ? ?/sec
scan/scan@rome_ts                                            1.01     90.2±2.30ms        ? ?/sec    1.00     89.2±1.93ms        ? ?/sec
scan/scan@threejs                                            1.01     34.1±2.12ms        ? ?/sec    1.00     33.7±1.90ms        ? ?/sec
scan/scan@threejs10x                                         1.00    339.8±6.27ms        ? ?/sec    1.00    340.1±5.56ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 25, 2025

Merge activity

Test `crates/rolldown/tests/rolldown/topics/hmr/generate_patch_error` would be handled when solving #6319.
@graphite-app graphite-app bot force-pushed the 09-25-test_rust_hmr_use_dev_engine_to_test_hmr branch from 2c03bf0 to a7d345f Compare September 25, 2025 16:26
@graphite-app graphite-app bot merged commit a7d345f into main Sep 25, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 09-25-test_rust_hmr_use_dev_engine_to_test_hmr branch September 25, 2025 16:39
shulaoda added a commit that referenced this pull request Sep 30, 2025
## [1.0.0-beta.41] - 2025-09-29

### 🚀 Features

- support `output.generatedCode.symbols` (#6335) by @IWANABETHATGUY
- rolldown: oxc v0.93.0 (#6364) by @Boshen
- rolldown_plugin_vite_html: finish script tag logic (#6355) by @shulaoda
- rolldown_plugin_vite_html: support inline html proxy (#6353) by @shulaoda
- rolldown_plugin_vite_html: transform script tag into js import (#6351) by @shulaoda
- rolldown_plugin_vite_html: overwrite script src url (#6349) by @shulaoda
- rolldown_plugin_vite_html: remove `vite-ignore` attribute (#6348) by @shulaoda
- rolldown_plugin_vite_html: use `html5ever` and `markup5ever_rcdom` (#6327) by @shulaoda
- rust/dev: support `on_output` callback (#6330) by @hyf0
- rust/dev: support `disable_watcher` (#6329) by @hyf0
- dev: introduce client/session concept into dev engine (#6297) by @hyf0

### 🐛 Bug Fixes

- 'asset' module type and CJS format produces warnings and wrong output (#6369) by @IWANABETHATGUY
- inlining constants in CJS by optimization.inlineConst incorrectly inlines non-constant values if the value is assigned more than once (#6328) by @IWANABETHATGUY
- dev: add `hasLatestBuildOutput` instead of `scheduleBuildIfStale` and add edit-reload test (#6321) by @sapphi-red

### 🚜 Refactor

- rust/dev: rename `HmrManager` to `HmrState` and tweak namings (#6358) by @hyf0
- rust/dev: use `Bundler` to expose hmr related methods (#6356) by @hyf0
- rolldown_plugin_vite_html: use `html5gum` instead (#6343) by @shulaoda
- dev: remove deprecated `new` field from HMR options and related configurations (#6337) by @hyf0
- dev: remove unused hmr API (#6336) by @hyf0
- make `cjs_ast_analyzer` immutable for better reuse (#6326) by @IWANABETHATGUY
- simplify logic for determining entry is_lived (#6325) by @IWANABETHATGUY

### ⚡ Performance

- dev: compute depended data incrementally (#6357) by @hyf0

### 🧪 Testing

- rust/hmr: use dev engine to test hmr (#6334) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: update notify (#6368) by @sapphi-red
- deps: lock file maintenance npm packages (#6366) by @renovate[bot]
- deps: update github-actions (#6365) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.9 (#6354) by @renovate[bot]
- deps: update dependency tsdown to v0.15.5 (#6350) by @renovate[bot]
- node: use `catalog:` to unify version of all dependencies (#6339) by @hyf0
- ci: unify node installation via oxc-project/setup-node (#6338) by @Boshen
- deps: update crate-ci/typos action to v1.36.3 (#6341) by @renovate[bot]
- remove unused snapshots (#6331) by @IWANABETHATGUY

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants