fix(dev): add hasLatestBuildOutput instead of scheduleBuildIfStale and add edit-reload test
#6321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sapphi-red
added a commit
to vitejs/rolldown-vite
that referenced
this pull request
Sep 24, 2025
sapphi-red
added a commit
to vitejs/rolldown-vite
that referenced
this pull request
Sep 24, 2025
Contributor
Benchmarks Rust
|
Member
|
Good one. I plan to finish #6297 today. It's a big change. I want to delay this before we merge it, so we could see if there's any conflict we need to solve. I could solve conflicts, just want to check how they interacts. |
hyf0
force-pushed
the
09-24-fix_dev_add_haslatestbuildoutput_instead_of_schedulebuildifstale_and_add_edit-reload_test
branch
from
a1a01a6 to
22e13da
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
hyf0
approved these changes
Sep 24, 2025
Member
Merge activity
|
…` and add edit-reload test (#6321) The following scenario was not working. 1. Edit file 2. HMR happens 3. Reload the window (stale content was shown!) It is because the fix for `ensure_latest_build_output` in #6262 wasn't applied to `scheduleBuildIfStale`. To achieve that properly, it requires a significant refactor as `scheduleBuildIfStale` returns a future of the build process. For now, I added `hasLatestBuildOutput` instead to achieve a similar behavior. This approach has a problem of race condition because the internal state mutex is released in between the `hasLatestBuildOutput` call and the `ensureLatestBuildOutput` call. But this should be good enough for the initial implementation.
graphite-app
bot
force-pushed
the
09-24-fix_dev_add_haslatestbuildoutput_instead_of_schedulebuildifstale_and_add_edit-reload_test
branch
from
22e13da to
1d3b957
Compare
graphite-app
bot
deleted the
09-24-fix_dev_add_haslatestbuildoutput_instead_of_schedulebuildifstale_and_add_edit-reload_test
branch
sapphi-red
added a commit
to vitejs/rolldown-vite
that referenced
this pull request
Sep 25, 2025
sapphi-red
added a commit
to vitejs/rolldown-vite
that referenced
this pull request
Sep 29, 2025
shulaoda
added a commit
that referenced
this pull request
Sep 30, 2025
## [1.0.0-beta.41] - 2025-09-29 ### 🚀 Features - support `output.generatedCode.symbols` (#6335) by @IWANABETHATGUY - rolldown: oxc v0.93.0 (#6364) by @Boshen - rolldown_plugin_vite_html: finish script tag logic (#6355) by @shulaoda - rolldown_plugin_vite_html: support inline html proxy (#6353) by @shulaoda - rolldown_plugin_vite_html: transform script tag into js import (#6351) by @shulaoda - rolldown_plugin_vite_html: overwrite script src url (#6349) by @shulaoda - rolldown_plugin_vite_html: remove `vite-ignore` attribute (#6348) by @shulaoda - rolldown_plugin_vite_html: use `html5ever` and `markup5ever_rcdom` (#6327) by @shulaoda - rust/dev: support `on_output` callback (#6330) by @hyf0 - rust/dev: support `disable_watcher` (#6329) by @hyf0 - dev: introduce client/session concept into dev engine (#6297) by @hyf0 ### 🐛 Bug Fixes - 'asset' module type and CJS format produces warnings and wrong output (#6369) by @IWANABETHATGUY - inlining constants in CJS by optimization.inlineConst incorrectly inlines non-constant values if the value is assigned more than once (#6328) by @IWANABETHATGUY - dev: add `hasLatestBuildOutput` instead of `scheduleBuildIfStale` and add edit-reload test (#6321) by @sapphi-red ### 🚜 Refactor - rust/dev: rename `HmrManager` to `HmrState` and tweak namings (#6358) by @hyf0 - rust/dev: use `Bundler` to expose hmr related methods (#6356) by @hyf0 - rolldown_plugin_vite_html: use `html5gum` instead (#6343) by @shulaoda - dev: remove deprecated `new` field from HMR options and related configurations (#6337) by @hyf0 - dev: remove unused hmr API (#6336) by @hyf0 - make `cjs_ast_analyzer` immutable for better reuse (#6326) by @IWANABETHATGUY - simplify logic for determining entry is_lived (#6325) by @IWANABETHATGUY ### ⚡ Performance - dev: compute depended data incrementally (#6357) by @hyf0 ### 🧪 Testing - rust/hmr: use dev engine to test hmr (#6334) by @hyf0 ### ⚙️ Miscellaneous Tasks - deps: update notify (#6368) by @sapphi-red - deps: lock file maintenance npm packages (#6366) by @renovate[bot] - deps: update github-actions (#6365) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.16.9 (#6354) by @renovate[bot] - deps: update dependency tsdown to v0.15.5 (#6350) by @renovate[bot] - node: use `catalog:` to unify version of all dependencies (#6339) by @hyf0 - ci: unify node installation via oxc-project/setup-node (#6338) by @Boshen - deps: update crate-ci/typos action to v1.36.3 (#6341) by @renovate[bot] - remove unused snapshots (#6331) by @IWANABETHATGUY Co-authored-by: shulaoda <[email protected]>
sapphi-red
added a commit
to vitejs/rolldown-vite
that referenced
this pull request
Sep 30, 2025
sapphi-red
added a commit
to vitejs/rolldown-vite
that referenced
this pull request
Oct 15, 2025
sapphi-red
added a commit
to vitejs/rolldown-vite
that referenced
this pull request
Oct 21, 2025
sapphi-red
added a commit
to vitejs/rolldown-vite
that referenced
this pull request
Oct 28, 2025
sapphi-red
added a commit
to vitejs/rolldown-vite
that referenced
this pull request
Nov 17, 2025
sapphi-red
added a commit
to vitejs/rolldown-vite
that referenced
this pull request
Nov 19, 2025
sapphi-red
added a commit
to vitejs/rolldown-vite
that referenced
this pull request
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following scenario was not working.
It is because the fix for
ensure_latest_build_outputin #6262 wasn't applied toscheduleBuildIfStale. To achieve that properly, it requires a significant refactor asscheduleBuildIfStalereturns a future of the build process. For now, I addedhasLatestBuildOutputinstead to achieve a similar behavior. This approach has a problem of race condition because the internal state mutex is released in between thehasLatestBuildOutputcall and theensureLatestBuildOutputcall. But this should be good enough for the initial implementation.