chore: use lto: thin in profile mode for better profiling experience.#6320
Merged
graphite-app[bot] merged 1 commit intomainfrom Sep 24, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
IWANABETHATGUY
changed the title
thin in profile modelto: thin in profile mode
IWANABETHATGUY
changed the title
lto: thin in profile modelto: thin in profile mode for better profiling experience.
sapphi-red
approved these changes
Sep 24, 2025
Contributor
Merge activity
|
…e. (#6320) <img width="1681" height="296" alt="image" src="https://github.com/user-attachments/assets/4cf47982-03c3-470b-b4d8-0ff0ede29da9" /> According to my experiment, `thin` is only a little smaller than `fat`, and for an incremental release rebuild, `lto: fat` cost about 2min30s, but `lto: thin` only took 1min31s, that's 40% compile time improvement. It is fine to keep `lto: fat` in release mode, since it has theoretically better performance and smaller binary size, but we don't need it in `profile` mode, which may run multiple times in short term.
graphite-app
bot
force-pushed
the
09-24-chore_use_thin_in_profile_mode
branch
from
d2f8609 to
5eb6049
Compare
shulaoda
pushed a commit
that referenced
this pull request
Sep 24, 2025
## [1.0.0-beta.40] - 2025-09-24 ⚡ Sourcemap Performance Boost - 20%-30% faster sourcemap generation - Consistent gains across all platforms ### 🚀 Features - rolldown: oxc v0.92.0 (#6322) by @Boshen - adding partial `MagicString` binding (#6289) by @IWANABETHATGUY - rolldown_plugin_vite_html: initialize (#6292) by @shulaoda ### 🐛 Bug Fixes - rolldown_plugin_react_refresh_wrapper: avoid using cwd to allow using as a callable plugin (#6318) by @sapphi-red - rolldown_plugin_transform: resolve tsconfig from absolute path (#6311) by @shulaoda ### 🚜 Refactor - Construct MagicString with `Cow<str>` instead of `&str` (#6288) by @IWANABETHATGUY - throw error if generating oxc runtime helper fails (#6291) by @shulaoda ### 📚 Documentation - add more description about sourcemapIgnoreList (#6314) by @IWANABETHATGUY ### ⚡ Performance - reduce `sourcemap_ignore_list` js function call (#6313) by @IWANABETHATGUY - string_wizard: use memchr to find patterns in `replace` (#6312) by @IWANABETHATGUY - simplify sourcemap token processing in collapse_sourcemaps (#6310) by @IWANABETHATGUY - rolldown: some minor perf optimization (#6306) by @Brooooooklyn - rolldown: fine-tuning the tokio scheduler (#6272) by @Brooooooklyn ### ⚙️ Miscellaneous Tasks - deps: lock file maintenance rust crates (#6302) by @renovate[bot] - deps: lock file maintenance npm packages (#6301) by @renovate[bot] - use `lto: thin` in profile mode for better profiling experience. (#6320) by @IWANABETHATGUY - adjust the tokio runtime config in bench (#6305) by @Brooooooklyn - deps: update dependency rolldown-plugin-dts to v0.16.8 (#6307) by @renovate[bot]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to my experiment,
thinis only a little smaller thanfat, and for an incremental release rebuild,lto: fatcost about 2min30s, butlto: thinonly took 1min31s, that's 40% compile time improvement. It is fine to keeplto: fatin release mode, since it has theoretically better performance and smaller binary size, but we don't need it inprofilemode, which may run multiple times in short term.