Skip to content

Comments

fix(rolldown_plugin_react_refresh_wrapper): avoid using cwd to allow using as a callable plugin#6318

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-24-fix_rolldown_plugin_react_refresh_wrapper_avoid_using_cwd_to_allow_using_as_a_callable_plugin
Sep 24, 2025
Merged

fix(rolldown_plugin_react_refresh_wrapper): avoid using cwd to allow using as a callable plugin#6318
graphite-app[bot] merged 1 commit intomainfrom
09-24-fix_rolldown_plugin_react_refresh_wrapper_avoid_using_cwd_to_allow_using_as_a_callable_plugin

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Sep 24, 2025

Follow up to #6229

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 35bb00e
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68d36b8cbef76e0008831197
😎 Deploy Preview https://deploy-preview-6318--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sapphi-red sapphi-red self-assigned this Sep 24, 2025
@sapphi-red sapphi-red marked this pull request as ready for review September 24, 2025 03:45
@sapphi-red sapphi-red requested a review from shulaoda September 24, 2025 03:48
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 24, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 09-24-fix_rolldown_plugin_react_refresh_wrapper_avoid_using_cwd_to_allow_using_as_a_callable_plugin branch from 71811be to 35bb00e Compare September 24, 2025 03:54
@graphite-app graphite-app bot merged commit 35bb00e into main Sep 24, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 09-24-fix_rolldown_plugin_react_refresh_wrapper_avoid_using_cwd_to_allow_using_as_a_callable_plugin branch September 24, 2025 04:04
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(d630de1)
  • pr: 09-24-fix_rolldown_plugin_react_refresh_wrapper_avoid_using_cwd_to_allow_using_as_a_callable_plugin(35bb00e)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     78.2±1.79ms        ? ?/sec    1.05     81.8±3.56ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     88.3±2.27ms        ? ?/sec    1.02     89.9±2.97ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    121.8±3.97ms        ? ?/sec    1.01    123.5±2.15ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    140.7±2.65ms        ? ?/sec    1.01    142.5±1.99ms        ? ?/sec
bundle/bundle@threejs                                        1.00     46.0±2.28ms        ? ?/sec    1.03     47.4±1.09ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     54.5±1.26ms        ? ?/sec    1.03     56.4±1.83ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    466.2±6.90ms        ? ?/sec    1.00    468.1±5.72ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    552.3±7.65ms        ? ?/sec    1.00    548.0±8.06ms        ? ?/sec
scan/scan@rome_ts                                            1.04     99.0±2.59ms        ? ?/sec    1.00     95.2±1.77ms        ? ?/sec
scan/scan@threejs                                            1.06     36.4±1.98ms        ? ?/sec    1.00     34.4±1.10ms        ? ?/sec
scan/scan@threejs10x                                         1.02    362.0±8.19ms        ? ?/sec    1.00   353.9±10.66ms        ? ?/sec

shulaoda pushed a commit that referenced this pull request Sep 24, 2025
## [1.0.0-beta.40] - 2025-09-24

⚡ Sourcemap Performance Boost
- 20%-30% faster sourcemap generation
- Consistent gains across all platforms

### 🚀 Features

- rolldown: oxc v0.92.0 (#6322) by @Boshen
- adding partial `MagicString` binding (#6289) by @IWANABETHATGUY
- rolldown_plugin_vite_html: initialize (#6292) by @shulaoda

### 🐛 Bug Fixes

- rolldown_plugin_react_refresh_wrapper: avoid using cwd to allow using as a callable plugin (#6318) by @sapphi-red
- rolldown_plugin_transform: resolve tsconfig from absolute path (#6311) by @shulaoda

### 🚜 Refactor

- Construct MagicString with `Cow<str>` instead of `&str` (#6288) by @IWANABETHATGUY
- throw error if generating oxc runtime helper fails (#6291) by @shulaoda

### 📚 Documentation

- add more description about sourcemapIgnoreList (#6314) by @IWANABETHATGUY

### ⚡ Performance

- reduce `sourcemap_ignore_list` js function call (#6313) by @IWANABETHATGUY
- string_wizard: use memchr to find patterns in `replace` (#6312) by @IWANABETHATGUY
- simplify sourcemap token processing in collapse_sourcemaps (#6310) by @IWANABETHATGUY
- rolldown: some minor perf optimization (#6306) by @Brooooooklyn
- rolldown: fine-tuning the tokio scheduler (#6272) by @Brooooooklyn

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance rust crates (#6302) by @renovate[bot]
- deps: lock file maintenance npm packages (#6301) by @renovate[bot]
- use `lto: thin` in profile mode for better profiling experience. (#6320) by @IWANABETHATGUY
- adjust the tokio runtime config in bench (#6305) by @Brooooooklyn
- deps: update dependency rolldown-plugin-dts to v0.16.8 (#6307) by @renovate[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants