Skip to content

Comments

perf(string_wizard): use memchr to find patterns in replace#6312

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-23-perf_string_wizard_use_memchr_to_find_patterns_in_replace_
Sep 23, 2025
Merged

perf(string_wizard): use memchr to find patterns in replace#6312
graphite-app[bot] merged 1 commit intomainfrom
09-23-perf_string_wizard_use_memchr_to_find_patterns_in_replace_

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Sep 23, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit bb5c1df
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68d244635adf3900080ba476

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 23, 2025 06:04
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

Benchmarks Rust

  • target: main(740d5c7)
  • pr: 09-23-perf_string_wizard_use_memchr_to_find_patterns_in_replace_(bb5c1df)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     84.5±3.43ms        ? ?/sec    1.00     83.5±2.45ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     90.9±1.98ms        ? ?/sec    1.03     93.5±2.24ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    122.2±4.27ms        ? ?/sec    1.03    125.6±2.62ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    144.7±2.98ms        ? ?/sec    1.01    145.5±2.88ms        ? ?/sec
bundle/bundle@threejs                                        1.00     47.2±2.40ms        ? ?/sec    1.00     47.2±1.35ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     55.7±1.05ms        ? ?/sec    1.02     57.0±1.87ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    481.5±6.59ms        ? ?/sec    1.01    487.4±9.45ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    560.8±7.51ms        ? ?/sec    1.01    565.6±8.46ms        ? ?/sec
scan/scan@rome_ts                                            1.00     95.7±1.76ms        ? ?/sec    1.01     97.1±2.28ms        ? ?/sec
scan/scan@threejs                                            1.00     35.0±1.70ms        ? ?/sec    1.00     35.1±1.79ms        ? ?/sec
scan/scan@threejs10x                                         1.00    359.6±6.95ms        ? ?/sec    1.00    358.9±7.05ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 23, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 09-23-perf_string_wizard_use_memchr_to_find_patterns_in_replace_ branch from 754ebe5 to bb5c1df Compare September 23, 2025 06:55
@graphite-app graphite-app bot merged commit bb5c1df into main Sep 23, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 09-23-perf_string_wizard_use_memchr_to_find_patterns_in_replace_ branch September 23, 2025 07:04
shulaoda pushed a commit that referenced this pull request Sep 24, 2025
## [1.0.0-beta.40] - 2025-09-24

⚡ Sourcemap Performance Boost
- 20%-30% faster sourcemap generation
- Consistent gains across all platforms

### 🚀 Features

- rolldown: oxc v0.92.0 (#6322) by @Boshen
- adding partial `MagicString` binding (#6289) by @IWANABETHATGUY
- rolldown_plugin_vite_html: initialize (#6292) by @shulaoda

### 🐛 Bug Fixes

- rolldown_plugin_react_refresh_wrapper: avoid using cwd to allow using as a callable plugin (#6318) by @sapphi-red
- rolldown_plugin_transform: resolve tsconfig from absolute path (#6311) by @shulaoda

### 🚜 Refactor

- Construct MagicString with `Cow<str>` instead of `&str` (#6288) by @IWANABETHATGUY
- throw error if generating oxc runtime helper fails (#6291) by @shulaoda

### 📚 Documentation

- add more description about sourcemapIgnoreList (#6314) by @IWANABETHATGUY

### ⚡ Performance

- reduce `sourcemap_ignore_list` js function call (#6313) by @IWANABETHATGUY
- string_wizard: use memchr to find patterns in `replace` (#6312) by @IWANABETHATGUY
- simplify sourcemap token processing in collapse_sourcemaps (#6310) by @IWANABETHATGUY
- rolldown: some minor perf optimization (#6306) by @Brooooooklyn
- rolldown: fine-tuning the tokio scheduler (#6272) by @Brooooooklyn

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance rust crates (#6302) by @renovate[bot]
- deps: lock file maintenance npm packages (#6301) by @renovate[bot]
- use `lto: thin` in profile mode for better profiling experience. (#6320) by @IWANABETHATGUY
- adjust the tokio runtime config in bench (#6305) by @Brooooooklyn
- deps: update dependency rolldown-plugin-dts to v0.16.8 (#6307) by @renovate[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants