Skip to content

Comments

fix(rolldown_plugin_transform): resolve tsconfig from absolute path#6311

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-23-fix_rolldown_plugin_transform_resolve_tsconfig_from_absolute_path
Sep 23, 2025
Merged

fix(rolldown_plugin_transform): resolve tsconfig from absolute path#6311
graphite-app[bot] merged 1 commit intomainfrom
09-23-fix_rolldown_plugin_transform_resolve_tsconfig_from_absolute_path

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Sep 23, 2025 •
edited
Loading

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Sep 23, 2025

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Sep 23, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit e593ff6
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68d26bcc291a640008b0020e

@shulaoda shulaoda marked this pull request as ready for review September 23, 2025 03:48
@shulaoda shulaoda force-pushed the 09-23-fix_rolldown_plugin_transform_resolve_tsconfig_from_absolute_path branch from c3f9bca to bd5a5b0 Compare September 23, 2025 03:49
sapphi-red
sapphi-red reviewed Sep 23, 2025
View reviewed changes
@shulaoda shulaoda requested a review from sapphi-red September 23, 2025 04:03
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(bb5c1df)
  • pr: 09-23-fix_rolldown_plugin_transform_resolve_tsconfig_from_absolute_path(e593ff6)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     76.5±2.05ms        ? ?/sec    1.00     76.0±1.22ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     85.3±1.33ms        ? ?/sec    1.00     85.4±1.52ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    117.4±1.61ms        ? ?/sec    1.00    117.6±2.09ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    138.5±2.59ms        ? ?/sec    1.00    138.5±2.47ms        ? ?/sec
bundle/bundle@threejs                                        1.00     44.1±1.77ms        ? ?/sec    1.00     44.3±0.89ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     53.1±0.73ms        ? ?/sec    1.01     53.5±1.06ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    460.5±4.85ms        ? ?/sec    1.00    460.8±4.84ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    539.5±3.47ms        ? ?/sec    1.00    539.2±4.61ms        ? ?/sec
scan/scan@rome_ts                                            1.00     92.2±1.57ms        ? ?/sec    1.01     93.2±3.43ms        ? ?/sec
scan/scan@threejs                                            1.00     33.1±0.42ms        ? ?/sec    1.01     33.3±0.40ms        ? ?/sec
scan/scan@threejs10x                                         1.00    346.2±4.76ms        ? ?/sec    1.01    348.2±5.43ms        ? ?/sec

sapphi-red
sapphi-red approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but it would be nice to have a test for this one.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 23, 2025 •
edited
Loading

Merge activity

  • Sep 23, 5:00 AM UTC: shulaoda added this pull request to the Graphite merge queue.
  • Sep 23, 5:10 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test (windows-latest) / Node Test').
  • Sep 23, 9:37 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 23, 9:43 AM UTC: shulaoda added this pull request to the Graphite merge queue.
  • Sep 23, 9:55 AM UTC: Merged by the Graphite merge queue.

graphite-app bot pushed a commit that referenced this pull request Sep 23, 2025
@shulaoda
fix(rolldown_plugin_transform): resolve tsconfig from absolute path (#…
1bd2548 
…6311)

closes #6164, vitejs/rolldown-vite#424
@graphite-app graphite-app bot force-pushed the 09-23-fix_rolldown_plugin_transform_resolve_tsconfig_from_absolute_path branch from bd5a5b0 to 1bd2548 Compare September 23, 2025 05:00
@graphite-app graphite-app bot force-pushed the 09-23-fix_rolldown_plugin_transform_resolve_tsconfig_from_absolute_path branch from 1bd2548 to e593ff6 Compare September 23, 2025 09:43
@graphite-app graphite-app bot merged commit e593ff6 into main Sep 23, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 09-23-fix_rolldown_plugin_transform_resolve_tsconfig_from_absolute_path branch September 23, 2025 09:55
@github-actions github-actions bot mentioned this pull request Sep 24, 2025
Merged
shulaoda pushed a commit that referenced this pull request Sep 24, 2025
@github-actions
release: v1.0.0-beta.40 (#6324)
8b29afa 
## [1.0.0-beta.40] - 2025-09-24

⚡ Sourcemap Performance Boost
- 20%-30% faster sourcemap generation
- Consistent gains across all platforms

### 🚀 Features

- rolldown: oxc v0.92.0 (#6322) by @Boshen
- adding partial `MagicString` binding (#6289) by @IWANABETHATGUY
- rolldown_plugin_vite_html: initialize (#6292) by @shulaoda

### 🐛 Bug Fixes

- rolldown_plugin_react_refresh_wrapper: avoid using cwd to allow using as a callable plugin (#6318) by @sapphi-red
- rolldown_plugin_transform: resolve tsconfig from absolute path (#6311) by @shulaoda

### 🚜 Refactor

- Construct MagicString with `Cow<str>` instead of `&str` (#6288) by @IWANABETHATGUY
- throw error if generating oxc runtime helper fails (#6291) by @shulaoda

### 📚 Documentation

- add more description about sourcemapIgnoreList (#6314) by @IWANABETHATGUY

### ⚡ Performance

- reduce `sourcemap_ignore_list` js function call (#6313) by @IWANABETHATGUY
- string_wizard: use memchr to find patterns in `replace` (#6312) by @IWANABETHATGUY
- simplify sourcemap token processing in collapse_sourcemaps (#6310) by @IWANABETHATGUY
- rolldown: some minor perf optimization (#6306) by @Brooooooklyn
- rolldown: fine-tuning the tokio scheduler (#6272) by @Brooooooklyn

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance rust crates (#6302) by @renovate[bot]
- deps: lock file maintenance npm packages (#6301) by @renovate[bot]
- use `lto: thin` in profile mode for better profiling experience. (#6320) by @IWANABETHATGUY
- adjust the tokio runtime config in bench (#6305) by @Brooooooklyn
- deps: update dependency rolldown-plugin-dts to v0.16.8 (#6307) by @renovate[bot]
@shulaoda shulaoda mentioned this pull request Nov 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

Assignees

@shulaoda shulaoda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: build:transform fails when trying to find tsconfig astro/tsconfigs/strict

2 participants

@shulaoda @sapphi-red