Skip to content

Comments

perf(rolldown): some minor perf optimization#6306

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-22-perf_rolldown_some_minor_perf_optimization
Sep 22, 2025
Merged

perf(rolldown): some minor perf optimization#6306
graphite-app[bot] merged 1 commit intomainfrom
09-22-perf_rolldown_some_minor_perf_optimization

Conversation

@Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Sep 22, 2025

No description provided.

This was referenced Sep 22, 2025
Merged
Merged
Merged
@Brooooooklyn Graphite App
Copy link
Member Author

Brooooooklyn commented Sep 22, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Brooooooklyn Brooooooklyn mentioned this pull request Sep 22, 2025
Merged
@Brooooooklyn Brooooooklyn marked this pull request as ready for review September 22, 2025 13:57
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(ead7523)
  • pr: 09-22-perf_rolldown_some_minor_perf_optimization(3360cc1)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     80.6±2.43ms        ? ?/sec    1.00     80.7±2.09ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     90.0±1.77ms        ? ?/sec    1.00     89.9±2.30ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    121.5±3.70ms        ? ?/sec    1.00    121.1±1.94ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    141.8±1.74ms        ? ?/sec    1.00    142.2±2.98ms        ? ?/sec
bundle/bundle@threejs                                        1.00     46.2±0.88ms        ? ?/sec    1.00     46.2±0.91ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     55.0±1.11ms        ? ?/sec    1.00     55.2±1.12ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    468.0±4.07ms        ? ?/sec    1.02    476.3±5.61ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    553.0±5.73ms        ? ?/sec    1.01    557.3±6.22ms        ? ?/sec
scan/scan@rome_ts                                            1.02     98.8±1.98ms        ? ?/sec    1.00     96.8±1.61ms        ? ?/sec
scan/scan@threejs                                            1.00     34.5±0.61ms        ? ?/sec    1.02     35.1±1.72ms        ? ?/sec
scan/scan@threejs10x                                         1.00    356.6±6.18ms        ? ?/sec    1.00    357.2±6.64ms        ? ?/sec

@graphite-app graphite-app bot changed the base branch from chore_adjust_bench_tokio_runtime to graphite-base/6306 September 22, 2025 14:20
@graphite-app graphite-app bot force-pushed the 09-22-perf_rolldown_some_minor_perf_optimization branch from b705204 to e812cbe Compare September 22, 2025 14:45
@graphite-app graphite-app bot changed the base branch from graphite-base/6306 to main September 22, 2025 14:45
@graphite-app graphite-app bot force-pushed the 09-22-perf_rolldown_some_minor_perf_optimization branch from e812cbe to 1f79bdb Compare September 22, 2025 14:46
@netlify
Copy link

netlify bot commented Sep 22, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 3360cc1
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68d16412e336690008f6c5d9

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 22, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 09-22-perf_rolldown_some_minor_perf_optimization branch from 1f79bdb to 3360cc1 Compare September 22, 2025 14:58
@graphite-app graphite-app bot merged commit 3360cc1 into main Sep 22, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 09-22-perf_rolldown_some_minor_perf_optimization branch September 22, 2025 15:10
@github-actions github-actions bot mentioned this pull request Sep 24, 2025
Merged
shulaoda pushed a commit that referenced this pull request Sep 24, 2025
@github-actions
release: v1.0.0-beta.40 (#6324)
8b29afa 
## [1.0.0-beta.40] - 2025-09-24

⚡ Sourcemap Performance Boost
- 20%-30% faster sourcemap generation
- Consistent gains across all platforms

### 🚀 Features

- rolldown: oxc v0.92.0 (#6322) by @Boshen
- adding partial `MagicString` binding (#6289) by @IWANABETHATGUY
- rolldown_plugin_vite_html: initialize (#6292) by @shulaoda

### 🐛 Bug Fixes

- rolldown_plugin_react_refresh_wrapper: avoid using cwd to allow using as a callable plugin (#6318) by @sapphi-red
- rolldown_plugin_transform: resolve tsconfig from absolute path (#6311) by @shulaoda

### 🚜 Refactor

- Construct MagicString with `Cow<str>` instead of `&str` (#6288) by @IWANABETHATGUY
- throw error if generating oxc runtime helper fails (#6291) by @shulaoda

### 📚 Documentation

- add more description about sourcemapIgnoreList (#6314) by @IWANABETHATGUY

### ⚡ Performance

- reduce `sourcemap_ignore_list` js function call (#6313) by @IWANABETHATGUY
- string_wizard: use memchr to find patterns in `replace` (#6312) by @IWANABETHATGUY
- simplify sourcemap token processing in collapse_sourcemaps (#6310) by @IWANABETHATGUY
- rolldown: some minor perf optimization (#6306) by @Brooooooklyn
- rolldown: fine-tuning the tokio scheduler (#6272) by @Brooooooklyn

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance rust crates (#6302) by @renovate[bot]
- deps: lock file maintenance npm packages (#6301) by @renovate[bot]
- use `lto: thin` in profile mode for better profiling experience. (#6320) by @IWANABETHATGUY
- adjust the tokio runtime config in bench (#6305) by @Brooooooklyn
- deps: update dependency rolldown-plugin-dts to v0.16.8 (#6307) by @renovate[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

@Brooooooklyn Brooooooklyn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Brooooooklyn @IWANABETHATGUY