Skip to content

Comments

feat: background sourcemap generation for Javascript transform hooks#6293

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-21-feat_background_sourcemap_gen
Oct 9, 2025
Merged

feat: background sourcemap generation for Javascript transform hooks#6293
graphite-app[bot] merged 1 commit intomainfrom
09-21-feat_background_sourcemap_gen

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

Copy link
Member Author

IWANABETHATGUY commented Sep 21, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_adding_partial_magicstring_binding branch from aaf7af1 to 52a64f8 Compare September 21, 2025 17:25
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_background_sourcemap_gen branch 2 times, most recently from 13669b7 to 3c99131 Compare September 22, 2025 02:34
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

Benchmarks Rust

  • target: main(f19ff60)
  • pr: 09-21-feat_background_sourcemap_gen(b0e79cb)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.05     69.8±3.06ms        ? ?/sec    1.00     66.7±3.62ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     73.7±2.37ms        ? ?/sec    1.00     72.8±1.43ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    114.0±4.15ms        ? ?/sec    1.00    111.3±1.97ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    129.0±2.75ms        ? ?/sec    1.00    127.6±2.32ms        ? ?/sec
bundle/bundle@threejs                                        1.05     45.1±1.00ms        ? ?/sec    1.00     43.0±0.60ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     51.3±1.33ms        ? ?/sec    1.00     50.4±0.94ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    430.6±9.06ms        ? ?/sec    1.01    435.1±6.22ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    486.7±3.11ms        ? ?/sec    1.02    498.4±5.01ms        ? ?/sec
scan/scan@rome_ts                                            1.01     88.5±1.49ms        ? ?/sec    1.00     87.5±1.46ms        ? ?/sec
scan/scan@threejs                                            1.01     32.5±0.94ms        ? ?/sec    1.00     32.2±0.36ms        ? ?/sec
scan/scan@threejs10x                                         1.02    340.5±4.04ms        ? ?/sec    1.00    334.9±5.28ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_background_sourcemap_gen branch from 3c99131 to e07bcb0 Compare September 22, 2025 03:03
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_adding_partial_magicstring_binding branch from 52a64f8 to b8a3f02 Compare September 22, 2025 03:03
@graphite-app graphite-app bot force-pushed the 09-21-feat_adding_partial_magicstring_binding branch 2 times, most recently from 13bc6ba to 3cf4ac9 Compare September 22, 2025 04:50
@graphite-app graphite-app bot force-pushed the 09-21-feat_background_sourcemap_gen branch from e07bcb0 to 7fbe206 Compare September 22, 2025 04:50
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_adding_partial_magicstring_binding branch from 3cf4ac9 to f65566c Compare September 22, 2025 05:11
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_background_sourcemap_gen branch 2 times, most recently from 2197ba2 to 1cf0639 Compare September 22, 2025 05:40
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_adding_partial_magicstring_binding branch from f65566c to 0743765 Compare September 22, 2025 05:40
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_background_sourcemap_gen branch from 1cf0639 to e94a189 Compare September 22, 2025 07:03
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_adding_partial_magicstring_binding branch from 0743765 to 004c0aa Compare September 22, 2025 07:03
@graphite-app graphite-app bot changed the base branch from 09-21-feat_adding_partial_magicstring_binding to graphite-base/6293 September 22, 2025 11:23
@graphite-app graphite-app bot force-pushed the 09-21-feat_background_sourcemap_gen branch from e94a189 to ddccd31 Compare September 22, 2025 11:53
@graphite-app graphite-app bot changed the base branch from graphite-base/6293 to main September 22, 2025 11:54
@graphite-app graphite-app bot force-pushed the 09-21-feat_background_sourcemap_gen branch from ddccd31 to f2f2a52 Compare September 22, 2025 11:54
@netlify
Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit b0e79cb
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68e7237aa1771a0009729025
😎 Deploy Preview https://deploy-preview-6293--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_background_sourcemap_gen branch from f2f2a52 to 668e72e Compare September 30, 2025 07:40
hyf0
hyf0 previously approved these changes Sep 30, 2025
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_background_sourcemap_gen branch 2 times, most recently from 95194b9 to a0990b4 Compare October 1, 2025 12:13
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_background_sourcemap_gen branch from a77b990 to 5dff12c Compare October 4, 2025 17:11
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 4, 2025

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@6293

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@6293

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@6293

rolldown

npm i https://pkg.pr.new/rolldown@6293

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@6293

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@6293

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@6293

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@6293

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@6293

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@6293

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@6293

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@6293

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@6293

@rolldown/binding-openharmony-arm64

npm i https://pkg.pr.new/@rolldown/binding-openharmony-arm64@6293

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@6293

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@6293

@rolldown/binding-win32-ia32-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-ia32-msvc@6293

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@6293

commit: 5dff12c

@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_background_sourcemap_gen branch 6 times, most recently from c2db636 to cc5f177 Compare October 8, 2025 15:36
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review October 8, 2025 15:45
@IWANABETHATGUY IWANABETHATGUY changed the title feat: background sourcemap gen feat: background sourcemap generation for transform hooks Oct 8, 2025
@IWANABETHATGUY IWANABETHATGUY changed the title feat: background sourcemap generation for transform hooks feat: background sourcemap generation for Javascript transform hooks Oct 8, 2025
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_background_sourcemap_gen branch 3 times, most recently from eb750cd to c218519 Compare October 8, 2025 16:16
@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 October 8, 2025 16:53
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-21-feat_background_sourcemap_gen branch from c218519 to be9e731 Compare October 9, 2025 02:37
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 9, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 09-21-feat_background_sourcemap_gen branch from be9e731 to b0e79cb Compare October 9, 2025 02:52
@graphite-app graphite-app bot merged commit b0e79cb into main Oct 9, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 09-21-feat_background_sourcemap_gen branch October 9, 2025 03:10
shulaoda pushed a commit that referenced this pull request Oct 13, 2025
## [1.0.0-beta.43] - 2025-10-13

### 🚀 Features

- add filterVitePlugins utility that uses to skip vite plugins using apply: "serve" (#6502) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial can inline entry logic (#6500) by @shulaoda
- rolldown_plugin_vite_html: align get_imported_chunks logic (#6499) by @shulaoda
- rolldown_plugin_vite_html: align HtmlTagDescriptor (#6498) by @shulaoda
- rolldown_plugin_vite_html: align partial utility functions logic (#6497) by @shulaoda
- rolldown_html_vite_html: align partial inject chunk asset links logic (#6496) by @shulaoda
- rolldown_plugin_vite_html: align `processedHtml` logic (#6494) by @shulaoda
- add `nativeMagicString` options (#6469) by @IWANABETHATGUY
- rust: eagerly cleanup resources when calling `close` (#6483) by @hyf0
- rust: varify if bundler is closed for public API (#6481) by @hyf0
- replace [format] placeholder in chunk filename templates (#6476) by @elecmonkey
- implement synchronous JS callback invocation for paths function (#6474) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align partial transform hook logic (#6471) by @shulaoda
- Support `output.paths` (#6470) by @IWANABETHATGUY
- rolldown_plugin_vite_html: align script urls handle logic (#6466) by @shulaoda
- add validation for `preserveEntrySignatures` with `includeDependenciesRecursively` option (#6468) by @hyf0
- rolldown_plugin_vite_html: align partial logic (#6465) by @shulaoda
- background sourcemap generation for Javascript transform hooks (#6293) by @IWANABETHATGUY
- rolldown_plugin_vite_html: handle style tag (#6464) by @shulaoda
- rolldown_plugin_vite_html: handle inline style attribute (#6463) by @shulaoda
- rolldown_plugin_vite_html: patially handle vite-ignore attribute (#6462) by @shulaoda
- dev/node: expose errors of `on_hmr_updatrs` to node (#6454) by @hyf0
- dev/node: expose errors of `on_output` to node (#6453) by @hyf0
- dev: expose hmr errors on `on_hmr_updatrs` callback (#6443) by @hyf0

### 🐛 Bug Fixes

- fallback sourcemap generation for `experimental.nativeMagicString: false` (#6488) by @IWANABETHATGUY
- take `resolve.modules` into account (#6484) by @Pickachu
- rolldown: increase tokio blocking threads size for watch mode (#6467) by @Brooooooklyn
- use len_utf16 in magic_string CharToByteMapper (#6461) by @IWANABETHATGUY
- pass `advancedChunks#includeDependenciesRecursively` to rust (#6448) by @hyf0
- dev: should compute hmr update correctly for multiple clients (#6442) by @hyf0
- allow specifying packageJsonPath in PluginContext.load (#6439) by @sapphi-red
- use transform.target as default for minify target when `minify: { compress: true }` (#6433) by @sapphi-red

### 🚜 Refactor

- extract background sourcemap handling into separate methods (#6501) by @IWANABETHATGUY
- rust: only expose methods of `Bundler` for public usage (#6480) by @hyf0
- dev/node: use napi object instead clss for `BindingClientHmrUpdate` (#6456) by @hyf0
- dev/node: improve `DevOnHmrUpdates` API (#6455) by @hyf0

### 📚 Documentation

- update team page and add acknowledgements page (#6495) by @hyf0
- restructure website and files (#6492) by @hyf0
- correct incorrect documentation about the config file (#6472) by @jsparkdev
- options: `experimental.strictExecutionOrder` (#6450) by @hyf0
- adding `why-plugin-hook-filter` in depth (#6446) by @IWANABETHATGUY

### ⚡ Performance

- rolldown: replace serde JSON string escape with simd impl (#6475) by @Brooooooklyn

### ⚙️ Miscellaneous Tasks

- docs: redirect removed path to new locations for compatibility (#6493) by @hyf0
- deps: lock file maintenance npm packages (#6490) by @renovate[bot]
- deps: update github-actions (major) (#6415) by @renovate[bot]
- deps: update github-actions (#6489) by @renovate[bot]
- rust: add comment for `DiagnosticOptions#stabilize_path` (#6447) by @hyf0
- rust: remove unused `BindingHmrOutput` (#6457) by @hyf0
- rolldown_plugin_vite_html: tweak `utils.rs` (#6460) by @shulaoda
- change node version to lts (#6435) by @iiio2
- rust/test: split hmr related structs into their own files (#6445) by @hyf0
- deps: update crate-ci/typos action to v1.38.1 (#6452) by @renovate[bot]
- rust/test: render hmr errors (#6444) by @hyf0
- examples: add `"type": "module"` in `package.json` (#6441) by @iiio2

### ❤️ New Contributors

* @Pickachu made their first contribution in [#6484](#6484)
* @elecmonkey made their first contribution in [#6476](#6476)
* @jsparkdev made their first contribution in [#6472](#6472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants