feat: adding partial `MagicString` binding by IWANABETHATGUY · Pull Request #6289 · rolldown/rolldown

IWANABETHATGUY · 2025-09-21T09:54:03Z

No description provided.

IWANABETHATGUY · 2025-09-21T09:54:19Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-09-21T10:27:44Z

Benchmarks Rust

target: main(64fb622)
pr: 09-21-feat_adding_partial_magicstring_binding(7be26be)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00    155.3±2.35ms        ? ?/sec    1.03    160.1±3.61ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00    168.6±2.52ms        ? ?/sec    1.01    171.0±3.08ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    239.5±3.94ms        ? ?/sec    1.02    243.2±4.56ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    267.6±3.67ms        ? ?/sec    1.02    271.9±3.80ms        ? ?/sec
bundle/bundle@threejs                                        1.00     86.1±3.54ms        ? ?/sec    1.03     88.3±1.36ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     96.1±1.25ms        ? ?/sec    1.03     98.9±1.18ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01   994.8±14.62ms        ? ?/sec    1.00   984.5±11.24ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01  1092.0±15.27ms        ? ?/sec    1.00  1082.8±13.05ms        ? ?/sec
scan/scan@rome_ts                                            1.00    215.2±4.62ms        ? ?/sec    1.01    217.8±3.60ms        ? ?/sec
scan/scan@threejs                                            1.00     78.0±2.01ms        ? ?/sec    1.01     78.5±1.14ms        ? ?/sec
scan/scan@threejs10x                                         1.00   840.3±18.15ms        ? ?/sec    1.00   843.8±20.90ms        ? ?/sec

netlify · 2025-09-22T04:50:58Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`7be26be`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68d131cca9224600081e172d
😎 Deploy Preview	https://deploy-preview-6289--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

crates/rolldown_binding/src/types/binding_magic_string.rs

graphite-app · 2025-09-22T11:23:31Z

Merge activity

Sep 22, 11:23 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Sep 22, 11:27 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test (ubuntu-latest) / Node Test', 'node-test (macos-latest) / Node Test', 'node-test (windows-latest) / Node Test').
Sep 22, 11:52 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Sep 22, 11:52 AM UTC: Merged by the Graphite merge queue.

@Boshen

## [1.0.0-beta.40] - 2025-09-24 ⚡ Sourcemap Performance Boost - 20%-30% faster sourcemap generation - Consistent gains across all platforms ### 🚀 Features - rolldown: oxc v0.92.0 (#6322) by @Boshen - adding partial `MagicString` binding (#6289) by @IWANABETHATGUY - rolldown_plugin_vite_html: initialize (#6292) by @shulaoda ### 🐛 Bug Fixes - rolldown_plugin_react_refresh_wrapper: avoid using cwd to allow using as a callable plugin (#6318) by @sapphi-red - rolldown_plugin_transform: resolve tsconfig from absolute path (#6311) by @shulaoda ### 🚜 Refactor - Construct MagicString with `Cow<str>` instead of `&str` (#6288) by @IWANABETHATGUY - throw error if generating oxc runtime helper fails (#6291) by @shulaoda ### 📚 Documentation - add more description about sourcemapIgnoreList (#6314) by @IWANABETHATGUY ### ⚡ Performance - reduce `sourcemap_ignore_list` js function call (#6313) by @IWANABETHATGUY - string_wizard: use memchr to find patterns in `replace` (#6312) by @IWANABETHATGUY - simplify sourcemap token processing in collapse_sourcemaps (#6310) by @IWANABETHATGUY - rolldown: some minor perf optimization (#6306) by @Brooooooklyn - rolldown: fine-tuning the tokio scheduler (#6272) by @Brooooooklyn ### ⚙️ Miscellaneous Tasks - deps: lock file maintenance rust crates (#6302) by @renovate[bot] - deps: lock file maintenance npm packages (#6301) by @renovate[bot] - use `lto: thin` in profile mode for better profiling experience. (#6320) by @IWANABETHATGUY - adjust the tokio runtime config in bench (#6305) by @Brooooooklyn - deps: update dependency rolldown-plugin-dts to v0.16.8 (#6307) by @renovate[bot]

github-actions bot assigned IWANABETHATGUY Sep 21, 2025

IWANABETHATGUY mentioned this pull request Sep 21, 2025

refactor: Construct MagicString with Cow<str> instead of &str #6288

Merged

IWANABETHATGUY force-pushed the 09-21-feat_adding_partial_magicstring_binding branch 2 times, most recently from b632856 to aaf7af1 Compare September 21, 2025 10:04

IWANABETHATGUY mentioned this pull request Sep 21, 2025

feat: background sourcemap generation for Javascript transform hooks #6293

Merged

IWANABETHATGUY force-pushed the 09-21-refactor_construct_magicstring_with_cow_str_instead_of_str_ branch from a87ddc8 to 8818e2b Compare September 21, 2025 17:25

IWANABETHATGUY force-pushed the 09-21-feat_adding_partial_magicstring_binding branch 2 times, most recently from 52a64f8 to b8a3f02 Compare September 22, 2025 03:03

IWANABETHATGUY force-pushed the 09-21-refactor_construct_magicstring_with_cow_str_instead_of_str_ branch from 8818e2b to 6450fee Compare September 22, 2025 03:03

graphite-app bot changed the base branch from 09-21-refactor_construct_magicstring_with_cow_str_instead_of_str_ to graphite-base/6289 September 22, 2025 04:35

graphite-app bot force-pushed the graphite-base/6289 branch from 6450fee to cb979c4 Compare September 22, 2025 04:49

graphite-app bot force-pushed the 09-21-feat_adding_partial_magicstring_binding branch from b8a3f02 to 13bc6ba Compare September 22, 2025 04:49

graphite-app bot changed the base branch from graphite-base/6289 to main September 22, 2025 04:49

graphite-app bot force-pushed the 09-21-feat_adding_partial_magicstring_binding branch from 13bc6ba to 3cf4ac9 Compare September 22, 2025 04:50

IWANABETHATGUY force-pushed the 09-21-feat_adding_partial_magicstring_binding branch 3 times, most recently from 0743765 to 004c0aa Compare September 22, 2025 07:03

IWANABETHATGUY marked this pull request as ready for review September 22, 2025 08:03

IWANABETHATGUY requested a review from shulaoda September 22, 2025 08:03

graphite-app bot reviewed Sep 22, 2025

View reviewed changes

crates/rolldown_binding/src/types/binding_magic_string.rs Show resolved Hide resolved

shulaoda approved these changes Sep 22, 2025

View reviewed changes

feat: adding partial MagicString binding (#6289)

7be26be

graphite-app bot force-pushed the 09-21-feat_adding_partial_magicstring_binding branch from 004c0aa to 7be26be Compare September 22, 2025 11:23

graphite-app bot merged commit 7be26be into main Sep 22, 2025
58 of 63 checks passed

graphite-app bot deleted the 09-21-feat_adding_partial_magicstring_binding branch September 22, 2025 11:52

github-actions bot mentioned this pull request Sep 24, 2025

release: v1.0.0-beta.40 #6324

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: adding partial `MagicString` binding#6289

feat: adding partial `MagicString` binding#6289
graphite-app[bot] merged 1 commit intomainfrom
09-21-feat_adding_partial_magicstring_binding

IWANABETHATGUY commented Sep 21, 2025

Uh oh!

IWANABETHATGUY commented Sep 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 21, 2025 •

edited

Loading

Uh oh!

netlify bot commented Sep 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

graphite-app bot commented Sep 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Sep 21, 2025

Uh oh!

IWANABETHATGUY commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

netlify bot commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

Uh oh!

graphite-app bot commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Sep 21, 2025 •

edited

Loading

github-actions bot commented Sep 21, 2025 •

edited

Loading

netlify bot commented Sep 22, 2025 •

edited

Loading

graphite-app bot commented Sep 22, 2025 •

edited

Loading