Skip to content

Comments

test(dev): add rebuild after HMR case#6260

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-17-test_dev_add_rebuild_after_hmr_case
Sep 18, 2025
Merged

test(dev): add rebuild after HMR case#6260
graphite-app[bot] merged 1 commit intomainfrom
09-17-test_dev_add_rebuild_after_hmr_case

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Sep 17, 2025

Added a test for the following case.

  1. HMR update
  2. Rebuild

I expect this test to pass. I expect this line to write out a new dist/main.js, but it doesn't seem to.

this.#devEngine?.ensureLatestBuild();

Copy link
Member Author

sapphi-red commented Sep 17, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red requested a review from hyf0 September 17, 2025 11:56
@sapphi-red sapphi-red force-pushed the 09-17-test_dev_support_full_reload_in_tests branch from b66b250 to f03bf87 Compare September 17, 2025 12:29
@sapphi-red sapphi-red force-pushed the 09-17-test_dev_add_rebuild_after_hmr_case branch from 5d8f689 to 53ff03d Compare September 17, 2025 12:29
@hyf0 hyf0 changed the base branch from 09-17-test_dev_support_full_reload_in_tests to graphite-base/6260 September 17, 2025 16:07
@graphite-app graphite-app bot force-pushed the 09-17-test_dev_add_rebuild_after_hmr_case branch from 53ff03d to f1f4110 Compare September 17, 2025 16:46
@graphite-app graphite-app bot changed the base branch from graphite-base/6260 to main September 17, 2025 16:46
@graphite-app graphite-app bot force-pushed the 09-17-test_dev_add_rebuild_after_hmr_case branch from f1f4110 to 0734ff1 Compare September 17, 2025 16:47
@netlify
Copy link

netlify bot commented Sep 17, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 0734ff1
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68cae607451d76000822b247

@sapphi-red sapphi-red changed the base branch from main to graphite-base/6260 September 18, 2025 02:37
@sapphi-red sapphi-red force-pushed the 09-17-test_dev_add_rebuild_after_hmr_case branch from 0734ff1 to 8213401 Compare September 18, 2025 02:37
@sapphi-red sapphi-red changed the base branch from graphite-base/6260 to 09-17-fix_dev_ensure_latest_build_output_should_work_correctly_when_eagerbuild_false_ September 18, 2025 02:37
@hyf0 hyf0 changed the base branch from 09-17-fix_dev_ensure_latest_build_output_should_work_correctly_when_eagerbuild_false_ to graphite-base/6260 September 18, 2025 05:49
@hyf0 hyf0 force-pushed the graphite-base/6260 branch from 475f002 to 0330d9b Compare September 18, 2025 06:52
@hyf0 hyf0 force-pushed the 09-17-test_dev_add_rebuild_after_hmr_case branch from 8213401 to d2953df Compare September 18, 2025 06:52
@hyf0 hyf0 changed the base branch from graphite-base/6260 to 09-17-fix_dev_ensure_latest_build_output_should_work_correctly_when_eagerbuild_false_ September 18, 2025 06:52
@sapphi-red sapphi-red marked this pull request as ready for review September 18, 2025 07:40
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 18, 2025

Merge activity

Added a test for the following case.

1. HMR update
2. Rebuild

I expect this test to pass. I expect this line to write out a new `dist/main.js`, but it doesn't seem to.
https://github.com/rolldown/rolldown/blob/b66b25028eec6c061cd324cf1c91aab9e1810d2c/packages/test-dev-server/src/dev-server.ts#L151
@graphite-app graphite-app bot force-pushed the 09-17-fix_dev_ensure_latest_build_output_should_work_correctly_when_eagerbuild_false_ branch from 0330d9b to 896e371 Compare September 18, 2025 07:45
@graphite-app graphite-app bot force-pushed the 09-17-test_dev_add_rebuild_after_hmr_case branch from d2953df to d8b76e4 Compare September 18, 2025 07:46
Base automatically changed from 09-17-fix_dev_ensure_latest_build_output_should_work_correctly_when_eagerbuild_false_ to main September 18, 2025 07:54
@graphite-app graphite-app bot merged commit d8b76e4 into main Sep 18, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 09-17-test_dev_add_rebuild_after_hmr_case branch September 18, 2025 07:56
shulaoda pushed a commit that referenced this pull request Sep 22, 2025
## [1.0.0-beta.39] - 2025-09-22

⚡ MacOS Performance Boost

- 10%-30% faster bundling
- Up to 45% in extreme cases

### 🚀 Features

- rolldown: oxc v0.90.0 + other oxc crate updates (#6274) by @Boshen
- support ignoring `/* @vite-ignore */` comment for dynamic imports (#6264) by @IWANABETHATGUY
- dev: merge mergeable queued tasks into one (#6253) by @hyf0
- dev: ignore self imports when computing update for invalidate (#6252) by @sapphi-red
- support `#__NO_SIDE_EFFECTS__` annotation for export default function declaration (#6239) by @IWANABETHATGUY
- rolldown_plugin_dynamic_import_vars: respect `@vite-ignore` comment (#6240) by @shulaoda
- rolldown_plugin_import_glob: support `exhaustive` option (#6236) by @shulaoda
- cross chunk /* @__NO_SIDE_EFFECTS__ */ support (#6207) by @IWANABETHATGUY
- rolldown_plugin_react_refresh_wrapper: make the plugin callable (#6229) by @sapphi-red

### 🐛 Bug Fixes

- handle optional chaining in scope hoisting member expression rewriting (#6278) by @shulaoda
- release: Fix semver commit release format to use plus instead of dash (#6273) by @Copilot
- dev: `ensure_latest_build_output` should work correctly when `eagerBuild: false` (#6262) by @hyf0
- browser: does not work in stackblitz (#6257) by @shulaoda
- only inline constants that are not reassigned (#6247) by @IWANABETHATGUY
- handle lexical declarations in root scope (#6230) by @IWANABETHATGUY

### 🚜 Refactor

- move oxc runtime helper generation from `build.rs` to task generator (#6284) by @shulaoda
- remove unused `SpanExt` (#6266) by @IWANABETHATGUY
- remove `@rolldown-ignore` ignore comment support (#6265) by @IWANABETHATGUY
- enhance CommonJsAstType to track property names (#6250) by @IWANABETHATGUY
- simplify usage for `Address::from` (#6245) by @IWANABETHATGUY
- remove `stmt_info_idx` in StmtInfo (#6244) by @IWANABETHATGUY
- extract `CrossModuleOptimizationRunnerContext` in cross_module_optimization (#6243) by @IWANABETHATGUY
- dev: task-queue based deisgn (#6233) by @hyf0
- extract immutable context from AstScanner (#6238) by @IWANABETHATGUY
- dev: rename `WatcherEventService` to `BuildDriverService` (#6232) by @hyf0
- move FlatOptions to rolldown_common (#6235) by @IWANABETHATGUY
- extract mutable state from ScopeHoistingFinalizerContext (#6234) by @IWANABETHATGUY
- wait `this.load` using futures instead of callbacks (#6222) by @sapphi-red
- rolldown_plugin_transform: remove unused `runtime_resolve_base` option (#6226) by @sapphi-red

### 📚 Documentation

- add "edit this page on GitHub" button (#6241) by @siaeyy

### ⚡ Performance

- rolldown: minor performance optimization (#6271) by @Brooooooklyn
- rolldown: take advantage of tokio blocking threads (#6270) by @Brooooooklyn

### 🧪 Testing

- dev: add rebuild after HMR case (#6260) by @sapphi-red
- dev: support full reload in tests (#6259) by @sapphi-red
- dev: extract waitFor from waitForPathExists (#6261) by @sapphi-red
- add class like cases for empty function optimizations (#6248) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update github-actions (#6298) by @renovate[bot]
- deps: update dependency dprint/dprint-plugin-typescript to v0.95.11 (#6296) by @renovate[bot]
- deps: update dependency dprint/dprint-plugin-markdown to v0.19.0 (#6295) by @renovate[bot]
- deps: update dependency g-plane/pretty_yaml to v0.5.1 (#6294) by @renovate[bot]
- use a forked version of openharmony-rs/setup-ohos-sdk (#6290) by @Boshen
- deps: update dependency tsdown to v0.15.4 (#6286) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.7 (#6285) by @renovate[bot]
- rust: continue to make `cargo publish --workspace` work (#6281) by @Boshen
- deps: update dependency tsdown to v0.15.3 (#6280) by @renovate[bot]
- rust: fixes for `cargo publish --dry-run --workspace` (#6279) by @Boshen
- deps: update dependency rust to v1.90.0 (#6277) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.6 (#6276) by @renovate[bot]
- adding tracing for all sub stage in LinkStage:link (#6268) by @IWANABETHATGUY
- deps: update oxc-project/setup-node action to v1.0.4 (#6258) by @renovate[bot]
- deps: update github-actions (#6249) by @renovate[bot]
- deps: update dependency tsdown to v0.15.2 (#6242) by @renovate[bot]
- dev: output error when the initial bundle failed (#6228) by @sapphi-red

### ❤️ New Contributors

* @siaeyy made their first contribution in [#6241](#6241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants