Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Sep 17, 2025

When there's a module graph like:

graph TD
  main["main (loaded)"] -. dynamic .-> parent1["parent1 (loaded)"]
  main -. dynamic .-> parent2
  parent1 --> child["child (loaded)"]
  parent2 --> child
  parent2 --> parent2-child
Loading

calling invalidate at child.js causes a broken behavior.
When invalidate is called, both parent1 and parent2 are re-executed, but because parent2 was never executed, the value of parent2-child is not stored in the runtime and causes loadExports to return {}.

console.warn(`Module ${id} not found`);
return {};

Ideally, we should only re-execute parent1. But we can also fix this by correctly executing parent2.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Sep 17, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 2e2abd3
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68ca90dcaa2a35000805290c

@graphite-app graphite-app bot closed this in 5c94508 Sep 30, 2025
@sapphi-red sapphi-red deleted the 09-17-test_dev_invalidate_call_with_multiple_parent_when_some_parents_are_not_executed branch October 6, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants