feat(dev): ignore self imports when computing update for invalidate by sapphi-red · Pull Request #6252 · rolldown/rolldown

sapphi-red · 2025-09-17T09:56:14Z

The self imports should be ignored when computing update for invalidate call because we already know that the module cannot self accept.

The react refresh wrapper plugin injects a self import.

rolldown/crates/rolldown_plugin_react_refresh_wrapper/src/lib.rs

Line 60 in 9883b9b

import * as __vite_react_currentExports from {escaped_id};

sapphi-red · 2025-09-17T09:56:38Z

feat(dev): ignore self imports when computing update for invalidate #6252 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-09-17T09:57:26Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`c844839`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68ca8ab690ba23000850a635

github-actions · 2025-09-17T10:12:07Z

Benchmarks Rust

target: main(9883b9b)
pr: 09-17-feat_dev_ignore_self_imports_when_computing_update_for_invalidate(c844839)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     83.3±2.25ms        ? ?/sec    1.02     84.9±2.66ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     92.7±2.10ms        ? ?/sec    1.01     93.4±2.28ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    121.3±2.61ms        ? ?/sec    1.00    120.7±1.90ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    142.7±1.78ms        ? ?/sec    1.00    142.6±2.57ms        ? ?/sec
bundle/bundle@threejs                                        1.00     45.1±1.44ms        ? ?/sec    1.01     45.6±2.37ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     54.0±0.80ms        ? ?/sec    1.01     54.3±0.91ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    477.1±5.89ms        ? ?/sec    1.01   481.6±13.96ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    554.7±4.37ms        ? ?/sec    1.00    553.1±6.82ms        ? ?/sec
scan/scan@rome_ts                                            1.04     98.0±1.79ms        ? ?/sec    1.00     94.7±1.49ms        ? ?/sec
scan/scan@threejs                                            1.02     34.5±2.00ms        ? ?/sec    1.00     33.8±2.06ms        ? ?/sec
scan/scan@threejs10x                                         1.02    359.4±5.98ms        ? ?/sec    1.00    352.8±3.50ms        ? ?/sec

hyf0

Without this, it results to full reload right?

hyf0 · 2025-09-17T10:17:04Z

Merge activity

Sep 17, 10:17 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 17, 10:17 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Sep 17, 10:26 AM UTC: Merged by the Graphite merge queue.

…6252) The self imports should be ignored when computing update for invalidate call because we already know that the module cannot self accept. The react refresh wrapper plugin injects a self import. https://github.com/rolldown/rolldown/blob/9883b9bf1e1b8c74e3c9f438af9fa7109e29b6ea/crates/rolldown_plugin_react_refresh_wrapper/src/lib.rs#L60

sapphi-red · 2025-09-17T10:32:45Z

Without this, it results to full reload right?

Yes, it results to full reload.

@Boshen

## [1.0.0-beta.39] - 2025-09-22 ⚡ MacOS Performance Boost - 10%-30% faster bundling - Up to 45% in extreme cases ### 🚀 Features - rolldown: oxc v0.90.0 + other oxc crate updates (#6274) by @Boshen - support ignoring `/* @vite-ignore */` comment for dynamic imports (#6264) by @IWANABETHATGUY - dev: merge mergeable queued tasks into one (#6253) by @hyf0 - dev: ignore self imports when computing update for invalidate (#6252) by @sapphi-red - support `#__NO_SIDE_EFFECTS__` annotation for export default function declaration (#6239) by @IWANABETHATGUY - rolldown_plugin_dynamic_import_vars: respect `@vite-ignore` comment (#6240) by @shulaoda - rolldown_plugin_import_glob: support `exhaustive` option (#6236) by @shulaoda - cross chunk /* @__NO_SIDE_EFFECTS__ */ support (#6207) by @IWANABETHATGUY - rolldown_plugin_react_refresh_wrapper: make the plugin callable (#6229) by @sapphi-red ### 🐛 Bug Fixes - handle optional chaining in scope hoisting member expression rewriting (#6278) by @shulaoda - release: Fix semver commit release format to use plus instead of dash (#6273) by @Copilot - dev: `ensure_latest_build_output` should work correctly when `eagerBuild: false` (#6262) by @hyf0 - browser: does not work in stackblitz (#6257) by @shulaoda - only inline constants that are not reassigned (#6247) by @IWANABETHATGUY - handle lexical declarations in root scope (#6230) by @IWANABETHATGUY ### 🚜 Refactor - move oxc runtime helper generation from `build.rs` to task generator (#6284) by @shulaoda - remove unused `SpanExt` (#6266) by @IWANABETHATGUY - remove `@rolldown-ignore` ignore comment support (#6265) by @IWANABETHATGUY - enhance CommonJsAstType to track property names (#6250) by @IWANABETHATGUY - simplify usage for `Address::from` (#6245) by @IWANABETHATGUY - remove `stmt_info_idx` in StmtInfo (#6244) by @IWANABETHATGUY - extract `CrossModuleOptimizationRunnerContext` in cross_module_optimization (#6243) by @IWANABETHATGUY - dev: task-queue based deisgn (#6233) by @hyf0 - extract immutable context from AstScanner (#6238) by @IWANABETHATGUY - dev: rename `WatcherEventService` to `BuildDriverService` (#6232) by @hyf0 - move FlatOptions to rolldown_common (#6235) by @IWANABETHATGUY - extract mutable state from ScopeHoistingFinalizerContext (#6234) by @IWANABETHATGUY - wait `this.load` using futures instead of callbacks (#6222) by @sapphi-red - rolldown_plugin_transform: remove unused `runtime_resolve_base` option (#6226) by @sapphi-red ### 📚 Documentation - add "edit this page on GitHub" button (#6241) by @siaeyy ### ⚡ Performance - rolldown: minor performance optimization (#6271) by @Brooooooklyn - rolldown: take advantage of tokio blocking threads (#6270) by @Brooooooklyn ### 🧪 Testing - dev: add rebuild after HMR case (#6260) by @sapphi-red - dev: support full reload in tests (#6259) by @sapphi-red - dev: extract waitFor from waitForPathExists (#6261) by @sapphi-red - add class like cases for empty function optimizations (#6248) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update github-actions (#6298) by @renovate[bot] - deps: update dependency dprint/dprint-plugin-typescript to v0.95.11 (#6296) by @renovate[bot] - deps: update dependency dprint/dprint-plugin-markdown to v0.19.0 (#6295) by @renovate[bot] - deps: update dependency g-plane/pretty_yaml to v0.5.1 (#6294) by @renovate[bot] - use a forked version of openharmony-rs/setup-ohos-sdk (#6290) by @Boshen - deps: update dependency tsdown to v0.15.4 (#6286) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.16.7 (#6285) by @renovate[bot] - rust: continue to make `cargo publish --workspace` work (#6281) by @Boshen - deps: update dependency tsdown to v0.15.3 (#6280) by @renovate[bot] - rust: fixes for `cargo publish --dry-run --workspace` (#6279) by @Boshen - deps: update dependency rust to v1.90.0 (#6277) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.16.6 (#6276) by @renovate[bot] - adding tracing for all sub stage in LinkStage:link (#6268) by @IWANABETHATGUY - deps: update oxc-project/setup-node action to v1.0.4 (#6258) by @renovate[bot] - deps: update github-actions (#6249) by @renovate[bot] - deps: update dependency tsdown to v0.15.2 (#6242) by @renovate[bot] - dev: output error when the initial bundle failed (#6228) by @sapphi-red ### ❤️ New Contributors * @siaeyy made their first contribution in [#6241](#6241)

sapphi-red requested a review from hyf0 September 17, 2025 09:58

sapphi-red assigned hyf0 Sep 17, 2025

sapphi-red marked this pull request as ready for review September 17, 2025 10:01

hyf0 approved these changes Sep 17, 2025

View reviewed changes

hyf0 added the graphite: merge label Sep 17, 2025

graphite-app bot force-pushed the 09-17-feat_dev_ignore_self_imports_when_computing_update_for_invalidate branch from 57a19f4 to c844839 Compare September 17, 2025 10:17

graphite-app bot merged commit c844839 into main Sep 17, 2025
27 checks passed

graphite-app bot deleted the 09-17-feat_dev_ignore_self_imports_when_computing_update_for_invalidate branch September 17, 2025 10:26

graphite-app bot removed the graphite: merge label Sep 17, 2025

github-actions bot mentioned this pull request Sep 22, 2025

release: v1.0.0-beta.39 #6304

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat(dev): ignore self imports when computing update for invalidate#6252

feat(dev): ignore self imports when computing update for invalidate#6252
graphite-app[bot] merged 1 commit intomainfrom
09-17-feat_dev_ignore_self_imports_when_computing_update_for_invalidate

sapphi-red commented Sep 17, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Sep 17, 2025

Uh oh!

netlify bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

hyf0 left a comment

Uh oh!

hyf0 commented Sep 17, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

sapphi-red commented Sep 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

sapphi-red commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Sep 17, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

github-actions bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

hyf0 left a comment

Choose a reason for hiding this comment

Uh oh!

hyf0 commented Sep 17, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

sapphi-red commented Sep 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sapphi-red commented Sep 17, 2025 •

edited

Loading

netlify bot commented Sep 17, 2025 •

edited

Loading

github-actions bot commented Sep 17, 2025 •

edited

Loading

hyf0 commented Sep 17, 2025 •

edited by graphite-app bot

Loading