Skip to content

Comments

feat: cross chunk /* @__NO_SIDE_EFFECTS__ */ support#6207

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-14-feat_no_side_effects_annotation
Sep 16, 2025
Merged

feat: cross chunk /* @__NO_SIDE_EFFECTS__ */ support#6207
graphite-app[bot] merged 1 commit intomainfrom
09-14-feat_no_side_effects_annotation

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Sep 14, 2025

closed #3234

Copy link
Member Author

IWANABETHATGUY commented Sep 14, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app graphite-app bot changed the base branch from 09-14-perf_pre_calculate_side_effects_free_function_symbol_ref_ to graphite-base/6207 September 14, 2025 08:32
@IWANABETHATGUY IWANABETHATGUY changed the title feat: no side effects annotation feat: cross chunk /* @__NO_SIDE_EFFECTS__ */ support Sep 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2025

Benchmarks Rust

  • target: main(2ff7122)
  • pr: 09-14-feat_no_side_effects_annotation(b07caa3)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     78.6±2.17ms        ? ?/sec    1.02     80.2±2.17ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     89.3±3.98ms        ? ?/sec    1.00     89.5±1.39ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    117.4±2.84ms        ? ?/sec    1.01    118.5±1.67ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    138.1±1.73ms        ? ?/sec    1.01    139.4±3.55ms        ? ?/sec
bundle/bundle@threejs                                        1.00     43.5±1.18ms        ? ?/sec    1.02     44.3±0.72ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     52.8±0.66ms        ? ?/sec    1.00     52.9±0.62ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    461.8±7.93ms        ? ?/sec    1.00    462.7±4.86ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02   546.4±42.37ms        ? ?/sec    1.00    538.1±5.21ms        ? ?/sec
scan/scan@rome_ts                                            1.00     95.3±3.16ms        ? ?/sec    1.00     95.0±3.22ms        ? ?/sec
scan/scan@threejs                                            1.05     34.4±1.90ms        ? ?/sec    1.00     32.8±0.41ms        ? ?/sec
scan/scan@threejs10x                                         1.00    349.3±4.44ms        ? ?/sec    1.00    349.1±5.07ms        ? ?/sec

@graphite-app graphite-app bot force-pushed the 09-14-feat_no_side_effects_annotation branch from a4e3c17 to 0c7782b Compare September 14, 2025 08:42
@graphite-app graphite-app bot changed the base branch from graphite-base/6207 to main September 14, 2025 08:43
@graphite-app graphite-app bot force-pushed the 09-14-feat_no_side_effects_annotation branch from 0c7782b to 858b9fd Compare September 14, 2025 08:43
@netlify
Copy link

netlify bot commented Sep 14, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b07caa3
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68c9760e2360d900088623a8

@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-14-feat_no_side_effects_annotation branch from 858b9fd to 5487dd2 Compare September 14, 2025 10:11
@IWANABETHATGUY IWANABETHATGUY changed the base branch from main to graphite-base/6207 September 14, 2025 14:04
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-14-feat_no_side_effects_annotation branch from 5487dd2 to 8e7581b Compare September 14, 2025 14:04
@IWANABETHATGUY IWANABETHATGUY changed the base branch from graphite-base/6207 to share-flatoptions September 14, 2025 14:04
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-14-feat_no_side_effects_annotation branch from 8e7581b to 4f7638f Compare September 14, 2025 17:44
@graphite-app graphite-app bot changed the base branch from share-flatoptions to graphite-base/6207 September 15, 2025 02:06
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-14-feat_no_side_effects_annotation branch from 4f7638f to 4955ac6 Compare September 16, 2025 03:59
@IWANABETHATGUY IWANABETHATGUY changed the base branch from graphite-base/6207 to main September 16, 2025 04:00
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-14-feat_no_side_effects_annotation branch 5 times, most recently from f9a0f5c to ab5555d Compare September 16, 2025 13:55
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 16, 2025 14:08
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-14-feat_no_side_effects_annotation branch from a0d2257 to 223f419 Compare September 16, 2025 14:27
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 16, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 09-14-feat_no_side_effects_annotation branch from 223f419 to b07caa3 Compare September 16, 2025 14:37
@graphite-app graphite-app bot merged commit b07caa3 into main Sep 16, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 09-14-feat_no_side_effects_annotation branch September 16, 2025 14:46
shulaoda pushed a commit that referenced this pull request Sep 22, 2025
## [1.0.0-beta.39] - 2025-09-22

⚡ MacOS Performance Boost

- 10%-30% faster bundling
- Up to 45% in extreme cases

### 🚀 Features

- rolldown: oxc v0.90.0 + other oxc crate updates (#6274) by @Boshen
- support ignoring `/* @vite-ignore */` comment for dynamic imports (#6264) by @IWANABETHATGUY
- dev: merge mergeable queued tasks into one (#6253) by @hyf0
- dev: ignore self imports when computing update for invalidate (#6252) by @sapphi-red
- support `#__NO_SIDE_EFFECTS__` annotation for export default function declaration (#6239) by @IWANABETHATGUY
- rolldown_plugin_dynamic_import_vars: respect `@vite-ignore` comment (#6240) by @shulaoda
- rolldown_plugin_import_glob: support `exhaustive` option (#6236) by @shulaoda
- cross chunk /* @__NO_SIDE_EFFECTS__ */ support (#6207) by @IWANABETHATGUY
- rolldown_plugin_react_refresh_wrapper: make the plugin callable (#6229) by @sapphi-red

### 🐛 Bug Fixes

- handle optional chaining in scope hoisting member expression rewriting (#6278) by @shulaoda
- release: Fix semver commit release format to use plus instead of dash (#6273) by @Copilot
- dev: `ensure_latest_build_output` should work correctly when `eagerBuild: false` (#6262) by @hyf0
- browser: does not work in stackblitz (#6257) by @shulaoda
- only inline constants that are not reassigned (#6247) by @IWANABETHATGUY
- handle lexical declarations in root scope (#6230) by @IWANABETHATGUY

### 🚜 Refactor

- move oxc runtime helper generation from `build.rs` to task generator (#6284) by @shulaoda
- remove unused `SpanExt` (#6266) by @IWANABETHATGUY
- remove `@rolldown-ignore` ignore comment support (#6265) by @IWANABETHATGUY
- enhance CommonJsAstType to track property names (#6250) by @IWANABETHATGUY
- simplify usage for `Address::from` (#6245) by @IWANABETHATGUY
- remove `stmt_info_idx` in StmtInfo (#6244) by @IWANABETHATGUY
- extract `CrossModuleOptimizationRunnerContext` in cross_module_optimization (#6243) by @IWANABETHATGUY
- dev: task-queue based deisgn (#6233) by @hyf0
- extract immutable context from AstScanner (#6238) by @IWANABETHATGUY
- dev: rename `WatcherEventService` to `BuildDriverService` (#6232) by @hyf0
- move FlatOptions to rolldown_common (#6235) by @IWANABETHATGUY
- extract mutable state from ScopeHoistingFinalizerContext (#6234) by @IWANABETHATGUY
- wait `this.load` using futures instead of callbacks (#6222) by @sapphi-red
- rolldown_plugin_transform: remove unused `runtime_resolve_base` option (#6226) by @sapphi-red

### 📚 Documentation

- add "edit this page on GitHub" button (#6241) by @siaeyy

### ⚡ Performance

- rolldown: minor performance optimization (#6271) by @Brooooooklyn
- rolldown: take advantage of tokio blocking threads (#6270) by @Brooooooklyn

### 🧪 Testing

- dev: add rebuild after HMR case (#6260) by @sapphi-red
- dev: support full reload in tests (#6259) by @sapphi-red
- dev: extract waitFor from waitForPathExists (#6261) by @sapphi-red
- add class like cases for empty function optimizations (#6248) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update github-actions (#6298) by @renovate[bot]
- deps: update dependency dprint/dprint-plugin-typescript to v0.95.11 (#6296) by @renovate[bot]
- deps: update dependency dprint/dprint-plugin-markdown to v0.19.0 (#6295) by @renovate[bot]
- deps: update dependency g-plane/pretty_yaml to v0.5.1 (#6294) by @renovate[bot]
- use a forked version of openharmony-rs/setup-ohos-sdk (#6290) by @Boshen
- deps: update dependency tsdown to v0.15.4 (#6286) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.7 (#6285) by @renovate[bot]
- rust: continue to make `cargo publish --workspace` work (#6281) by @Boshen
- deps: update dependency tsdown to v0.15.3 (#6280) by @renovate[bot]
- rust: fixes for `cargo publish --dry-run --workspace` (#6279) by @Boshen
- deps: update dependency rust to v1.90.0 (#6277) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.6 (#6276) by @renovate[bot]
- adding tracing for all sub stage in LinkStage:link (#6268) by @IWANABETHATGUY
- deps: update oxc-project/setup-node action to v1.0.4 (#6258) by @renovate[bot]
- deps: update github-actions (#6249) by @renovate[bot]
- deps: update dependency tsdown to v0.15.2 (#6242) by @renovate[bot]
- dev: output error when the initial bundle failed (#6228) by @sapphi-red

### ❤️ New Contributors

* @siaeyy made their first contribution in [#6241](#6241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: cross chunk /* @__NO_SIDE_EFFECTS__ */ support

2 participants