Skip to content

Comments

feat(dev): skip writing to file#6148

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-11-feat_dev_skip_writing_to_file
Sep 11, 2025
Merged

feat(dev): skip writing to file#6148
graphite-app[bot] merged 1 commit intomainfrom
09-11-feat_dev_skip_writing_to_file

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Sep 11, 2025

Implemented the skipWrite option.

Copy link
Member Author

sapphi-red commented Sep 11, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Sep 11, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 8ddefd2
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68c2b041787e05000851e36d

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

Benchmarks Rust

  • target: main(e7956b1)
  • pr: 09-11-feat_dev_skip_writing_to_file(8ddefd2)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.04     82.9±2.38ms        ? ?/sec    1.00     79.9±2.72ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     93.6±2.13ms        ? ?/sec    1.00     91.2±2.49ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    121.7±3.57ms        ? ?/sec    1.00    121.3±2.27ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    143.1±3.28ms        ? ?/sec    1.00    142.6±2.62ms        ? ?/sec
bundle/bundle@threejs                                        1.02     46.3±2.52ms        ? ?/sec    1.00     45.6±1.03ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     55.5±1.29ms        ? ?/sec    1.00     54.5±1.04ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    477.5±5.30ms        ? ?/sec    1.00    473.0±4.55ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    558.4±5.04ms        ? ?/sec    1.00    551.5±4.18ms        ? ?/sec
scan/scan@rome_ts                                            1.00     95.2±2.09ms        ? ?/sec    1.04     98.9±2.14ms        ? ?/sec
scan/scan@threejs                                            1.00     34.2±2.04ms        ? ?/sec    1.03     35.1±2.21ms        ? ?/sec
scan/scan@threejs10x                                         1.00    353.8±4.51ms        ? ?/sec    1.02    360.1±4.53ms        ? ?/sec

@sapphi-red sapphi-red changed the base branch from main to graphite-base/6148 September 11, 2025 08:18
@sapphi-red sapphi-red force-pushed the 09-11-feat_dev_skip_writing_to_file branch from 038f67c to 30b769d Compare September 11, 2025 08:19
@sapphi-red sapphi-red changed the base branch from graphite-base/6148 to 09-11-feat_dev_add_skip_write_option September 11, 2025 08:19
@sapphi-red sapphi-red requested a review from hyf0 September 11, 2025 08:31
@sapphi-red sapphi-red marked this pull request as ready for review September 11, 2025 08:32
@sapphi-red sapphi-red force-pushed the 09-11-feat_dev_skip_writing_to_file branch from 30b769d to ab3b8c8 Compare September 11, 2025 10:33
@sapphi-red sapphi-red force-pushed the 09-11-feat_dev_add_skip_write_option branch from 977a023 to 55fc3a6 Compare September 11, 2025 10:33
Copy link
Member

hyf0 commented Sep 11, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from 09-11-feat_dev_add_skip_write_option to graphite-base/6148 September 11, 2025 10:52
@graphite-app graphite-app bot changed the base branch from graphite-base/6148 to main September 11, 2025 11:18
Implemented the `skipWrite` option.
@graphite-app graphite-app bot force-pushed the 09-11-feat_dev_skip_writing_to_file branch from ab3b8c8 to 8ddefd2 Compare September 11, 2025 11:19
@graphite-app graphite-app bot merged commit 8ddefd2 into main Sep 11, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 09-11-feat_dev_skip_writing_to_file branch September 11, 2025 11:30
shulaoda pushed a commit that referenced this pull request Sep 15, 2025
## [1.0.0-beta.38] - 2025-09-15

📦 OXC Runtime Helpers Now Embedded

- Instant loading: Memory access instead of file I/O
- 91% smaller: From 229 KB external package to ~25 KB in binary
- Universal support: Works seamlessly in all environments including browsers
- Zero dependencies: Helpers embedded directly, no `@oxc-project/runtime` needed

⚡ Windows Performance Boost

- ~10% faster bundling on Windows
- Powered by `oxc-resolver` optimizations

Both improvements require zero configuration - just update to the latest version and enjoy! 🎉

> [!warning] 
> ### 💥 BREAKING CHANGES
> - rolldown_plugin_oxc_runtime: embed helpers to support browser environment (#6177) by @shulaoda

### 🚀 Features

- rolldown: oxc v0.89.0 (#6220) by @Boshen
- rolldown_plugin_esm_external_require: add duplicate external detection (#6202) by @shulaoda
- cross module noop function optimization (#6199) by @IWANABETHATGUY
- support to specify `scan_mode` in `bundler.scan` (#6204) by @IWANABETHATGUY
- warn when transform options override tsconfig compiler options (#6197) by @shulaoda
- support `false` in `resolve.alias` to ignore resolution (#6203) by @shulaoda
- cli: remove `getJsonSchema` (#6186) by @shulaoda
- cli: add Node.js version warning for unsupported versions (#6150) by @Copilot
- rolldown_plugin_oxc_runtime: include version in virtual module paths (#6179) by @shulaoda
- add native react-refresh-wrapper plugin (#6144) by @sapphi-red
- rolldown_plugin_utils: add `to_string_literal` (#6178) by @sapphi-red
- improve error messages for builtin plugins (#6175) by @shulaoda
- indent module content in IIFE format (#6174) by @IWANABETHATGUY
- rolldown_error: improve N-API error handling logic (#6171) by @shulaoda
- rolldown_error: improve `ByteLocator#byte_offset` (#6169) by @shulaoda
- dev: skip writing to file (#6148) by @sapphi-red
- dev: add `skip_write` option (#6151) by @sapphi-red
- dev: ignore file metadata changes (#6138) by @sapphi-red
- dev: add PathsMut for debounced PollWatcher (#6139) by @sapphi-red
- dev: use PathsMut for debounced RecommendedWatcher (#6137) by @sapphi-red
- improve bundler initialization error handling (#6132) by @shulaoda

### 🐛 Bug Fixes

- rolldown_plugin_vite_resolve: correctly handle Windows drive paths with leading slash (#6209) by @shulaoda
- allow `jsx.pragmaFrag` instead of `jsx.pragmaFlag` (#6200) by @sapphi-red
- improve import-glob plugin error handling without panic (#6106) by @hikomoon
- Panic with "jsx": "preserve" when rewrite a `memberExpression` (#6192) by @IWANABETHATGUY
- rolldown_error: use `byte_slice` instead of `slice` for correct span handling (#6185) by @shulaoda
- generate valid identifier for export names with `minifyInternalExports` (#6166) by @sapphi-red
- useless __export helper usage (#6160) by @IWANABETHATGUY
- incremental watch modify entry module (#6156) by @IWANABETHATGUY
- register trace subscriber (#6145) by @sapphi-red
- json imports error with `eval` or `arguments` in *strict mode* (#6140) by @IWANABETHATGUY
- `process` is not defined in repl (#6147) by @IWANABETHATGUY

### 💼 Other

- rolldown: support to build `rolldown` with `.wasm` binding (#6153) by @hyf0
- rolldown: refactor `build.ts` to prepare to support build `rolldown` package with wasi binding (#6152) by @hyf0

### 🚜 Refactor

- share `FlatOptions` in whole build session (#6211) by @IWANABETHATGUY
- remove unnecessary `comments` in ScopeHoistingFinalizerContext (#6205) by @IWANABETHATGUY
- move external string/regex matching from JS to Rust (#6201) by @shulaoda
- rename `cross_module_inline_const` to `cross_module_optimization` (#6193) by @IWANABETHATGUY
- rename `class` and `function` visitor to `class_decl`, `function_decl` (#6176) by @IWANABETHATGUY
- rolldown_error: tweak code (#6168) by @shulaoda
- improve `BuildDiagnostic` (#6165) by @shulaoda
- improve `RolldownBuild` (#6136) by @shulaoda
- rolldown_error: remove unused `EventKind::IoError` (#6134) by @shulaoda
- rename CustomPathsMut to NotifyPathsMutAdapter and move to utils (#6135) by @hyf0

### 📚 Documentation

- contrib-guide: add profiling instructions for macOS (#6183) by @sapphi-red
- contrib-guide: update just commands (#6181) by @sapphi-red

### ⚡ Performance

- pre calculate `side_effects_free_function_symbol_ref` (#6206) by @IWANABETHATGUY
- parallel clone ast (#6167) by @IWANABETHATGUY
- reserve capacity for rendered modules in `instantiate_chunk` (#6159) by @sapphi-red

### 🧪 Testing

- hmr: ensure each test isolated to be able to be retryed (#6142) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance npm packages (#6219) by @renovate[bot]
- deps: lock file maintenance rust crates (#6217) by @renovate[bot]
- deps: update github-actions (#6213) by @renovate[bot]
- deps: lock file maintenance npm packages (#6215) by @renovate[bot]
- deps: update github-actions (major) (#6214) by @renovate[bot]
- tweak wordings (#6208) by @iiio2
- fix unused import warnings (#6196) by @shulaoda
- correct deprecated JSDoc reference for jsx option (#6195) by @shulaoda
- add `if: always()` to wasi-test (#6190) by @sapphi-red
- skip `@rolldown/browser` build if no node related changes detected (#6189) by @sapphi-red
- extract wasi build to reusable workflow (#6188) by @sapphi-red
- deps: update dependency tsdown to v0.15.1 (#6184) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.5 (#6182) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.4 (#6180) by @renovate[bot]
- dev: implement Debug trait for DevOptions (#6173) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.16.3 (#6172) by @renovate[bot]
- update @napi-rs/cli and js binding (#6157) by @Brooooooklyn
- ci: ensure `@rolldown/browser` build without errors (#6155) by @hyf0
- ci: ensure running wasi tests correctly (#6154) by @hyf0
- add more tracing instrumentation (#6149) by @sapphi-red
- extend timeout for rollup test (#6143) by @IWANABETHATGUY
- rolldown_error: remove unnecessary `type_aliases.rs` (#6133) by @shulaoda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants