feat: partial align with const inline strategy with oxc in smart mode by IWANABETHATGUY · Pull Request #6126 · rolldown/rolldown

IWANABETHATGUY · 2025-09-10T10:53:35Z

ref: https://github.com/oxc-project/oxc/blob/a286dd4a5b4fd9a1eb8d81dc650f305665babbf4/crates/oxc_minifier/src/peephole/inline.rs#L37-L43

It a little complex to record each symbol actual referenced count, I don’t find enough value to add that feature so skipped.

IWANABETHATGUY · 2025-09-10T10:53:52Z

feat: partial align with const inline strategy with oxc in smart mode #6126 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-09-10T10:54:28Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`524f25b`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68c1787c9b711c0008aef81f

crates/rolldown_common/src/types/constant_value.rs

github-actions · 2025-09-10T11:16:59Z

Benchmarks Rust

target: main(2005904)
pr: 09-10-feat_partial_align_with_const_inline_strategy_with_oxc_in_smart_mode(524f25b)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     89.5±2.82ms        ? ?/sec    1.00     88.4±2.86ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03    102.1±2.76ms        ? ?/sec    1.00     98.7±2.33ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    129.2±2.82ms        ? ?/sec    1.00    128.0±2.18ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    150.3±4.24ms        ? ?/sec    1.00    149.6±2.79ms        ? ?/sec
bundle/bundle@threejs                                        1.01     48.6±3.22ms        ? ?/sec    1.00     48.3±1.47ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     57.1±0.98ms        ? ?/sec    1.01     57.6±0.83ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    500.7±5.36ms        ? ?/sec    1.00    498.3±6.82ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    582.6±6.01ms        ? ?/sec    1.00    581.6±7.16ms        ? ?/sec
scan/scan@rome_ts                                            1.00    104.2±2.72ms        ? ?/sec    1.01    105.0±2.22ms        ? ?/sec
scan/scan@threejs                                            1.02     37.5±2.09ms        ? ?/sec    1.00     36.9±1.68ms        ? ?/sec
scan/scan@threejs10x                                         1.00    372.5±5.20ms        ? ?/sec    1.00    373.7±6.12ms        ? ?/sec

graphite-app · 2025-09-10T11:21:24Z

Merge activity

Sep 10, 11:21 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Sep 10, 11:34 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'cargo-test (ubuntu-latest) / Cargo Test', 'cargo-test (macos-latest) / Cargo Test', 'cargo-test (windows-latest) / Cargo Test').
Sep 10, 1:08 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Sep 10, 1:17 PM UTC: Merged by the Graphite merge queue.

…#6126) ref: https://github.com/oxc-project/oxc/blob/a286dd4a5b4fd9a1eb8d81dc650f305665babbf4/crates/oxc_minifier/src/peephole/inline.rs#L37-L43 It a little complex to record each symbol actual referenced count, I don’t find enough value to add that feature so skipped.

crates/rolldown/src/module_finalizers/mod.rs

…#6126) ref: https://github.com/oxc-project/oxc/blob/a286dd4a5b4fd9a1eb8d81dc650f305665babbf4/crates/oxc_minifier/src/peephole/inline.rs#L37-L43 It a little complex to record each symbol actual referenced count, I don’t find enough value to add that feature so skipped.

@IWANABETHATGUY

## [1.0.0-beta.37] - 2025-09-10 ### 🚀 Features - partial align with const inline strategy with oxc in smart mode (#6126) by @IWANABETHATGUY - dev: use PathsMut for non-debounced RecommendedWatcher (#6120) by @sapphi-red - dev: return whether the build is already scheduled from `scheduleBuildIfStale` method (#6116) by @sapphi-red - handle errors from `BundlerBuilder#build` (#6104) by @shulaoda - add debounceTickRate option for debounced watchers (#6113) by @hyf0 - support full build in `incrementalBuild` mode (#6098) by @IWANABETHATGUY - add compare_contents_for_polling option to dev watcher (#6108) by @hyf0 - dev: add `scheduleBuildIfStale` method to DevEngine (#6087) by @sapphi-red - dev: return changed files in onHmrUpdates callback (#6086) by @sapphi-red - support function config with custom CLI arguments (#6076) by @IWANABETHATGUY - improve `MISSING_EXPORT` warning to suggest `type` modifier (#6085) by @sapphi-red - crates/rolldown_watcher: introduce `PathsMut` to batch watch/unwatch behaviors (#6075) by @hyf0 - enable `treeshake.commonjs` by default (#6072) by @IWANABETHATGUY - dev: add debounce control and PollWatcher support to DevWatchOptions (#6070) by @hyf0 ### 🐛 Bug Fixes - use kqueue for file watch on mac (#6124) by @sapphi-red - use patched notify for better file change event debouncing (#6125) by @sapphi-red - support passing all js primitive value for `alias` plugin (#6123) by @IWANABETHATGUY - track spans in member expression properties for accurate sourcemaps (#6100) by @IWANABETHATGUY - correctly handle inlined CommonJS exports in member expressions (#6090) by @IWANABETHATGUY - dev: ensure patch file names to be unique (#6096) by @sapphi-red - dev: normalize slash on Windows before comparing paths (#6095) by @sapphi-red - dev/watch: debounce duration should default to 10 (#6078) by @hyf0 ### 🚜 Refactor - simplify `__export` runtime helper to create target object internally (#6114) by @IWANABETHATGUY - simplify module_namespace construction second try (#6118) by @IWANABETHATGUY - simplify module_namespace construction (#5939) by @IWANABETHATGUY - optimize member expression creation in AstSnippet (#6091) by @IWANABETHATGUY - test-dev-server: sensible watcher configuration for CI env (#6077) by @hyf0 ### 🧪 Testing - dev: apply HMR edits on Windows (#6094) by @sapphi-red ### ⚙️ Miscellaneous Tasks - Revert "chore: adjust breaking change template of cliff (#6069)" (#6130) by @IWANABETHATGUY - test-dev-server: improve hmr test configuration (#6115) by @hyf0 - deps: update dependency rolldown-plugin-dts to v0.16.2 (#6128) by @renovate[bot] - Revert "refactor: simplify module_namespace construction (#5939)" (#6117) by @IWANABETHATGUY - test-dev-server: optimize test log output (#6107) by @hyf0 - enable compare_contents_for_polling and update poll interval for CI test-dev-server (#6110) by @hyf0 - deps: update dependency vite to v7.1.5 [security] (#6111) by @renovate[bot] - fix warnings reported by `just lint` (#6105) by @shulaoda - deps: update dependency tsdown to v0.15.0 (#6102) by @renovate[bot] - use debug builds for browser tests in CI (#6092) by @hyf0 - test-dev-server: update polling interval and add retry logic for CI tests (#6088) by @hyf0 - adjust breaking change template of cliff (#6069) by @IWANABETHATGUY ### ◀️ Revert - "fix: replace_plugin does not work as expected with .ts config (#5920)" (#6074) by @IWANABETHATGUY Co-authored-by: Boshen <[email protected]>

github-actions bot assigned IWANABETHATGUY Sep 10, 2025

IWANABETHATGUY marked this pull request as ready for review September 10, 2025 10:54

graphite-app bot reviewed Sep 10, 2025

View reviewed changes

crates/rolldown_common/src/types/constant_value.rs Outdated Show resolved Hide resolved

IWANABETHATGUY force-pushed the 09-10-feat_partial_align_with_const_inline_strategy_with_oxc_in_smart_mode branch 2 times, most recently from a42c4cf to 9510a43 Compare September 10, 2025 10:59

IWANABETHATGUY requested a review from sapphi-red September 10, 2025 11:00

IWANABETHATGUY force-pushed the 09-10-feat_partial_align_with_const_inline_strategy_with_oxc_in_smart_mode branch from 9510a43 to 61873dd Compare September 10, 2025 11:00

sapphi-red approved these changes Sep 10, 2025

View reviewed changes

graphite-app bot force-pushed the 09-10-feat_partial_align_with_const_inline_strategy_with_oxc_in_smart_mode branch from 61873dd to d7e763d Compare September 10, 2025 11:23

IWANABETHATGUY force-pushed the 09-10-feat_partial_align_with_const_inline_strategy_with_oxc_in_smart_mode branch from d7e763d to f827155 Compare September 10, 2025 11:30

graphite-app bot reviewed Sep 10, 2025

View reviewed changes

crates/rolldown/src/module_finalizers/mod.rs Show resolved Hide resolved

IWANABETHATGUY force-pushed the 09-10-feat_partial_align_with_const_inline_strategy_with_oxc_in_smart_mode branch from f827155 to e9f1084 Compare September 10, 2025 11:54

graphite-app bot force-pushed the 09-10-feat_partial_align_with_const_inline_strategy_with_oxc_in_smart_mode branch from e9f1084 to 524f25b Compare September 10, 2025 13:09

graphite-app bot merged commit 524f25b into main Sep 10, 2025
26 checks passed

graphite-app bot deleted the 09-10-feat_partial_align_with_const_inline_strategy_with_oxc_in_smart_mode branch September 10, 2025 13:17

github-actions bot mentioned this pull request Sep 10, 2025

release: v1.0.0-beta.37 #6131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: partial align with const inline strategy with oxc in smart mode#6126

feat: partial align with const inline strategy with oxc in smart mode#6126
graphite-app[bot] merged 1 commit intomainfrom
09-10-feat_partial_align_with_const_inline_strategy_with_oxc_in_smart_mode

IWANABETHATGUY commented Sep 10, 2025 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Sep 10, 2025

Uh oh!

netlify bot commented Sep 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Sep 10, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Sep 10, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Uh oh!

github-actions bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Sep 10, 2025 •

edited

Loading

netlify bot commented Sep 10, 2025 •

edited

Loading

github-actions bot commented Sep 10, 2025 •

edited

Loading

graphite-app bot commented Sep 10, 2025 •

edited

Loading