Skip to content

Comments

chore: Revert "refactor: simplify module_namespace construction (#5939)"#6117

Merged
IWANABETHATGUY merged 1 commit intomainfrom
revert-5939
Sep 10, 2025
Merged

chore: Revert "refactor: simplify module_namespace construction (#5939)"#6117
IWANABETHATGUY merged 1 commit intomainfrom
revert-5939

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Sep 10, 2025

This reverts commit 7866a60.
Since the rolldown-plugin-dts relys on the pattern to generate d.ts

const module_ns = {}
__export({}, {...})

See log https://github.com/rolldown/rolldown/actions/runs/17603918809/job/50010934316

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 10, 2025

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 10, 2025 06:26
@IWANABETHATGUY IWANABETHATGUY changed the title Revert "refactor: simplify module_namespace construction (#5939)" chore: Revert "refactor: simplify module_namespace construction (#5939)" Sep 10, 2025
@netlify
Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit aec3fba
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68c11a0675f3a900083a99d9

@IWANABETHATGUY IWANABETHATGUY merged commit 857eb54 into main Sep 10, 2025
29 of 30 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the revert-5939 branch September 10, 2025 06:32
IWANABETHATGUY added a commit that referenced this pull request Sep 10, 2025
@github-actions
Copy link
Contributor

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     79.3±1.58ms        ? ?/sec    1.00     78.7±2.04ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     89.3±1.62ms        ? ?/sec    1.00     88.9±1.57ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    118.0±2.12ms        ? ?/sec    1.01    118.6±1.70ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    138.5±2.19ms        ? ?/sec    1.00    138.6±1.26ms        ? ?/sec
bundle/bundle@threejs                                        1.00     43.6±0.90ms        ? ?/sec    1.01     44.2±0.89ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     52.3±0.77ms        ? ?/sec    1.01     53.1±0.58ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    464.0±3.68ms        ? ?/sec    1.00    463.1±3.77ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    544.5±2.62ms        ? ?/sec    1.00    540.1±5.40ms        ? ?/sec
scan/scan@rome_ts                                            1.00     92.9±1.27ms        ? ?/sec    1.00     92.9±3.52ms        ? ?/sec
scan/scan@threejs                                            1.00     32.8±0.38ms        ? ?/sec    1.01     32.9±0.36ms        ? ?/sec
scan/scan@threejs10x                                         1.01    351.7±4.23ms        ? ?/sec    1.00    349.4±4.47ms        ? ?/sec

IWANABETHATGUY added a commit that referenced this pull request Sep 10, 2025
IWANABETHATGUY added a commit that referenced this pull request Sep 10, 2025
Boshen added a commit that referenced this pull request Sep 10, 2025
## [1.0.0-beta.37] - 2025-09-10

### 🚀 Features

- partial align with const inline strategy with oxc in smart mode
(#6126) by @IWANABETHATGUY
- dev: use PathsMut for non-debounced RecommendedWatcher (#6120) by
@sapphi-red
- dev: return whether the build is already scheduled from
`scheduleBuildIfStale` method (#6116) by @sapphi-red
- handle errors from `BundlerBuilder#build` (#6104) by @shulaoda
- add debounceTickRate option for debounced watchers (#6113) by @hyf0
- support full build in `incrementalBuild` mode (#6098) by
@IWANABETHATGUY
- add compare_contents_for_polling option to dev watcher (#6108) by
@hyf0
- dev: add `scheduleBuildIfStale` method to DevEngine (#6087) by
@sapphi-red
- dev: return changed files in onHmrUpdates callback (#6086) by
@sapphi-red
- support function config with custom CLI arguments (#6076) by
@IWANABETHATGUY
- improve `MISSING_EXPORT` warning to suggest `type` modifier (#6085) by
@sapphi-red
- crates/rolldown_watcher: introduce `PathsMut` to batch watch/unwatch
behaviors (#6075) by @hyf0
- enable `treeshake.commonjs` by default (#6072) by @IWANABETHATGUY
- dev: add debounce control and PollWatcher support to DevWatchOptions
(#6070) by @hyf0

### 🐛 Bug Fixes

- use kqueue for file watch on mac (#6124) by @sapphi-red
- use patched notify for better file change event debouncing (#6125) by
@sapphi-red
- support passing all js primitive value for `alias` plugin (#6123) by
@IWANABETHATGUY
- track spans in member expression properties for accurate sourcemaps
(#6100) by @IWANABETHATGUY
- correctly handle inlined CommonJS exports in member expressions
(#6090) by @IWANABETHATGUY
- dev: ensure patch file names to be unique (#6096) by @sapphi-red
- dev: normalize slash on Windows before comparing paths (#6095) by
@sapphi-red
- dev/watch: debounce duration should default to 10 (#6078) by @hyf0

### 🚜 Refactor

- simplify `__export` runtime helper to create target object internally
(#6114) by @IWANABETHATGUY
- simplify module_namespace construction second try (#6118) by
@IWANABETHATGUY
- simplify module_namespace construction (#5939) by @IWANABETHATGUY
- optimize member expression creation in AstSnippet (#6091) by
@IWANABETHATGUY
- test-dev-server: sensible watcher configuration for CI env (#6077) by
@hyf0

### 🧪 Testing

- dev: apply HMR edits on Windows (#6094) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- Revert "chore: adjust breaking change template of cliff (#6069)"
(#6130) by @IWANABETHATGUY
- test-dev-server: improve hmr test configuration (#6115) by @hyf0
- deps: update dependency rolldown-plugin-dts to v0.16.2 (#6128) by
@renovate[bot]
- Revert "refactor: simplify module_namespace construction (#5939)"
(#6117) by @IWANABETHATGUY
- test-dev-server: optimize test log output (#6107) by @hyf0
- enable compare_contents_for_polling and update poll interval for CI
test-dev-server (#6110) by @hyf0
- deps: update dependency vite to v7.1.5 [security] (#6111) by
@renovate[bot]
- fix warnings reported by `just lint` (#6105) by @shulaoda
- deps: update dependency tsdown to v0.15.0 (#6102) by @renovate[bot]
- use debug builds for browser tests in CI (#6092) by @hyf0
- test-dev-server: update polling interval and add retry logic for CI
tests (#6088) by @hyf0
- adjust breaking change template of cliff (#6069) by @IWANABETHATGUY

### ◀️ Revert

- "fix: replace_plugin does not work as expected with .ts config
(#5920)" (#6074) by @IWANABETHATGUY

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants