Skip to content

Comments

feat: add compare_contents_for_polling option to dev watcher#6108

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-10-feat_add_compare_contents_for_polling_option_to_dev_watcher
Sep 10, 2025
Merged

feat: add compare_contents_for_polling option to dev watcher#6108
graphite-app[bot] merged 1 commit intomainfrom
09-10-feat_add_compare_contents_for_polling_option_to_dev_watcher

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Sep 9, 2025

Adds support for compare_contents option in poll-based watchers to
enable content comparison for better change detection.

Changes:

  • Add compare_contents_for_polling field to WatcherConfig (defaults to false)
  • Expose option through DevWatchOptions in both Rust and TypeScript APIs
  • Update NAPI binding to pass option from TS to Rust
  • Auto-generated binding.d.ts now includes the new option

Copy link
Member Author

hyf0 commented Sep 9, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit c91c8c4
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68c0d6abae583e000819922d
😎 Deploy Preview https://deploy-preview-6108--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hyf0 hyf0 force-pushed the 09-10-feat_add_compare_contents_for_polling_option_to_dev_watcher branch from 52eaf7e to 36743a6 Compare September 9, 2025 16:48
@hyf0 hyf0 requested review from sapphi-red and shulaoda September 9, 2025 16:57
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Benchmarks Rust

  • target: main(00399fe)
  • pr: 09-10-feat_add_compare_contents_for_polling_option_to_dev_watcher(c91c8c4)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     80.3±1.64ms        ? ?/sec    1.00     79.2±1.98ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     91.1±1.99ms        ? ?/sec    1.00     89.6±1.67ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    120.1±3.00ms        ? ?/sec    1.00    119.3±2.37ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    141.1±3.50ms        ? ?/sec    1.00    138.4±1.86ms        ? ?/sec
bundle/bundle@threejs                                        1.00     45.5±2.39ms        ? ?/sec    1.00     45.4±2.34ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     53.9±0.84ms        ? ?/sec    1.00     53.4±0.73ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    469.5±5.22ms        ? ?/sec    1.00    466.8±6.74ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    549.6±3.40ms        ? ?/sec    1.00    546.5±4.26ms        ? ?/sec
scan/scan@rome_ts                                            1.00     94.9±2.04ms        ? ?/sec    1.02     97.1±2.09ms        ? ?/sec
scan/scan@threejs                                            1.00     33.6±0.57ms        ? ?/sec    1.01     33.9±0.40ms        ? ?/sec
scan/scan@threejs10x                                         1.00    352.0±3.69ms        ? ?/sec    1.00    352.7±3.57ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 10, 2025

Merge activity

Adds support for compare_contents option in poll-based watchers to
enable content comparison for better change detection.

Changes:
- Add compare_contents_for_polling field to WatcherConfig (defaults to false)
- Expose option through DevWatchOptions in both Rust and TypeScript APIs
- Update NAPI binding to pass option from TS to Rust
- Auto-generated binding.d.ts now includes the new option
@graphite-app graphite-app bot force-pushed the 09-10-feat_add_compare_contents_for_polling_option_to_dev_watcher branch from 36743a6 to c91c8c4 Compare September 10, 2025 01:38
@graphite-app graphite-app bot merged commit c91c8c4 into main Sep 10, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 09-10-feat_add_compare_contents_for_polling_option_to_dev_watcher branch September 10, 2025 01:50
Boshen added a commit that referenced this pull request Sep 10, 2025
## [1.0.0-beta.37] - 2025-09-10

### 🚀 Features

- partial align with const inline strategy with oxc in smart mode
(#6126) by @IWANABETHATGUY
- dev: use PathsMut for non-debounced RecommendedWatcher (#6120) by
@sapphi-red
- dev: return whether the build is already scheduled from
`scheduleBuildIfStale` method (#6116) by @sapphi-red
- handle errors from `BundlerBuilder#build` (#6104) by @shulaoda
- add debounceTickRate option for debounced watchers (#6113) by @hyf0
- support full build in `incrementalBuild` mode (#6098) by
@IWANABETHATGUY
- add compare_contents_for_polling option to dev watcher (#6108) by
@hyf0
- dev: add `scheduleBuildIfStale` method to DevEngine (#6087) by
@sapphi-red
- dev: return changed files in onHmrUpdates callback (#6086) by
@sapphi-red
- support function config with custom CLI arguments (#6076) by
@IWANABETHATGUY
- improve `MISSING_EXPORT` warning to suggest `type` modifier (#6085) by
@sapphi-red
- crates/rolldown_watcher: introduce `PathsMut` to batch watch/unwatch
behaviors (#6075) by @hyf0
- enable `treeshake.commonjs` by default (#6072) by @IWANABETHATGUY
- dev: add debounce control and PollWatcher support to DevWatchOptions
(#6070) by @hyf0

### 🐛 Bug Fixes

- use kqueue for file watch on mac (#6124) by @sapphi-red
- use patched notify for better file change event debouncing (#6125) by
@sapphi-red
- support passing all js primitive value for `alias` plugin (#6123) by
@IWANABETHATGUY
- track spans in member expression properties for accurate sourcemaps
(#6100) by @IWANABETHATGUY
- correctly handle inlined CommonJS exports in member expressions
(#6090) by @IWANABETHATGUY
- dev: ensure patch file names to be unique (#6096) by @sapphi-red
- dev: normalize slash on Windows before comparing paths (#6095) by
@sapphi-red
- dev/watch: debounce duration should default to 10 (#6078) by @hyf0

### 🚜 Refactor

- simplify `__export` runtime helper to create target object internally
(#6114) by @IWANABETHATGUY
- simplify module_namespace construction second try (#6118) by
@IWANABETHATGUY
- simplify module_namespace construction (#5939) by @IWANABETHATGUY
- optimize member expression creation in AstSnippet (#6091) by
@IWANABETHATGUY
- test-dev-server: sensible watcher configuration for CI env (#6077) by
@hyf0

### 🧪 Testing

- dev: apply HMR edits on Windows (#6094) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- Revert "chore: adjust breaking change template of cliff (#6069)"
(#6130) by @IWANABETHATGUY
- test-dev-server: improve hmr test configuration (#6115) by @hyf0
- deps: update dependency rolldown-plugin-dts to v0.16.2 (#6128) by
@renovate[bot]
- Revert "refactor: simplify module_namespace construction (#5939)"
(#6117) by @IWANABETHATGUY
- test-dev-server: optimize test log output (#6107) by @hyf0
- enable compare_contents_for_polling and update poll interval for CI
test-dev-server (#6110) by @hyf0
- deps: update dependency vite to v7.1.5 [security] (#6111) by
@renovate[bot]
- fix warnings reported by `just lint` (#6105) by @shulaoda
- deps: update dependency tsdown to v0.15.0 (#6102) by @renovate[bot]
- use debug builds for browser tests in CI (#6092) by @hyf0
- test-dev-server: update polling interval and add retry logic for CI
tests (#6088) by @hyf0
- adjust breaking change template of cliff (#6069) by @IWANABETHATGUY

### ◀️ Revert

- "fix: replace_plugin does not work as expected with .ts config
(#5920)" (#6074) by @IWANABETHATGUY

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants