Skip to content

Comments

chore: fix warnings reported by just lint#6105

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-09-chore_fix_warnings_and_errors_reported_by_just_lint
Sep 9, 2025
Merged

chore: fix warnings reported by just lint#6105
graphite-app[bot] merged 1 commit intomainfrom
09-09-chore_fix_warnings_and_errors_reported_by_just_lint

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Sep 9, 2025 •
edited
Loading 

warning: variable does not need to be mutable
 --> crates\bench\benches\scan.rs:8:7
  |
8 |   let mut result = vec![("threejs", threejs()), ("rome_ts", rome_ts())];
  |       ----^^^^^^
  |       |
  |       help: remove this `mut`
  |
  = note: `#[warn(unused_mut)]` on by default

warning: variable does not need to be mutable
 --> crates\bench\benches\bundle.rs:9:7
  |
9 |   let mut result = vec![
  |       ----^^^^^^
  |       |
  |       help: remove this `mut`
  |
  = note: `#[warn(unused_mut)]` on by default

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Sep 9, 2025

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Sep 9, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit f0c99fd
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68c04c20232f23000899ffde

@shulaoda shulaoda changed the title chore: fix warnings and errors reported by just lint chore: fix warnings and errors reported by just lint Sep 9, 2025
@shulaoda shulaoda marked this pull request as ready for review September 9, 2025 15:24
@shulaoda shulaoda requested a review from hyf0 September 9, 2025 15:34
@shulaoda shulaoda force-pushed the 09-09-chore_fix_warnings_and_errors_reported_by_just_lint branch from 7ba9f2a to 36c7ace Compare September 9, 2025 15:34
@shulaoda shulaoda changed the title chore: fix warnings and errors reported by just lint chore: fix warnings reported by just lint Sep 9, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 9, 2025 •
edited
Loading

Merge activity

@shulaoda
chore: fix warnings reported by just lint (#6105)
f0c99fd 
```bash
warning: variable does not need to be mutable
 --> crates\bench\benches\scan.rs:8:7
  |
8 |   let mut result = vec![("threejs", threejs()), ("rome_ts", rome_ts())];
  |       ----^^^^^^
  |       |
  |       help: remove this `mut`
  |
  = note: `#[warn(unused_mut)]` on by default

warning: variable does not need to be mutable
 --> crates\bench\benches\bundle.rs:9:7
  |
9 |   let mut result = vec![
  |       ----^^^^^^
  |       |
  |       help: remove this `mut`
  |
  = note: `#[warn(unused_mut)]` on by default
```
@graphite-app graphite-app bot force-pushed the 09-09-chore_fix_warnings_and_errors_reported_by_just_lint branch from 36c7ace to f0c99fd Compare September 9, 2025 15:47
@hyf0
Copy link
Member

hyf0 commented Sep 9, 2025 •
edited
Loading

Could you find way to deny such warning in just lint-rust(CI too. I guess it's related to --target bench/test maybe. See if AI could make it right.

@graphite-app graphite-app bot merged commit f0c99fd into main Sep 9, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 09-09-chore_fix_warnings_and_errors_reported_by_just_lint branch September 9, 2025 15:59
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Benchmarks Rust

  • target: main(cb10079)
  • pr: 09-09-chore_fix_warnings_and_errors_reported_by_just_lint(f0c99fd)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.07     93.8±3.32ms        ? ?/sec    1.00     87.9±3.23ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00    101.1±4.68ms        ? ?/sec    1.00    100.9±3.00ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    129.4±3.47ms        ? ?/sec    1.00    125.2±2.49ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    150.5±3.07ms        ? ?/sec    1.00    147.8±2.90ms        ? ?/sec
bundle/bundle@threejs                                        1.00     47.3±1.49ms        ? ?/sec    1.01     47.7±1.01ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     57.1±0.89ms        ? ?/sec    1.00     56.0±0.87ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00   499.8±11.41ms        ? ?/sec    1.00    499.2±9.48ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    585.2±8.50ms        ? ?/sec    1.01   591.9±12.90ms        ? ?/sec
scan/scan@rome_ts                                            1.00     97.8±2.26ms        ? ?/sec    1.00     98.2±2.15ms        ? ?/sec
scan/scan@threejs                                            1.00     34.9±2.00ms        ? ?/sec    1.01     35.3±1.92ms        ? ?/sec
scan/scan@threejs10x                                         1.00    363.0±4.49ms        ? ?/sec    1.01    368.1±5.37ms        ? ?/sec

@github-actions github-actions bot mentioned this pull request Sep 10, 2025
Merged
Boshen added a commit that referenced this pull request Sep 10, 2025
@github-actions @Boshen
release: v1.0.0-beta.37 (#6131)
a97dcbe 
## [1.0.0-beta.37] - 2025-09-10

### 🚀 Features

- partial align with const inline strategy with oxc in smart mode
(#6126) by @IWANABETHATGUY
- dev: use PathsMut for non-debounced RecommendedWatcher (#6120) by
@sapphi-red
- dev: return whether the build is already scheduled from
`scheduleBuildIfStale` method (#6116) by @sapphi-red
- handle errors from `BundlerBuilder#build` (#6104) by @shulaoda
- add debounceTickRate option for debounced watchers (#6113) by @hyf0
- support full build in `incrementalBuild` mode (#6098) by
@IWANABETHATGUY
- add compare_contents_for_polling option to dev watcher (#6108) by
@hyf0
- dev: add `scheduleBuildIfStale` method to DevEngine (#6087) by
@sapphi-red
- dev: return changed files in onHmrUpdates callback (#6086) by
@sapphi-red
- support function config with custom CLI arguments (#6076) by
@IWANABETHATGUY
- improve `MISSING_EXPORT` warning to suggest `type` modifier (#6085) by
@sapphi-red
- crates/rolldown_watcher: introduce `PathsMut` to batch watch/unwatch
behaviors (#6075) by @hyf0
- enable `treeshake.commonjs` by default (#6072) by @IWANABETHATGUY
- dev: add debounce control and PollWatcher support to DevWatchOptions
(#6070) by @hyf0

### 🐛 Bug Fixes

- use kqueue for file watch on mac (#6124) by @sapphi-red
- use patched notify for better file change event debouncing (#6125) by
@sapphi-red
- support passing all js primitive value for `alias` plugin (#6123) by
@IWANABETHATGUY
- track spans in member expression properties for accurate sourcemaps
(#6100) by @IWANABETHATGUY
- correctly handle inlined CommonJS exports in member expressions
(#6090) by @IWANABETHATGUY
- dev: ensure patch file names to be unique (#6096) by @sapphi-red
- dev: normalize slash on Windows before comparing paths (#6095) by
@sapphi-red
- dev/watch: debounce duration should default to 10 (#6078) by @hyf0

### 🚜 Refactor

- simplify `__export` runtime helper to create target object internally
(#6114) by @IWANABETHATGUY
- simplify module_namespace construction second try (#6118) by
@IWANABETHATGUY
- simplify module_namespace construction (#5939) by @IWANABETHATGUY
- optimize member expression creation in AstSnippet (#6091) by
@IWANABETHATGUY
- test-dev-server: sensible watcher configuration for CI env (#6077) by
@hyf0

### 🧪 Testing

- dev: apply HMR edits on Windows (#6094) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- Revert "chore: adjust breaking change template of cliff (#6069)"
(#6130) by @IWANABETHATGUY
- test-dev-server: improve hmr test configuration (#6115) by @hyf0
- deps: update dependency rolldown-plugin-dts to v0.16.2 (#6128) by
@renovate[bot]
- Revert "refactor: simplify module_namespace construction (#5939)"
(#6117) by @IWANABETHATGUY
- test-dev-server: optimize test log output (#6107) by @hyf0
- enable compare_contents_for_polling and update poll interval for CI
test-dev-server (#6110) by @hyf0
- deps: update dependency vite to v7.1.5 [security] (#6111) by
@renovate[bot]
- fix warnings reported by `just lint` (#6105) by @shulaoda
- deps: update dependency tsdown to v0.15.0 (#6102) by @renovate[bot]
- use debug builds for browser tests in CI (#6092) by @hyf0
- test-dev-server: update polling interval and add retry logic for CI
tests (#6088) by @hyf0
- adjust breaking change template of cliff (#6069) by @IWANABETHATGUY

### ◀️ Revert

- "fix: replace_plugin does not work as expected with .ts config
(#5920)" (#6074) by @IWANABETHATGUY

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

@hyf0 hyf0 Awaiting requested review from hyf0

Assignees

@shulaoda shulaoda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shulaoda @hyf0 @IWANABETHATGUY