feat: handle errors from `BundlerBuilder#build` by shulaoda · Pull Request #6104 · rolldown/rolldown

shulaoda · 2025-09-09T15:07:53Z

In BundlerBuilder#build, some option-related errors or other issues cannot be represented as warnings, so we need to provide proper error handling for build failures.

shulaoda · 2025-09-09T15:08:10Z

feat: handle errors from BundlerBuilder#build #6104 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-09-09T15:08:23Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`a9c1d9b`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68c12730bd384f0008382669

crates/rolldown/src/bundler_builder.rs

github-actions · 2025-09-09T15:24:11Z

Benchmarks Rust

target: main(b3656a9)
pr: 09-09-feat_handle_errors_from_bundlerbuilder_build(a9c1d9b)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     86.9±2.14ms        ? ?/sec    1.00     85.9±1.95ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     96.6±2.74ms        ? ?/sec    1.01     97.7±2.09ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    123.1±3.23ms        ? ?/sec    1.01    123.9±1.85ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    144.7±2.30ms        ? ?/sec    1.00    144.1±3.02ms        ? ?/sec
bundle/bundle@threejs                                        1.00     47.2±0.73ms        ? ?/sec    1.01     47.7±1.16ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     55.7±1.50ms        ? ?/sec    1.01     56.2±1.80ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    482.7±6.86ms        ? ?/sec    1.01    489.5±7.50ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    563.9±5.46ms        ? ?/sec    1.00    565.0±6.48ms        ? ?/sec
scan/scan@rome_ts                                            1.02     99.5±2.40ms        ? ?/sec    1.00     97.9±1.74ms        ? ?/sec
scan/scan@threejs                                            1.02     35.3±0.48ms        ? ?/sec    1.00     34.7±0.46ms        ? ?/sec
scan/scan@threejs10x                                         1.00    363.7±6.06ms        ? ?/sec    1.00    362.1±5.04ms        ? ?/sec

graphite-app · 2025-09-10T04:42:49Z

Merge activity

Sep 10, 4:42 AM UTC: shulaoda added this pull request to the Graphite merge queue.
Sep 10, 4:49 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test (macos-latest) / Node Test', 'node-test (windows-latest) / Node Test').
Sep 10, 6:16 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Sep 10, 6:22 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test (ubuntu-latest) / Node Test', 'node-test (macos-latest) / Node Test', 'node-test (windows-latest) / Node Test').
Sep 10, 6:42 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 10, 6:42 AM UTC: shulaoda added this pull request to the Graphite merge queue.
Sep 10, 6:59 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test (ubuntu-latest) / Node Test', 'node-test (macos-latest) / Node Test', 'node-test (windows-latest) / Node Test').
Sep 10, 7:16 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 10, 7:22 AM UTC: shulaoda added this pull request to the Graphite merge queue.
Sep 10, 7:30 AM UTC: Merged by the Graphite merge queue.

In `BundlerBuilder#build`, some option-related errors or other issues cannot be represented as warnings, so we need to provide proper error handling for build failures.

crates/rolldown_testing/src/integration_test.rs

In `BundlerBuilder#build`, some option-related errors or other issues cannot be represented as warnings, so we need to provide proper error handling for build failures.

@IWANABETHATGUY

## [1.0.0-beta.37] - 2025-09-10 ### 🚀 Features - partial align with const inline strategy with oxc in smart mode (#6126) by @IWANABETHATGUY - dev: use PathsMut for non-debounced RecommendedWatcher (#6120) by @sapphi-red - dev: return whether the build is already scheduled from `scheduleBuildIfStale` method (#6116) by @sapphi-red - handle errors from `BundlerBuilder#build` (#6104) by @shulaoda - add debounceTickRate option for debounced watchers (#6113) by @hyf0 - support full build in `incrementalBuild` mode (#6098) by @IWANABETHATGUY - add compare_contents_for_polling option to dev watcher (#6108) by @hyf0 - dev: add `scheduleBuildIfStale` method to DevEngine (#6087) by @sapphi-red - dev: return changed files in onHmrUpdates callback (#6086) by @sapphi-red - support function config with custom CLI arguments (#6076) by @IWANABETHATGUY - improve `MISSING_EXPORT` warning to suggest `type` modifier (#6085) by @sapphi-red - crates/rolldown_watcher: introduce `PathsMut` to batch watch/unwatch behaviors (#6075) by @hyf0 - enable `treeshake.commonjs` by default (#6072) by @IWANABETHATGUY - dev: add debounce control and PollWatcher support to DevWatchOptions (#6070) by @hyf0 ### 🐛 Bug Fixes - use kqueue for file watch on mac (#6124) by @sapphi-red - use patched notify for better file change event debouncing (#6125) by @sapphi-red - support passing all js primitive value for `alias` plugin (#6123) by @IWANABETHATGUY - track spans in member expression properties for accurate sourcemaps (#6100) by @IWANABETHATGUY - correctly handle inlined CommonJS exports in member expressions (#6090) by @IWANABETHATGUY - dev: ensure patch file names to be unique (#6096) by @sapphi-red - dev: normalize slash on Windows before comparing paths (#6095) by @sapphi-red - dev/watch: debounce duration should default to 10 (#6078) by @hyf0 ### 🚜 Refactor - simplify `__export` runtime helper to create target object internally (#6114) by @IWANABETHATGUY - simplify module_namespace construction second try (#6118) by @IWANABETHATGUY - simplify module_namespace construction (#5939) by @IWANABETHATGUY - optimize member expression creation in AstSnippet (#6091) by @IWANABETHATGUY - test-dev-server: sensible watcher configuration for CI env (#6077) by @hyf0 ### 🧪 Testing - dev: apply HMR edits on Windows (#6094) by @sapphi-red ### ⚙️ Miscellaneous Tasks - Revert "chore: adjust breaking change template of cliff (#6069)" (#6130) by @IWANABETHATGUY - test-dev-server: improve hmr test configuration (#6115) by @hyf0 - deps: update dependency rolldown-plugin-dts to v0.16.2 (#6128) by @renovate[bot] - Revert "refactor: simplify module_namespace construction (#5939)" (#6117) by @IWANABETHATGUY - test-dev-server: optimize test log output (#6107) by @hyf0 - enable compare_contents_for_polling and update poll interval for CI test-dev-server (#6110) by @hyf0 - deps: update dependency vite to v7.1.5 [security] (#6111) by @renovate[bot] - fix warnings reported by `just lint` (#6105) by @shulaoda - deps: update dependency tsdown to v0.15.0 (#6102) by @renovate[bot] - use debug builds for browser tests in CI (#6092) by @hyf0 - test-dev-server: update polling interval and add retry logic for CI tests (#6088) by @hyf0 - adjust breaking change template of cliff (#6069) by @IWANABETHATGUY ### ◀️ Revert - "fix: replace_plugin does not work as expected with .ts config (#5920)" (#6074) by @IWANABETHATGUY Co-authored-by: Boshen <[email protected]>

github-actions bot assigned shulaoda Sep 9, 2025

shulaoda changed the title ~~feat: handle errors from BundlerBuilder#build~~ feat: handle errors from BundlerBuilder#build Sep 9, 2025

shulaoda requested review from IWANABETHATGUY and hyf0 September 9, 2025 15:10

shulaoda marked this pull request as ready for review September 9, 2025 15:10

hyf0 reviewed Sep 9, 2025

View reviewed changes

crates/rolldown/src/bundler_builder.rs Show resolved Hide resolved

shulaoda force-pushed the 09-09-feat_handle_errors_from_bundlerbuilder_build branch from 6d452b0 to 931cd4f Compare September 9, 2025 15:31

hyf0 approved these changes Sep 9, 2025

View reviewed changes

IWANABETHATGUY approved these changes Sep 10, 2025

View reviewed changes

graphite-app bot force-pushed the 09-09-feat_handle_errors_from_bundlerbuilder_build branch from 931cd4f to 8f19c46 Compare September 10, 2025 04:43

graphite-app bot reviewed Sep 10, 2025

View reviewed changes

crates/rolldown_testing/src/integration_test.rs Show resolved Hide resolved

graphite-app bot force-pushed the 09-09-feat_handle_errors_from_bundlerbuilder_build branch from 8f19c46 to 3541e27 Compare September 10, 2025 06:16

shulaoda added the graphite: merge label Sep 10, 2025

graphite-app bot force-pushed the 09-09-feat_handle_errors_from_bundlerbuilder_build branch from 3541e27 to 4c1c4e6 Compare September 10, 2025 06:53

graphite-app bot removed the graphite: merge label Sep 10, 2025

shulaoda added the graphite: merge label Sep 10, 2025

feat: handle errors from BundlerBuilder#build (#6104)

a9c1d9b

In `BundlerBuilder#build`, some option-related errors or other issues cannot be represented as warnings, so we need to provide proper error handling for build failures.

graphite-app bot force-pushed the 09-09-feat_handle_errors_from_bundlerbuilder_build branch from 4c1c4e6 to a9c1d9b Compare September 10, 2025 07:22

graphite-app bot merged commit a9c1d9b into main Sep 10, 2025
26 checks passed

graphite-app bot deleted the 09-09-feat_handle_errors_from_bundlerbuilder_build branch September 10, 2025 07:30

graphite-app bot removed the graphite: merge label Sep 10, 2025

github-actions bot mentioned this pull request Sep 10, 2025

release: v1.0.0-beta.37 #6131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: handle errors from `BundlerBuilder#build`#6104

feat: handle errors from `BundlerBuilder#build`#6104
graphite-app[bot] merged 1 commit intomainfrom
09-09-feat_handle_errors_from_bundlerbuilder_build

shulaoda commented Sep 9, 2025 •

edited

Loading

Uh oh!

shulaoda commented Sep 9, 2025

Uh oh!

netlify bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

shulaoda commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Sep 9, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Uh oh!

github-actions bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shulaoda commented Sep 9, 2025 •

edited

Loading

netlify bot commented Sep 9, 2025 •

edited

Loading

github-actions bot commented Sep 9, 2025 •

edited

Loading

graphite-app bot commented Sep 10, 2025 •

edited

Loading