fix(dev): normalize slash on Windows before comparing paths by sapphi-red · Pull Request #6095 · rolldown/rolldown

sapphi-red · 2025-09-09T09:44:27Z

I wasn't able to add a test, but this self.module_idx_by_abs_path.get look up was failing on Windows because of the slash difference.

sapphi-red · 2025-09-09T09:44:42Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-09-09T10:08:34Z

Benchmarks Rust

target: main(1a91220)
pr: 09-09-fix_dev_normalize_slash_on_windows_before_comparing_paths(9ba5f27)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     79.0±1.55ms        ? ?/sec    1.00     78.8±1.56ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     89.4±1.47ms        ? ?/sec    1.00     89.1±1.58ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    118.8±1.61ms        ? ?/sec    1.00    118.5±1.64ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    139.0±2.00ms        ? ?/sec    1.00    139.0±1.80ms        ? ?/sec
bundle/bundle@threejs                                        1.00     44.4±0.99ms        ? ?/sec    1.00     44.5±0.76ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     53.4±1.93ms        ? ?/sec    1.00     53.2±0.86ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    470.5±6.59ms        ? ?/sec    1.00    464.4±5.99ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    551.1±6.36ms        ? ?/sec    1.00    541.0±3.56ms        ? ?/sec
scan/scan@rome_ts                                            1.02     95.6±1.82ms        ? ?/sec    1.00     93.5±1.20ms        ? ?/sec
scan/scan@threejs                                            1.00     33.5±0.45ms        ? ?/sec    1.00     33.5±0.45ms        ? ?/sec
scan/scan@threejs10x                                         1.01    352.2±4.48ms        ? ?/sec    1.00    350.5±3.47ms        ? ?/sec

netlify · 2025-09-09T10:18:46Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`9ba5f27`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68c00664d22254000858fcd0

graphite-app · 2025-09-09T10:49:50Z

Merge activity

Sep 9, 10:49 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Sep 9, 11:04 AM UTC: Merged by the Graphite merge queue.

I wasn't able to add a test, but this `self.module_idx_by_abs_path.get` look up was failing on Windows because of the slash difference.

@IWANABETHATGUY

## [1.0.0-beta.37] - 2025-09-10 ### 🚀 Features - partial align with const inline strategy with oxc in smart mode (#6126) by @IWANABETHATGUY - dev: use PathsMut for non-debounced RecommendedWatcher (#6120) by @sapphi-red - dev: return whether the build is already scheduled from `scheduleBuildIfStale` method (#6116) by @sapphi-red - handle errors from `BundlerBuilder#build` (#6104) by @shulaoda - add debounceTickRate option for debounced watchers (#6113) by @hyf0 - support full build in `incrementalBuild` mode (#6098) by @IWANABETHATGUY - add compare_contents_for_polling option to dev watcher (#6108) by @hyf0 - dev: add `scheduleBuildIfStale` method to DevEngine (#6087) by @sapphi-red - dev: return changed files in onHmrUpdates callback (#6086) by @sapphi-red - support function config with custom CLI arguments (#6076) by @IWANABETHATGUY - improve `MISSING_EXPORT` warning to suggest `type` modifier (#6085) by @sapphi-red - crates/rolldown_watcher: introduce `PathsMut` to batch watch/unwatch behaviors (#6075) by @hyf0 - enable `treeshake.commonjs` by default (#6072) by @IWANABETHATGUY - dev: add debounce control and PollWatcher support to DevWatchOptions (#6070) by @hyf0 ### 🐛 Bug Fixes - use kqueue for file watch on mac (#6124) by @sapphi-red - use patched notify for better file change event debouncing (#6125) by @sapphi-red - support passing all js primitive value for `alias` plugin (#6123) by @IWANABETHATGUY - track spans in member expression properties for accurate sourcemaps (#6100) by @IWANABETHATGUY - correctly handle inlined CommonJS exports in member expressions (#6090) by @IWANABETHATGUY - dev: ensure patch file names to be unique (#6096) by @sapphi-red - dev: normalize slash on Windows before comparing paths (#6095) by @sapphi-red - dev/watch: debounce duration should default to 10 (#6078) by @hyf0 ### 🚜 Refactor - simplify `__export` runtime helper to create target object internally (#6114) by @IWANABETHATGUY - simplify module_namespace construction second try (#6118) by @IWANABETHATGUY - simplify module_namespace construction (#5939) by @IWANABETHATGUY - optimize member expression creation in AstSnippet (#6091) by @IWANABETHATGUY - test-dev-server: sensible watcher configuration for CI env (#6077) by @hyf0 ### 🧪 Testing - dev: apply HMR edits on Windows (#6094) by @sapphi-red ### ⚙️ Miscellaneous Tasks - Revert "chore: adjust breaking change template of cliff (#6069)" (#6130) by @IWANABETHATGUY - test-dev-server: improve hmr test configuration (#6115) by @hyf0 - deps: update dependency rolldown-plugin-dts to v0.16.2 (#6128) by @renovate[bot] - Revert "refactor: simplify module_namespace construction (#5939)" (#6117) by @IWANABETHATGUY - test-dev-server: optimize test log output (#6107) by @hyf0 - enable compare_contents_for_polling and update poll interval for CI test-dev-server (#6110) by @hyf0 - deps: update dependency vite to v7.1.5 [security] (#6111) by @renovate[bot] - fix warnings reported by `just lint` (#6105) by @shulaoda - deps: update dependency tsdown to v0.15.0 (#6102) by @renovate[bot] - use debug builds for browser tests in CI (#6092) by @hyf0 - test-dev-server: update polling interval and add retry logic for CI tests (#6088) by @hyf0 - adjust breaking change template of cliff (#6069) by @IWANABETHATGUY ### ◀️ Revert - "fix: replace_plugin does not work as expected with .ts config (#5920)" (#6074) by @IWANABETHATGUY Co-authored-by: Boshen <[email protected]>

This was referenced Sep 9, 2025

test(dev): apply HMR edits on Windows #6094

Merged

fix(dev): ensure patch file names to be unique #6096

Merged

sapphi-red assigned hyf0 Sep 9, 2025

sapphi-red requested a review from hyf0 September 9, 2025 09:45

sapphi-red marked this pull request as ready for review September 9, 2025 09:46

sapphi-red marked this pull request as draft September 9, 2025 09:48

sapphi-red force-pushed the 09-09-fix_dev_normalize_slash_on_windows_before_comparing_paths branch from f0a95ad to 965d9da Compare September 9, 2025 09:52

sapphi-red marked this pull request as ready for review September 9, 2025 09:58

sapphi-red marked this pull request as draft September 9, 2025 10:00

graphite-app bot changed the base branch from 09-09-test_dev_apply_hmr_edits_on_windows to graphite-base/6095 September 9, 2025 10:03

graphite-app bot force-pushed the graphite-base/6095 branch from eff5229 to 1a91220 Compare September 9, 2025 10:17

graphite-app bot force-pushed the 09-09-fix_dev_normalize_slash_on_windows_before_comparing_paths branch from 965d9da to 373f0fd Compare September 9, 2025 10:17

graphite-app bot changed the base branch from graphite-base/6095 to main September 9, 2025 10:17

graphite-app bot force-pushed the 09-09-fix_dev_normalize_slash_on_windows_before_comparing_paths branch from 373f0fd to f0b7745 Compare September 9, 2025 10:17

sapphi-red force-pushed the 09-09-fix_dev_normalize_slash_on_windows_before_comparing_paths branch 2 times, most recently from 9420c89 to 337b2ce Compare September 9, 2025 10:31

sapphi-red marked this pull request as ready for review September 9, 2025 10:42

hyf0 approved these changes Sep 9, 2025

View reviewed changes

fix(dev): normalize slash on Windows before comparing paths (#6095)

9ba5f27

I wasn't able to add a test, but this `self.module_idx_by_abs_path.get` look up was failing on Windows because of the slash difference.

graphite-app bot force-pushed the 09-09-fix_dev_normalize_slash_on_windows_before_comparing_paths branch from 337b2ce to 9ba5f27 Compare September 9, 2025 10:50

graphite-app bot merged commit 9ba5f27 into main Sep 9, 2025
26 checks passed

graphite-app bot deleted the 09-09-fix_dev_normalize_slash_on_windows_before_comparing_paths branch September 9, 2025 11:04

github-actions bot mentioned this pull request Sep 10, 2025

release: v1.0.0-beta.37 #6131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix(dev): normalize slash on Windows before comparing paths#6095

fix(dev): normalize slash on Windows before comparing paths#6095
graphite-app[bot] merged 1 commit intomainfrom
09-09-fix_dev_normalize_slash_on_windows_before_comparing_paths

sapphi-red commented Sep 9, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Sep 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

netlify bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

sapphi-red commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

netlify bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

graphite-app bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sapphi-red commented Sep 9, 2025 •

edited

Loading

sapphi-red commented Sep 9, 2025 •

edited

Loading

github-actions bot commented Sep 9, 2025 •

edited

Loading

netlify bot commented Sep 9, 2025 •

edited

Loading

graphite-app bot commented Sep 9, 2025 •

edited

Loading