fix: correctly handle inlined CommonJS exports in member expressions by IWANABETHATGUY · Pull Request #6090 · rolldown/rolldown

IWANABETHATGUY · 2025-09-09T08:30:01Z

IWANABETHATGUY · 2025-09-09T08:30:20Z

fix: correctly handle inlined CommonJS exports in member expressions #6090 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-09-09T08:30:55Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`25aa188`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68c0165c48b3fd0008524a97

crates/rolldown/src/module_finalizers/mod.rs

github-actions · 2025-09-09T08:53:44Z

Benchmarks Rust

target: main(a871d8d)
pr: 09-09-fix_6080(25aa188)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.04     85.3±3.40ms        ? ?/sec    1.00     81.7±2.72ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     93.4±3.36ms        ? ?/sec    1.00     91.4±2.01ms        ? ?/sec
bundle/bundle@rome_ts                                        1.04    125.5±4.91ms        ? ?/sec    1.00    121.2±3.06ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.03    145.5±4.15ms        ? ?/sec    1.00    141.9±3.66ms        ? ?/sec
bundle/bundle@threejs                                        1.00     45.3±0.92ms        ? ?/sec    1.01     45.6±1.28ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     55.2±1.37ms        ? ?/sec    1.00     54.0±1.51ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    476.9±7.16ms        ? ?/sec    1.00    473.3±6.65ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    556.2±5.57ms        ? ?/sec    1.02   567.6±40.99ms        ? ?/sec
scan/scan@rome_ts                                            1.00     95.0±1.47ms        ? ?/sec    1.01     96.1±2.40ms        ? ?/sec
scan/scan@threejs                                            1.00     33.7±0.53ms        ? ?/sec    1.01     34.2±2.07ms        ? ?/sec
scan/scan@threejs10x                                         1.00    355.1±4.88ms        ? ?/sec    1.00    354.4±4.75ms        ? ?/sec

crates/rolldown/tests/rolldown/tree_shaking/commonjs_inline_const/main.js

crates/rolldown/src/module_finalizers/mod.rs

IWANABETHATGUY · 2025-09-09T10:44:27Z

Merge activity

Sep 9, 10:44 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 9, 11:19 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Sep 9, 11:31 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test (macos-latest) / Node Test').
Sep 9, 11:54 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 9, 11:57 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Sep 9, 12:08 PM UTC: Merged by the Graphite merge queue.

…6090) Fixes #6080

@IWANABETHATGUY

## [1.0.0-beta.37] - 2025-09-10 ### 🚀 Features - partial align with const inline strategy with oxc in smart mode (#6126) by @IWANABETHATGUY - dev: use PathsMut for non-debounced RecommendedWatcher (#6120) by @sapphi-red - dev: return whether the build is already scheduled from `scheduleBuildIfStale` method (#6116) by @sapphi-red - handle errors from `BundlerBuilder#build` (#6104) by @shulaoda - add debounceTickRate option for debounced watchers (#6113) by @hyf0 - support full build in `incrementalBuild` mode (#6098) by @IWANABETHATGUY - add compare_contents_for_polling option to dev watcher (#6108) by @hyf0 - dev: add `scheduleBuildIfStale` method to DevEngine (#6087) by @sapphi-red - dev: return changed files in onHmrUpdates callback (#6086) by @sapphi-red - support function config with custom CLI arguments (#6076) by @IWANABETHATGUY - improve `MISSING_EXPORT` warning to suggest `type` modifier (#6085) by @sapphi-red - crates/rolldown_watcher: introduce `PathsMut` to batch watch/unwatch behaviors (#6075) by @hyf0 - enable `treeshake.commonjs` by default (#6072) by @IWANABETHATGUY - dev: add debounce control and PollWatcher support to DevWatchOptions (#6070) by @hyf0 ### 🐛 Bug Fixes - use kqueue for file watch on mac (#6124) by @sapphi-red - use patched notify for better file change event debouncing (#6125) by @sapphi-red - support passing all js primitive value for `alias` plugin (#6123) by @IWANABETHATGUY - track spans in member expression properties for accurate sourcemaps (#6100) by @IWANABETHATGUY - correctly handle inlined CommonJS exports in member expressions (#6090) by @IWANABETHATGUY - dev: ensure patch file names to be unique (#6096) by @sapphi-red - dev: normalize slash on Windows before comparing paths (#6095) by @sapphi-red - dev/watch: debounce duration should default to 10 (#6078) by @hyf0 ### 🚜 Refactor - simplify `__export` runtime helper to create target object internally (#6114) by @IWANABETHATGUY - simplify module_namespace construction second try (#6118) by @IWANABETHATGUY - simplify module_namespace construction (#5939) by @IWANABETHATGUY - optimize member expression creation in AstSnippet (#6091) by @IWANABETHATGUY - test-dev-server: sensible watcher configuration for CI env (#6077) by @hyf0 ### 🧪 Testing - dev: apply HMR edits on Windows (#6094) by @sapphi-red ### ⚙️ Miscellaneous Tasks - Revert "chore: adjust breaking change template of cliff (#6069)" (#6130) by @IWANABETHATGUY - test-dev-server: improve hmr test configuration (#6115) by @hyf0 - deps: update dependency rolldown-plugin-dts to v0.16.2 (#6128) by @renovate[bot] - Revert "refactor: simplify module_namespace construction (#5939)" (#6117) by @IWANABETHATGUY - test-dev-server: optimize test log output (#6107) by @hyf0 - enable compare_contents_for_polling and update poll interval for CI test-dev-server (#6110) by @hyf0 - deps: update dependency vite to v7.1.5 [security] (#6111) by @renovate[bot] - fix warnings reported by `just lint` (#6105) by @shulaoda - deps: update dependency tsdown to v0.15.0 (#6102) by @renovate[bot] - use debug builds for browser tests in CI (#6092) by @hyf0 - test-dev-server: update polling interval and add retry logic for CI tests (#6088) by @hyf0 - adjust breaking change template of cliff (#6069) by @IWANABETHATGUY ### ◀️ Revert - "fix: replace_plugin does not work as expected with .ts config (#5920)" (#6074) by @IWANABETHATGUY Co-authored-by: Boshen <[email protected]>

github-actions bot assigned IWANABETHATGUY Sep 9, 2025

IWANABETHATGUY changed the title ~~fix: 6080~~ fix: correctly handle inlined CommonJS exports in member expressions Sep 9, 2025

IWANABETHATGUY force-pushed the 09-09-fix_6080 branch from cfa9794 to 379fcfa Compare September 9, 2025 08:37

IWANABETHATGUY marked this pull request as ready for review September 9, 2025 08:37

IWANABETHATGUY commented Sep 9, 2025

View reviewed changes

crates/rolldown/src/module_finalizers/mod.rs Show resolved Hide resolved

IWANABETHATGUY requested a review from sapphi-red September 9, 2025 08:39

IWANABETHATGUY assigned sapphi-red Sep 9, 2025

sapphi-red approved these changes Sep 9, 2025

View reviewed changes

crates/rolldown/tests/rolldown/tree_shaking/commonjs_inline_const/main.js Outdated Show resolved Hide resolved

crates/rolldown/src/module_finalizers/mod.rs Outdated Show resolved Hide resolved

IWANABETHATGUY added the graphite: merge label Sep 9, 2025

graphite-app bot pushed a commit that referenced this pull request Sep 9, 2025

fix: correctly handle inlined CommonJS exports in member expressions (#…

4876d46

…6090) Fixes #6080

graphite-app bot force-pushed the 09-09-fix_6080 branch from a394490 to 4876d46 Compare September 9, 2025 11:20

graphite-app bot removed the graphite: merge label Sep 9, 2025

IWANABETHATGUY added the graphite: merge label Sep 9, 2025

fix: correctly handle inlined CommonJS exports in member expressions (#…

25aa188

…6090) Fixes #6080

graphite-app bot force-pushed the 09-09-fix_6080 branch from 4876d46 to 25aa188 Compare September 9, 2025 11:58

graphite-app bot merged commit 25aa188 into main Sep 9, 2025
26 checks passed

graphite-app bot deleted the 09-09-fix_6080 branch September 9, 2025 12:08

graphite-app bot removed the graphite: merge label Sep 9, 2025

IWANABETHATGUY mentioned this pull request Sep 10, 2025

7.1.8 incorrectly constant folds away startsWith leading to runtime error vitejs/rolldown-vite#408

Closed

6 tasks

github-actions bot mentioned this pull request Sep 10, 2025

release: v1.0.0-beta.37 #6131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: correctly handle inlined CommonJS exports in member expressions#6090

fix: correctly handle inlined CommonJS exports in member expressions#6090
graphite-app[bot] merged 1 commit intomainfrom
09-09-fix_6080

IWANABETHATGUY commented Sep 9, 2025 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Sep 9, 2025

Uh oh!

netlify bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

IWANABETHATGUY commented Sep 9, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Sep 9, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Uh oh!

github-actions bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Uh oh!

Uh oh!

IWANABETHATGUY commented Sep 9, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Sep 9, 2025 •

edited

Loading

netlify bot commented Sep 9, 2025 •

edited

Loading

github-actions bot commented Sep 9, 2025 •

edited

Loading

IWANABETHATGUY commented Sep 9, 2025 •

edited by graphite-app bot

Loading