Skip to content

Comments

feat(dev): return changed files in onHmrUpdates callback#6086

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-09-feat_dev_return_changed_files_in_onhmrupdates_callback
Sep 9, 2025
Merged

feat(dev): return changed files in onHmrUpdates callback#6086
graphite-app[bot] merged 1 commit intomainfrom
09-09-feat_dev_return_changed_files_in_onhmrupdates_callback

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Sep 9, 2025

Added the change files in onHmrUpdates callback for logging.

refs vitejs/rolldown-vite#401

Copy link
Member Author

sapphi-red commented Sep 9, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 57d3ca5
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68bfc8202fbd500008725736

@netlify
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 8217f6a
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68bfdfb4c363e3000810839b
😎 Deploy Preview https://deploy-preview-6086--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sapphi-red sapphi-red force-pushed the 09-09-feat_dev_return_changed_files_in_onhmrupdates_callback branch from 5c70c60 to aa06291 Compare September 9, 2025 06:30
@sapphi-red sapphi-red marked this pull request as ready for review September 9, 2025 06:32
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Benchmarks Rust

  • target: main(13071dc)
  • pr: 09-09-feat_dev_return_changed_files_in_onhmrupdates_callback(8217f6a)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     88.8±2.70ms        ? ?/sec    1.04     92.0±3.64ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     98.0±3.13ms        ? ?/sec    1.10    107.8±4.02ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    126.8±3.54ms        ? ?/sec    1.04    131.7±2.50ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    147.4±2.45ms        ? ?/sec    1.03    151.5±2.73ms        ? ?/sec
bundle/bundle@threejs                                        1.00     48.4±2.62ms        ? ?/sec    1.05     50.8±2.74ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     56.1±1.03ms        ? ?/sec    1.06     59.4±1.34ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    491.4±5.91ms        ? ?/sec    1.06    519.1±8.48ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    575.3±7.41ms        ? ?/sec    1.04   596.2±10.92ms        ? ?/sec
scan/scan@rome_ts                                            1.00    100.2±2.33ms        ? ?/sec    1.03    102.7±2.99ms        ? ?/sec
scan/scan@threejs                                            1.00     35.8±2.87ms        ? ?/sec    1.01     36.1±2.00ms        ? ?/sec
scan/scan@threejs10x                                         1.00    363.5±5.42ms        ? ?/sec    1.02    369.3±5.00ms        ? ?/sec

Copy link
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're gonna have the third argument, I'll suggest to have a extraArgs instead of the third.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 9, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Sep 9, 2025
Added the change files in `onHmrUpdates` callback for logging.

refs vitejs/rolldown-vite#401
@graphite-app graphite-app bot force-pushed the 09-09-feat_dev_return_changed_files_in_onhmrupdates_callback branch from aa06291 to e81583d Compare September 9, 2025 06:53
Added the change files in `onHmrUpdates` callback for logging.

refs vitejs/rolldown-vite#401
@graphite-app graphite-app bot force-pushed the 09-09-feat_dev_return_changed_files_in_onhmrupdates_callback branch from e81583d to 8217f6a Compare September 9, 2025 08:05
@graphite-app graphite-app bot merged commit 8217f6a into main Sep 9, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 09-09-feat_dev_return_changed_files_in_onhmrupdates_callback branch September 9, 2025 08:21
Boshen added a commit that referenced this pull request Sep 10, 2025
## [1.0.0-beta.37] - 2025-09-10

### 🚀 Features

- partial align with const inline strategy with oxc in smart mode
(#6126) by @IWANABETHATGUY
- dev: use PathsMut for non-debounced RecommendedWatcher (#6120) by
@sapphi-red
- dev: return whether the build is already scheduled from
`scheduleBuildIfStale` method (#6116) by @sapphi-red
- handle errors from `BundlerBuilder#build` (#6104) by @shulaoda
- add debounceTickRate option for debounced watchers (#6113) by @hyf0
- support full build in `incrementalBuild` mode (#6098) by
@IWANABETHATGUY
- add compare_contents_for_polling option to dev watcher (#6108) by
@hyf0
- dev: add `scheduleBuildIfStale` method to DevEngine (#6087) by
@sapphi-red
- dev: return changed files in onHmrUpdates callback (#6086) by
@sapphi-red
- support function config with custom CLI arguments (#6076) by
@IWANABETHATGUY
- improve `MISSING_EXPORT` warning to suggest `type` modifier (#6085) by
@sapphi-red
- crates/rolldown_watcher: introduce `PathsMut` to batch watch/unwatch
behaviors (#6075) by @hyf0
- enable `treeshake.commonjs` by default (#6072) by @IWANABETHATGUY
- dev: add debounce control and PollWatcher support to DevWatchOptions
(#6070) by @hyf0

### 🐛 Bug Fixes

- use kqueue for file watch on mac (#6124) by @sapphi-red
- use patched notify for better file change event debouncing (#6125) by
@sapphi-red
- support passing all js primitive value for `alias` plugin (#6123) by
@IWANABETHATGUY
- track spans in member expression properties for accurate sourcemaps
(#6100) by @IWANABETHATGUY
- correctly handle inlined CommonJS exports in member expressions
(#6090) by @IWANABETHATGUY
- dev: ensure patch file names to be unique (#6096) by @sapphi-red
- dev: normalize slash on Windows before comparing paths (#6095) by
@sapphi-red
- dev/watch: debounce duration should default to 10 (#6078) by @hyf0

### 🚜 Refactor

- simplify `__export` runtime helper to create target object internally
(#6114) by @IWANABETHATGUY
- simplify module_namespace construction second try (#6118) by
@IWANABETHATGUY
- simplify module_namespace construction (#5939) by @IWANABETHATGUY
- optimize member expression creation in AstSnippet (#6091) by
@IWANABETHATGUY
- test-dev-server: sensible watcher configuration for CI env (#6077) by
@hyf0

### 🧪 Testing

- dev: apply HMR edits on Windows (#6094) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- Revert "chore: adjust breaking change template of cliff (#6069)"
(#6130) by @IWANABETHATGUY
- test-dev-server: improve hmr test configuration (#6115) by @hyf0
- deps: update dependency rolldown-plugin-dts to v0.16.2 (#6128) by
@renovate[bot]
- Revert "refactor: simplify module_namespace construction (#5939)"
(#6117) by @IWANABETHATGUY
- test-dev-server: optimize test log output (#6107) by @hyf0
- enable compare_contents_for_polling and update poll interval for CI
test-dev-server (#6110) by @hyf0
- deps: update dependency vite to v7.1.5 [security] (#6111) by
@renovate[bot]
- fix warnings reported by `just lint` (#6105) by @shulaoda
- deps: update dependency tsdown to v0.15.0 (#6102) by @renovate[bot]
- use debug builds for browser tests in CI (#6092) by @hyf0
- test-dev-server: update polling interval and add retry logic for CI
tests (#6088) by @hyf0
- adjust breaking change template of cliff (#6069) by @IWANABETHATGUY

### ◀️ Revert

- "fix: replace_plugin does not work as expected with .ts config
(#5920)" (#6074) by @IWANABETHATGUY

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants