Skip to content

Comments

refactor(test-dev-server): sensible watcher configuration for CI env#6077

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-09-refactor_test-dev-server_sensible_watcher_configuration_for_ci_env
Sep 9, 2025
Merged

refactor(test-dev-server): sensible watcher configuration for CI env#6077
graphite-app[bot] merged 1 commit intomainfrom
09-09-refactor_test-dev-server_sensible_watcher_configuration_for_ci_env

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Sep 8, 2025

It seemd that the most flaky case is multiple-edits. I suspect it's a problem of debouncing.

Copy link
Member Author

hyf0 commented Sep 8, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review September 8, 2025 16:18
@hyf0 hyf0 requested a review from shulaoda September 8, 2025 16:18
@hyf0 hyf0 force-pushed the 09-09-refactor_test-dev-server_sensible_watcher_configuration_for_ci_env branch from a730dd1 to 0a97dac Compare September 8, 2025 16:18
@hyf0 hyf0 force-pushed the 09-09-refactor_test-dev-server_sensible_watcher_configuration_for_ci_env branch from 0a97dac to 6fe5fb2 Compare September 8, 2025 16:25
@hyf0 hyf0 requested a review from sapphi-red September 9, 2025 03:22
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 9, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 09-08-feat_dev_introduce_pathsmut_to_batch_watch_unwatch_behaviors branch from 1b00aa2 to 7cd4f60 Compare September 9, 2025 03:38
graphite-app bot pushed a commit that referenced this pull request Sep 9, 2025
…6077)

It seemd that the most flaky case is `multiple-edits`. I suspect it's a problem of debouncing.
@graphite-app graphite-app bot force-pushed the 09-09-refactor_test-dev-server_sensible_watcher_configuration_for_ci_env branch from 6fe5fb2 to 1011696 Compare September 9, 2025 03:38
graphite-app bot pushed a commit that referenced this pull request Sep 9, 2025
Probably the reason of hmr tests being flaky. Anyway, we now have #6077 to explicit configurate watcher for CI>
@graphite-app graphite-app bot changed the base branch from 09-08-feat_dev_introduce_pathsmut_to_batch_watch_unwatch_behaviors to graphite-base/6077 September 9, 2025 04:58
@graphite-app graphite-app bot changed the base branch from graphite-base/6077 to main September 9, 2025 05:10
…6077)

It seemd that the most flaky case is `multiple-edits`. I suspect it's a problem of debouncing.
@graphite-app graphite-app bot force-pushed the 09-09-refactor_test-dev-server_sensible_watcher_configuration_for_ci_env branch from 1011696 to 32f34bd Compare September 9, 2025 05:11
@netlify
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 32f34bd
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68bfb7038514fb0008490ee4

graphite-app bot pushed a commit that referenced this pull request Sep 9, 2025
Probably the reason of hmr tests being flaky. Anyway, we now have #6077 to explicit configurate watcher for CI>
@graphite-app graphite-app bot merged commit 32f34bd into main Sep 9, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 09-09-refactor_test-dev-server_sensible_watcher_configuration_for_ci_env branch September 9, 2025 05:34
Boshen added a commit that referenced this pull request Sep 10, 2025
## [1.0.0-beta.37] - 2025-09-10

### 🚀 Features

- partial align with const inline strategy with oxc in smart mode
(#6126) by @IWANABETHATGUY
- dev: use PathsMut for non-debounced RecommendedWatcher (#6120) by
@sapphi-red
- dev: return whether the build is already scheduled from
`scheduleBuildIfStale` method (#6116) by @sapphi-red
- handle errors from `BundlerBuilder#build` (#6104) by @shulaoda
- add debounceTickRate option for debounced watchers (#6113) by @hyf0
- support full build in `incrementalBuild` mode (#6098) by
@IWANABETHATGUY
- add compare_contents_for_polling option to dev watcher (#6108) by
@hyf0
- dev: add `scheduleBuildIfStale` method to DevEngine (#6087) by
@sapphi-red
- dev: return changed files in onHmrUpdates callback (#6086) by
@sapphi-red
- support function config with custom CLI arguments (#6076) by
@IWANABETHATGUY
- improve `MISSING_EXPORT` warning to suggest `type` modifier (#6085) by
@sapphi-red
- crates/rolldown_watcher: introduce `PathsMut` to batch watch/unwatch
behaviors (#6075) by @hyf0
- enable `treeshake.commonjs` by default (#6072) by @IWANABETHATGUY
- dev: add debounce control and PollWatcher support to DevWatchOptions
(#6070) by @hyf0

### 🐛 Bug Fixes

- use kqueue for file watch on mac (#6124) by @sapphi-red
- use patched notify for better file change event debouncing (#6125) by
@sapphi-red
- support passing all js primitive value for `alias` plugin (#6123) by
@IWANABETHATGUY
- track spans in member expression properties for accurate sourcemaps
(#6100) by @IWANABETHATGUY
- correctly handle inlined CommonJS exports in member expressions
(#6090) by @IWANABETHATGUY
- dev: ensure patch file names to be unique (#6096) by @sapphi-red
- dev: normalize slash on Windows before comparing paths (#6095) by
@sapphi-red
- dev/watch: debounce duration should default to 10 (#6078) by @hyf0

### 🚜 Refactor

- simplify `__export` runtime helper to create target object internally
(#6114) by @IWANABETHATGUY
- simplify module_namespace construction second try (#6118) by
@IWANABETHATGUY
- simplify module_namespace construction (#5939) by @IWANABETHATGUY
- optimize member expression creation in AstSnippet (#6091) by
@IWANABETHATGUY
- test-dev-server: sensible watcher configuration for CI env (#6077) by
@hyf0

### 🧪 Testing

- dev: apply HMR edits on Windows (#6094) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- Revert "chore: adjust breaking change template of cliff (#6069)"
(#6130) by @IWANABETHATGUY
- test-dev-server: improve hmr test configuration (#6115) by @hyf0
- deps: update dependency rolldown-plugin-dts to v0.16.2 (#6128) by
@renovate[bot]
- Revert "refactor: simplify module_namespace construction (#5939)"
(#6117) by @IWANABETHATGUY
- test-dev-server: optimize test log output (#6107) by @hyf0
- enable compare_contents_for_polling and update poll interval for CI
test-dev-server (#6110) by @hyf0
- deps: update dependency vite to v7.1.5 [security] (#6111) by
@renovate[bot]
- fix warnings reported by `just lint` (#6105) by @shulaoda
- deps: update dependency tsdown to v0.15.0 (#6102) by @renovate[bot]
- use debug builds for browser tests in CI (#6092) by @hyf0
- test-dev-server: update polling interval and add retry logic for CI
tests (#6088) by @hyf0
- adjust breaking change template of cliff (#6069) by @IWANABETHATGUY

### ◀️ Revert

- "fix: replace_plugin does not work as expected with .ts config
(#5920)" (#6074) by @IWANABETHATGUY

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants