feat: enable `treeshake.commonjs` by default by IWANABETHATGUY · Pull Request #6072 · rolldown/rolldown

IWANABETHATGUY · 2025-09-08T13:49:44Z

IWANABETHATGUY · 2025-09-08T13:50:01Z

feat: enable treeshake.commonjs by default #6072 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-09-08T13:50:09Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`2ca48b4`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68bfa5958476f50008239684

crates/rolldown/tests/esbuild/importstar/export_other_common_js/artifacts.snap

crates/rolldown/tests/esbuild/importstar/export_other_nested_common_js/artifacts.snap

...en_esm_and_cjs/esm_import_esm_which_export_all_from_multiple_cjs_named_import/artifacts.snap

IWANABETHATGUY · 2025-09-08T14:03:14Z

I marked the feature as a breaking change, since it may reduce some unnecessary cjs export for a pure rolldown user.

github-actions · 2025-09-08T14:08:35Z

Benchmarks Rust

target: main(202427e)
pr: 09-08-feat_enable_treeshake.commonjs_by_default(2ca48b4)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     91.6±2.85ms        ? ?/sec    1.00     91.9±5.49ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00    101.8±2.76ms        ? ?/sec    1.01    102.4±3.01ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    128.8±3.42ms        ? ?/sec    1.00    128.6±2.43ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    149.2±3.12ms        ? ?/sec    1.00    148.3±2.50ms        ? ?/sec
bundle/bundle@threejs                                        1.00     48.8±2.29ms        ? ?/sec    1.00     48.6±2.49ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     57.6±1.70ms        ? ?/sec    1.00     56.8±1.43ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    500.3±6.10ms        ? ?/sec    1.00    501.4±7.36ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    578.6±8.71ms        ? ?/sec    1.00    578.0±5.48ms        ? ?/sec
scan/scan@rome_ts                                            1.00     98.1±1.82ms        ? ?/sec    1.01     98.9±1.80ms        ? ?/sec
scan/scan@threejs                                            1.00     35.0±0.51ms        ? ?/sec    1.00     35.2±0.58ms        ? ?/sec
scan/scan@threejs10x                                         1.00    363.1±3.76ms        ? ?/sec    1.00    363.7±3.60ms        ? ?/sec

sapphi-red · 2025-09-09T01:17:58Z

This comment is stale.

rolldown/crates/rolldown_binding/src/options/binding_input_options/binding_treeshake.rs

Line 109 in c910a23

// By default disable commonjs tree shake, since it is not stable

sapphi-red · 2025-09-09T01:19:32Z

I marked the feature as a breaking change, since it may reduce some unnecessary cjs export for a pure rolldown user.

I don't think this is a breaking change. When would reducing unnecessary cjs export be a problem?

IWANABETHATGUY · 2025-09-09T03:32:51Z

I marked the feature as a breaking change, since it may reduce some unnecessary cjs export for a pure rolldown user.

I don't think this is a breaking change. When would reducing unnecessary cjs export be a problem?

I still don't have a clear definition for breaking change, so I make it more conservative, now I removed the breaking change flag in title.

sapphi-red · 2025-09-09T03:42:08Z

I marked the feature as a breaking change, since it may reduce some unnecessary cjs export for a pure rolldown user.

I don't think this is a breaking change. When would reducing unnecessary cjs export be a problem?

I still don't have a clear definition for breaking change, so I make it more conservative, now I removed the breaking change flag in title.

I think it is whether the user has to do something when this change is included. In this case, this should be a transparent optimization (assuming there's no bug), so I think it's fine to not mark it as an breaking change. If there's a code that relies on the fact that the value of treeshake.commonjs is false by default, it would break. But I think that wouldn't happen. In most cases, changing the default value is a breaking change because the semantics changes though.

IWANABETHATGUY · 2025-09-09T03:48:29Z

Merge activity

Sep 9, 3:48 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 9, 3:48 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Sep 9, 4:21 AM UTC: Merged by the Graphite merge queue.

Closed #6064

@IWANABETHATGUY

## [1.0.0-beta.37] - 2025-09-10 ### 🚀 Features - partial align with const inline strategy with oxc in smart mode (#6126) by @IWANABETHATGUY - dev: use PathsMut for non-debounced RecommendedWatcher (#6120) by @sapphi-red - dev: return whether the build is already scheduled from `scheduleBuildIfStale` method (#6116) by @sapphi-red - handle errors from `BundlerBuilder#build` (#6104) by @shulaoda - add debounceTickRate option for debounced watchers (#6113) by @hyf0 - support full build in `incrementalBuild` mode (#6098) by @IWANABETHATGUY - add compare_contents_for_polling option to dev watcher (#6108) by @hyf0 - dev: add `scheduleBuildIfStale` method to DevEngine (#6087) by @sapphi-red - dev: return changed files in onHmrUpdates callback (#6086) by @sapphi-red - support function config with custom CLI arguments (#6076) by @IWANABETHATGUY - improve `MISSING_EXPORT` warning to suggest `type` modifier (#6085) by @sapphi-red - crates/rolldown_watcher: introduce `PathsMut` to batch watch/unwatch behaviors (#6075) by @hyf0 - enable `treeshake.commonjs` by default (#6072) by @IWANABETHATGUY - dev: add debounce control and PollWatcher support to DevWatchOptions (#6070) by @hyf0 ### 🐛 Bug Fixes - use kqueue for file watch on mac (#6124) by @sapphi-red - use patched notify for better file change event debouncing (#6125) by @sapphi-red - support passing all js primitive value for `alias` plugin (#6123) by @IWANABETHATGUY - track spans in member expression properties for accurate sourcemaps (#6100) by @IWANABETHATGUY - correctly handle inlined CommonJS exports in member expressions (#6090) by @IWANABETHATGUY - dev: ensure patch file names to be unique (#6096) by @sapphi-red - dev: normalize slash on Windows before comparing paths (#6095) by @sapphi-red - dev/watch: debounce duration should default to 10 (#6078) by @hyf0 ### 🚜 Refactor - simplify `__export` runtime helper to create target object internally (#6114) by @IWANABETHATGUY - simplify module_namespace construction second try (#6118) by @IWANABETHATGUY - simplify module_namespace construction (#5939) by @IWANABETHATGUY - optimize member expression creation in AstSnippet (#6091) by @IWANABETHATGUY - test-dev-server: sensible watcher configuration for CI env (#6077) by @hyf0 ### 🧪 Testing - dev: apply HMR edits on Windows (#6094) by @sapphi-red ### ⚙️ Miscellaneous Tasks - Revert "chore: adjust breaking change template of cliff (#6069)" (#6130) by @IWANABETHATGUY - test-dev-server: improve hmr test configuration (#6115) by @hyf0 - deps: update dependency rolldown-plugin-dts to v0.16.2 (#6128) by @renovate[bot] - Revert "refactor: simplify module_namespace construction (#5939)" (#6117) by @IWANABETHATGUY - test-dev-server: optimize test log output (#6107) by @hyf0 - enable compare_contents_for_polling and update poll interval for CI test-dev-server (#6110) by @hyf0 - deps: update dependency vite to v7.1.5 [security] (#6111) by @renovate[bot] - fix warnings reported by `just lint` (#6105) by @shulaoda - deps: update dependency tsdown to v0.15.0 (#6102) by @renovate[bot] - use debug builds for browser tests in CI (#6092) by @hyf0 - test-dev-server: update polling interval and add retry logic for CI tests (#6088) by @hyf0 - adjust breaking change template of cliff (#6069) by @IWANABETHATGUY ### ◀️ Revert - "fix: replace_plugin does not work as expected with .ts config (#5920)" (#6074) by @IWANABETHATGUY Co-authored-by: Boshen <[email protected]>

github-actions bot assigned IWANABETHATGUY Sep 8, 2025

IWANABETHATGUY marked this pull request as ready for review September 8, 2025 13:50

IWANABETHATGUY force-pushed the 09-08-feat_enable_treeshake.commonjs_by_default branch from c0dd0ef to 6658ff5 Compare September 8, 2025 13:52

IWANABETHATGUY commented Sep 8, 2025

View reviewed changes

crates/rolldown/tests/esbuild/importstar/export_other_common_js/artifacts.snap Show resolved Hide resolved

IWANABETHATGUY commented Sep 8, 2025

View reviewed changes

crates/rolldown/tests/esbuild/importstar/export_other_nested_common_js/artifacts.snap Show resolved Hide resolved

...en_esm_and_cjs/esm_import_esm_which_export_all_from_multiple_cjs_named_import/artifacts.snap Show resolved Hide resolved

IWANABETHATGUY assigned sapphi-red Sep 8, 2025

IWANABETHATGUY changed the title ~~feat: enable treeshake.commonjs by default~~ feat!: enable treeshake.commonjs by default Sep 8, 2025

IWANABETHATGUY changed the title ~~feat!: enable treeshake.commonjs by default~~ feat: enable treeshake.commonjs by default Sep 9, 2025

IWANABETHATGUY requested a review from sapphi-red September 9, 2025 03:33

IWANABETHATGUY force-pushed the 09-08-feat_enable_treeshake.commonjs_by_default branch from 3dd1948 to eeff439 Compare September 9, 2025 03:33

sapphi-red approved these changes Sep 9, 2025

View reviewed changes

IWANABETHATGUY added the graphite: merge label Sep 9, 2025

feat: enable treeshake.commonjs by default (#6072)

2ca48b4

Closed #6064

graphite-app bot force-pushed the 09-08-feat_enable_treeshake.commonjs_by_default branch from eeff439 to 2ca48b4 Compare September 9, 2025 03:57

graphite-app bot merged commit 2ca48b4 into main Sep 9, 2025
26 checks passed

graphite-app bot deleted the 09-08-feat_enable_treeshake.commonjs_by_default branch September 9, 2025 04:21

graphite-app bot removed the graphite: merge label Sep 9, 2025

github-actions bot mentioned this pull request Sep 10, 2025

release: v1.0.0-beta.37 #6131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: enable `treeshake.commonjs` by default#6072

feat: enable `treeshake.commonjs` by default#6072
graphite-app[bot] merged 1 commit intomainfrom
09-08-feat_enable_treeshake.commonjs_by_default

IWANABETHATGUY commented Sep 8, 2025 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Sep 8, 2025

Uh oh!

netlify bot commented Sep 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IWANABETHATGUY commented Sep 8, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 8, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Sep 9, 2025

Uh oh!

sapphi-red commented Sep 9, 2025

Uh oh!

IWANABETHATGUY commented Sep 9, 2025

Uh oh!

sapphi-red commented Sep 9, 2025

Uh oh!

IWANABETHATGUY commented Sep 9, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Sep 8, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IWANABETHATGUY commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

sapphi-red commented Sep 9, 2025

Uh oh!

sapphi-red commented Sep 9, 2025

Uh oh!

IWANABETHATGUY commented Sep 9, 2025

Uh oh!

sapphi-red commented Sep 9, 2025

Uh oh!

IWANABETHATGUY commented Sep 9, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Sep 8, 2025 •

edited

Loading

netlify bot commented Sep 8, 2025 •

edited

Loading

IWANABETHATGUY commented Sep 8, 2025 •

edited

Loading

github-actions bot commented Sep 8, 2025 •

edited

Loading

IWANABETHATGUY commented Sep 9, 2025 •

edited by graphite-app bot

Loading