Skip to content

Comments

refactor: unify to use is_in_node_modules from rolldown_plugin_utils#6066

Merged
shulaoda merged 1 commit intomainfrom
09-08-refactor_unify_to_use_is_in_node_modules_from_rolldown_plugin_utils
Sep 8, 2025
Merged

refactor: unify to use is_in_node_modules from rolldown_plugin_utils#6066
shulaoda merged 1 commit intomainfrom
09-08-refactor_unify_to_use_is_in_node_modules_from_rolldown_plugin_utils

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Sep 8, 2025

No description provided.

This was referenced Sep 8, 2025
Merged
Merged
@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Sep 8, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the title refactor: unify to use is_in_node_modules from rolldown_plugin_utils refactor: unify to use is_in_node_modules from rolldown_plugin_utils Sep 8, 2025
@shulaoda shulaoda marked this pull request as ready for review September 8, 2025 09:01
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(7fa31d9)
  • pr: 09-08-refactor_unify_to_use_is_in_node_modules_from_rolldown_plugin_utils(ded055e)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     78.8±1.97ms        ? ?/sec    1.01     79.2±1.88ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     89.1±1.82ms        ? ?/sec    1.01     89.7±1.98ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    117.9±1.52ms        ? ?/sec    1.01    119.6±2.28ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    139.4±3.13ms        ? ?/sec    1.00    139.4±1.65ms        ? ?/sec
bundle/bundle@threejs                                        1.00     44.4±1.83ms        ? ?/sec    1.02     45.1±0.78ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     52.9±0.69ms        ? ?/sec    1.03     54.3±1.66ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    465.4±5.86ms        ? ?/sec    1.00    465.9±4.68ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    546.4±8.47ms        ? ?/sec    1.00    545.5±3.98ms        ? ?/sec
scan/scan@rome_ts                                            1.00     96.0±1.87ms        ? ?/sec    1.01     96.8±4.15ms        ? ?/sec
scan/scan@threejs                                            1.00     33.6±0.52ms        ? ?/sec    1.01     33.9±0.98ms        ? ?/sec
scan/scan@threejs10x                                         1.00    350.1±4.29ms        ? ?/sec    1.00    349.2±4.41ms        ? ?/sec

Base automatically changed from 09-08-feat_rolldown_plugin_reporter_statically_imported_dynamic_import_warning to main September 8, 2025 10:09
@shulaoda shulaoda force-pushed the 09-08-refactor_unify_to_use_is_in_node_modules_from_rolldown_plugin_utils branch from 7ca487a to ded055e Compare September 8, 2025 10:30
@netlify
Copy link

netlify bot commented Sep 8, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit ded055e
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68beb0596f47760008fa5a74

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Sep 8, 2025 •
edited
Loading

Merge activity

  • Sep 8, 10:31 AM UTC: Graphite rebased this pull request as part of a merge.
  • Sep 8, 10:34 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 8, 11:05 AM UTC: @shulaoda merged this pull request with Graphite.

@shulaoda shulaoda merged commit 139191d into main Sep 8, 2025
32 checks passed
@shulaoda shulaoda deleted the 09-08-refactor_unify_to_use_is_in_node_modules_from_rolldown_plugin_utils branch September 8, 2025 11:05
@github-actions github-actions bot mentioned this pull request Sep 8, 2025
Merged
shulaoda added a commit that referenced this pull request Sep 8, 2025
@github-actions @shulaoda
release: v1.0.0-beta.36 (#6068)
03b7b72 
## [1.0.0-beta.36] - 2025-09-08
> [!warning]
> ### 💥 BREAKING CHANGES
> 
> - drop CJS format, increase minimum required node (#6025) by @sxzz


### 🚀 Features

- rolldown_plugin_reporter: statically imported dynamic import warning (#6065) by @shulaoda
- rolldown_plugin_reporter: warn large chunks (#6063) by @shulaoda
- rolldown: oxc v0.87.0 (#5975) by @Boshen

### 🐛 Bug Fixes

- allow keeping whitespace while enabling minify (#5893) by @sapphi-red
- dev/watch: build connection between file in `this.addWatchFile` and currently transformed module during transform hook (#6048) by @hyf0
- validator of `output.minify` (#6062) by @IWANABETHATGUY
- codspeed rust benchmark ci (#6052) by @IWANABETHATGUY
- just command in ci (#6045) by @IWANABETHATGUY
- watch: only consider files read from disk are able to watch (#6037) by @hyf0

### 🚜 Refactor

- dev: introduce `DevWatchOptions` for enhanced file watching configuration (#6057) by @hyf0
- unify to use `is_in_node_modules` from `rolldown_plugin_utils` (#6066) by @shulaoda

### 🧪 Testing

- rust: ensure unused pure function call got treeshaked (#4524) by @hyf0
- hmr: tweak improper test (#6034) by @hyf0
- hmr: add test of editing multiple files in the same timeframe (#6029) by @hyf0
- hmr: support to edit multiple files in the same timeframe (#6014) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance rust crates (#6003) by @renovate[bot]
- deps: lock file maintenance npm packages (#5995) by @renovate[bot]
- add auto-assign PR workflow for organization members (#6058) by @IWANABETHATGUY
- fix benchmark-node workflow (#6060) by @IWANABETHATGUY
- adding `test-node-rolldown-only` just command (#6055) by @IWANABETHATGUY
- just commands in ci (#6056) by @IWANABETHATGUY
- run test ci when `justfile` is changed (#6049) by @IWANABETHATGUY
- remove unused warning for conditional compiled`SimplifyMinifyOptions` (#6047) by @IWANABETHATGUY
- remove auto approval ci (#6051) by @IWANABETHATGUY
- adding rustfmt components for `repo-validation` (#6053) by @IWANABETHATGUY
- repo: check format/style in `just lint-rust` (#6050) by @hyf0
- repo/ai: refine `justfile` (#6038) by @hyf0
- repo/ai: add `AGENTS.md` and `CLAUDE.md` (#6039) by @hyf0
- deps: update github-actions (major) (#6041) by @renovate[bot]
- deps: update github-actions (#6040) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.1 (#6035) by @renovate[bot]

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shulaoda @IWANABETHATGUY @sapphi-red @hyf0