refactor(dev): introduce DevWatchOptions for enhanced file watching configuration#6059
Conversation
…onfiguration
Moves watcher-related options (usePolling, pollInterval) from DevOptions
into a standalone DevWatchOptions struct/interface, providing better
organization and type safety for file watching configuration.
Changes:
- Create DevWatchOptions struct with optional usePolling and pollInterval fields
- Update DevOptions to include optional watch field of type DevWatchOptions
- Maintain backward compatibility in normalized options structure
- Update TypeScript API, NAPI bindings, and Rust core layers
- Add proper exports for new types in experimental index
- Update integration points and conversion logic
- Remove redundant exports from dev/index.ts to fix linting
This change enables cleaner API usage:
```typescript
const devEngine = await dev(input, output, {
onHmrUpdates: (updates) => console.log(updates),
watch: {
usePolling: true,
pollInterval: 500
}
});
```
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label graphite: merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
hyf0
changed the base branch from
09-08-refactor_dev_introduce_devwatchoptions_for_enhanced_file_watching_configuration
to
graphite-base/6059
Member
Author
|
Closing this PR as the changes have been folded into the original PR #6057 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves watcher-related options (usePolling, pollInterval) from DevOptions
into a standalone DevWatchOptions struct/interface, providing better
organization and type safety for file watching configuration.
Changes:
This change enables cleaner API usage:
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]