Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Benchmarks Rust
|
hyf0
force-pushed
the
09-08-refactor_dev_introduce_devwatchoptions_for_enhanced_file_watching_configuration
branch
2 times, most recently
from
52aaeb3 to
526a681
Compare
Contributor
Merge activity
|
hyf0
force-pushed
the
09-08-refactor_dev_introduce_devwatchoptions_for_enhanced_file_watching_configuration
branch
from
526a681 to
9a254c3
Compare
shulaoda
approved these changes
Sep 8, 2025
…onfiguration
Moves watcher-related options (usePolling, pollInterval) from DevOptions
into a standalone DevWatchOptions struct/interface, providing better
organization and type safety for file watching configuration.
Changes:
- Create DevWatchOptions struct with optional usePolling and pollInterval fields
- Update DevOptions to include optional watch field of type DevWatchOptions
- Maintain backward compatibility in normalized options structure
- Update TypeScript API, NAPI bindings, and Rust core layers
- Add proper exports for new types in experimental index
- Update integration points and conversion logic
- Remove redundant exports from dev/index.ts to fix linting
This change enables cleaner API usage:
```typescript
const devEngine = await dev(input, output, {
onHmrUpdates: (updates) => console.log(updates),
watch: {
usePolling: true,
pollInterval: 500
}
});
```
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
hyf0
force-pushed
the
09-08-refactor_dev_introduce_devwatchoptions_for_enhanced_file_watching_configuration
branch
from
9a254c3 to
c7069ec
Compare
shulaoda
deleted the
09-08-refactor_dev_introduce_devwatchoptions_for_enhanced_file_watching_configuration
branch
shulaoda
added a commit
that referenced
this pull request
Sep 8, 2025
## [1.0.0-beta.36] - 2025-09-08 > [!warning] > ### 💥 BREAKING CHANGES > > - drop CJS format, increase minimum required node (#6025) by @sxzz ### 🚀 Features - rolldown_plugin_reporter: statically imported dynamic import warning (#6065) by @shulaoda - rolldown_plugin_reporter: warn large chunks (#6063) by @shulaoda - rolldown: oxc v0.87.0 (#5975) by @Boshen ### 🐛 Bug Fixes - allow keeping whitespace while enabling minify (#5893) by @sapphi-red - dev/watch: build connection between file in `this.addWatchFile` and currently transformed module during transform hook (#6048) by @hyf0 - validator of `output.minify` (#6062) by @IWANABETHATGUY - codspeed rust benchmark ci (#6052) by @IWANABETHATGUY - just command in ci (#6045) by @IWANABETHATGUY - watch: only consider files read from disk are able to watch (#6037) by @hyf0 ### 🚜 Refactor - dev: introduce `DevWatchOptions` for enhanced file watching configuration (#6057) by @hyf0 - unify to use `is_in_node_modules` from `rolldown_plugin_utils` (#6066) by @shulaoda ### 🧪 Testing - rust: ensure unused pure function call got treeshaked (#4524) by @hyf0 - hmr: tweak improper test (#6034) by @hyf0 - hmr: add test of editing multiple files in the same timeframe (#6029) by @hyf0 - hmr: support to edit multiple files in the same timeframe (#6014) by @hyf0 ### ⚙️ Miscellaneous Tasks - deps: lock file maintenance rust crates (#6003) by @renovate[bot] - deps: lock file maintenance npm packages (#5995) by @renovate[bot] - add auto-assign PR workflow for organization members (#6058) by @IWANABETHATGUY - fix benchmark-node workflow (#6060) by @IWANABETHATGUY - adding `test-node-rolldown-only` just command (#6055) by @IWANABETHATGUY - just commands in ci (#6056) by @IWANABETHATGUY - run test ci when `justfile` is changed (#6049) by @IWANABETHATGUY - remove unused warning for conditional compiled`SimplifyMinifyOptions` (#6047) by @IWANABETHATGUY - remove auto approval ci (#6051) by @IWANABETHATGUY - adding rustfmt components for `repo-validation` (#6053) by @IWANABETHATGUY - repo: check format/style in `just lint-rust` (#6050) by @hyf0 - repo/ai: refine `justfile` (#6038) by @hyf0 - repo/ai: add `AGENTS.md` and `CLAUDE.md` (#6039) by @hyf0 - deps: update github-actions (major) (#6041) by @renovate[bot] - deps: update github-actions (#6040) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.16.1 (#6035) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gonna have more options about watch. Better to split a separate options.