fix(dev/watch): build connection between file in `this.addWatchFile` and currently transformed module during transform hook by hyf0 · Pull Request #6048 · rolldown/rolldown

hyf0 · 2025-09-08T04:01:29Z

This fix doesn't cover the watch() API. Ref: #5220

hyf0 · 2025-09-08T04:01:47Z

fix(dev/watch): build connection between file in this.addWatchFile and currently transformed module during transform hook #6048 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

socket-security · 2025-09-08T04:01:54Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
@types/semver@7.7.1 ⏵ 7.7.0
@types/react-dom@19.1.9 ⏵ 19.1.7			⁺²
@vueuse/core@13.9.0 ⏵ 13.7.0			^-2
@babel/core@7.28.4 ⏵ 7.28.3
@types/react@19.1.12 ⏵ 19.1.11		⁺¹	⁺²
oxlint@1.14.0 ⏵ 1.13.0			^-1
emnapi@1.5.0 ⏵ 1.4.5	⁺¹		^-4
dedent@1.7.0 ⏵ 1.6.0
mocha@11.7.2 ⏵ 11.7.1	⁺¹	⁺¹	^-5
lint-staged@16.1.6 ⏵ 16.1.5			^-1
knip@5.63.1 ⏵ 5.63.0			^-2
rollup@4.50.1 ⏵ 4.48.0	⁺¹		⁺¹

View full report

netlify · 2025-09-08T04:02:30Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`9b8fad7`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68be551c36b6b900086a86c7
😎 Deploy Preview	https://deploy-preview-6048--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-09-08T04:04:13Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`e858c28`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68be553dc8d81500087f4f1d
😎 Deploy Preview	https://deploy-preview-6048--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-09-08T04:04:58Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`776a4ea`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68be557b6f7f0c00087ce2ab
😎 Deploy Preview	https://deploy-preview-6048--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-09-08T04:05:50Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`f2c90e1`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68bebeabe67e0800076eb498
😎 Deploy Preview	https://deploy-preview-6048--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2025-09-08T04:21:17Z

Benchmarks Rust

target: main(139191d)
pr: 09-08-fix_dev_watch_build_connection_between_file_in_this.addwatchfile_and_currently_transformed_module_during_transform_hook(f2c90e1)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.04     87.8±2.54ms        ? ?/sec    1.00     84.8±2.70ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.06     99.2±2.78ms        ? ?/sec    1.00     93.8±2.23ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    122.5±3.87ms        ? ?/sec    1.00    121.8±1.80ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.03    146.5±2.99ms        ? ?/sec    1.00    142.6±2.43ms        ? ?/sec
bundle/bundle@threejs                                        1.01     47.2±2.64ms        ? ?/sec    1.00     46.9±1.45ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.03     56.3±1.19ms        ? ?/sec    1.00     54.9±1.10ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02    484.5±8.41ms        ? ?/sec    1.00    476.9±5.89ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    565.9±8.51ms        ? ?/sec    1.00    557.4±4.49ms        ? ?/sec
scan/scan@rome_ts                                            1.00     98.6±2.04ms        ? ?/sec    1.01     99.1±1.63ms        ? ?/sec
scan/scan@threejs                                            1.00     35.3±2.00ms        ? ?/sec    1.01     35.6±2.11ms        ? ?/sec
scan/scan@threejs10x                                         1.00    364.1±4.62ms        ? ?/sec    1.00    364.5±8.76ms        ? ?/sec

crates/rolldown_binding/src/binding_bundler_impl.rs

packages/test-dev-server/tests/fixtures/transform-dependencies/dev.config.mjs

…and currently transformed module during transform hook (#6048) This fix doesn't cover the `watch()` API

sapphi-red · 2025-09-08T10:33:25Z

Merge activity

Sep 8, 10:33 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 8, 11:11 AM UTC: sapphi-red added this pull request to the Graphite merge queue.

…and currently transformed module during transform hook (#6048) This fix doesn't cover the `watch()` API

@sxzz

## [1.0.0-beta.36] - 2025-09-08 > [!warning] > ### 💥 BREAKING CHANGES > > - drop CJS format, increase minimum required node (#6025) by @sxzz ### 🚀 Features - rolldown_plugin_reporter: statically imported dynamic import warning (#6065) by @shulaoda - rolldown_plugin_reporter: warn large chunks (#6063) by @shulaoda - rolldown: oxc v0.87.0 (#5975) by @Boshen ### 🐛 Bug Fixes - allow keeping whitespace while enabling minify (#5893) by @sapphi-red - dev/watch: build connection between file in `this.addWatchFile` and currently transformed module during transform hook (#6048) by @hyf0 - validator of `output.minify` (#6062) by @IWANABETHATGUY - codspeed rust benchmark ci (#6052) by @IWANABETHATGUY - just command in ci (#6045) by @IWANABETHATGUY - watch: only consider files read from disk are able to watch (#6037) by @hyf0 ### 🚜 Refactor - dev: introduce `DevWatchOptions` for enhanced file watching configuration (#6057) by @hyf0 - unify to use `is_in_node_modules` from `rolldown_plugin_utils` (#6066) by @shulaoda ### 🧪 Testing - rust: ensure unused pure function call got treeshaked (#4524) by @hyf0 - hmr: tweak improper test (#6034) by @hyf0 - hmr: add test of editing multiple files in the same timeframe (#6029) by @hyf0 - hmr: support to edit multiple files in the same timeframe (#6014) by @hyf0 ### ⚙️ Miscellaneous Tasks - deps: lock file maintenance rust crates (#6003) by @renovate[bot] - deps: lock file maintenance npm packages (#5995) by @renovate[bot] - add auto-assign PR workflow for organization members (#6058) by @IWANABETHATGUY - fix benchmark-node workflow (#6060) by @IWANABETHATGUY - adding `test-node-rolldown-only` just command (#6055) by @IWANABETHATGUY - just commands in ci (#6056) by @IWANABETHATGUY - run test ci when `justfile` is changed (#6049) by @IWANABETHATGUY - remove unused warning for conditional compiled`SimplifyMinifyOptions` (#6047) by @IWANABETHATGUY - remove auto approval ci (#6051) by @IWANABETHATGUY - adding rustfmt components for `repo-validation` (#6053) by @IWANABETHATGUY - repo: check format/style in `just lint-rust` (#6050) by @hyf0 - repo/ai: refine `justfile` (#6038) by @hyf0 - repo/ai: add `AGENTS.md` and `CLAUDE.md` (#6039) by @hyf0 - deps: update github-actions (major) (#6041) by @renovate[bot] - deps: update github-actions (#6040) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.16.1 (#6035) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

hyf0 marked this pull request as ready for review September 8, 2025 04:02

hyf0 force-pushed the 09-08-fix_dev_watch_build_connection_between_file_in_this.addwatchfile_and_currently_transformed_module_during_transform_hook branch from e858c28 to 776a4ea Compare September 8, 2025 04:03

hyf0 force-pushed the 09-08-fix_dev_watch_build_connection_between_file_in_this.addwatchfile_and_currently_transformed_module_during_transform_hook branch from 776a4ea to ffb5262 Compare September 8, 2025 04:04

hyf0 assigned sapphi-red Sep 8, 2025

sapphi-red reviewed Sep 8, 2025

View reviewed changes

crates/rolldown_binding/src/binding_bundler_impl.rs Outdated Show resolved Hide resolved

packages/test-dev-server/tests/fixtures/transform-dependencies/dev.config.mjs Show resolved Hide resolved

hyf0 force-pushed the 09-08-fix_dev_watch_build_connection_between_file_in_this.addwatchfile_and_currently_transformed_module_during_transform_hook branch 2 times, most recently from 7fcd75e to 808d096 Compare September 8, 2025 04:58

sapphi-red approved these changes Sep 8, 2025

View reviewed changes

sapphi-red added this pull request to the merge queue Sep 8, 2025

github-merge-queue bot pushed a commit that referenced this pull request Sep 8, 2025

fix(dev/watch): build connection between file in this.addWatchFile …

f279a2a

…and currently transformed module during transform hook (#6048) This fix doesn't cover the `watch()` API

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 8, 2025

sapphi-red added this pull request to the merge queue Sep 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 8, 2025

sapphi-red added this pull request to the merge queue Sep 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 8, 2025

sapphi-red force-pushed the 09-08-fix_dev_watch_build_connection_between_file_in_this.addwatchfile_and_currently_transformed_module_during_transform_hook branch from 808d096 to 5acb6fc Compare September 8, 2025 10:04

sapphi-red added the graphite: merge label Sep 8, 2025 — with Graphite App

hyf0 force-pushed the 09-08-fix_dev_watch_build_connection_between_file_in_this.addwatchfile_and_currently_transformed_module_during_transform_hook branch from 5acb6fc to 2603a35 Compare September 8, 2025 10:36

fix(dev/watch): build connection between file in this.addWatchFile …

f2c90e1

…and currently transformed module during transform hook (#6048) This fix doesn't cover the `watch()` API

graphite-app bot force-pushed the 09-08-fix_dev_watch_build_connection_between_file_in_this.addwatchfile_and_currently_transformed_module_during_transform_hook branch from 2603a35 to f2c90e1 Compare September 8, 2025 11:31

shulaoda merged commit 377130a into main Sep 8, 2025
26 checks passed

shulaoda deleted the 09-08-fix_dev_watch_build_connection_between_file_in_this.addwatchfile_and_currently_transformed_module_during_transform_hook branch September 8, 2025 11:43

graphite-app bot removed the graphite: merge label Sep 8, 2025

github-actions bot mentioned this pull request Sep 8, 2025

release: v1.0.0-beta.36 #6068

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix(dev/watch): build connection between file in `this.addWatchFile` and currently transformed module during transform hook#6048

fix(dev/watch): build connection between file in `this.addWatchFile` and currently transformed module during transform hook#6048
shulaoda merged 1 commit intomainfrom
09-08-fix_dev_watch_build_connection_between_file_in_this.addwatchfile_and_currently_transformed_module_during_transform_hook

hyf0 commented Sep 8, 2025 •

edited

Loading

Uh oh!

hyf0 commented Sep 8, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Sep 8, 2025 •

edited

Loading

Uh oh!

netlify bot commented Sep 8, 2025

Uh oh!

netlify bot commented Sep 8, 2025

Uh oh!

netlify bot commented Sep 8, 2025

Uh oh!

netlify bot commented Sep 8, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sapphi-red commented Sep 8, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

hyf0 commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hyf0 commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

socket-security bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Sep 8, 2025

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

netlify bot commented Sep 8, 2025

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

netlify bot commented Sep 8, 2025

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

netlify bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

github-actions bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sapphi-red commented Sep 8, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hyf0 commented Sep 8, 2025 •

edited

Loading

hyf0 commented Sep 8, 2025 •

edited

Loading

socket-security bot commented Sep 8, 2025 •

edited

Loading

netlify bot commented Sep 8, 2025 •

edited

Loading

github-actions bot commented Sep 8, 2025 •

edited

Loading

sapphi-red commented Sep 8, 2025 •

edited by graphite-app bot

Loading