Skip to content

Comments

feat!: drop CJS format, increase minimum required node#6025

Merged
IWANABETHATGUY merged 4 commits intomainfrom
feat/drop-cjs
Sep 5, 2025
Merged

feat!: drop CJS format, increase minimum required node#6025
IWANABETHATGUY merged 4 commits intomainfrom
feat/drop-cjs

Conversation

@sxzz
Copy link
Member

@sxzz sxzz commented Sep 5, 2025 •
edited
Loading

  • Drop CJS format
  • Sync minimum required node version to Vite's (20.19+, 22.12+, require(esm)).

closes #5941

@sxzz sxzz changed the title feat!: drop CJS feat!: drop CJS format, increase minimum required node Sep 5, 2025
@sxzz sxzz marked this pull request as draft September 5, 2025 02:56
@netlify
Copy link

netlify bot commented Sep 5, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 02ce71a
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68ba7544868d8400085f18a6
😎 Deploy Preview https://deploy-preview-6025--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 5, 2025

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@6025

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@6025

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@6025

rolldown

npm i https://pkg.pr.new/rolldown@6025

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@6025

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@6025

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@6025

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@6025

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@6025

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@6025

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@6025

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@6025

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@6025

@rolldown/binding-openharmony-arm64

npm i https://pkg.pr.new/@rolldown/binding-openharmony-arm64@6025

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@6025

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@6025

@rolldown/binding-win32-ia32-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-ia32-msvc@6025

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@6025

commit: 03070a7

@TheAlexLichter TheAlexLichter mentioned this pull request Sep 5, 2025
Closed
@sxzz sxzz marked this pull request as ready for review September 5, 2025 03:19
@sxzz sxzz requested review from IWANABETHATGUY and hyf0 September 5, 2025 04:47
hyf0
hyf0 reviewed Sep 5, 2025
View reviewed changes
sxzz
sxzz commented Sep 5, 2025
View reviewed changes
This was referenced Sep 5, 2025
Closed
Closed
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit f418b19 Sep 5, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the feat/drop-cjs branch September 5, 2025 15:44
@github-actions github-actions bot mentioned this pull request Sep 8, 2025
Merged
shulaoda added a commit that referenced this pull request Sep 8, 2025
@github-actions @shulaoda
release: v1.0.0-beta.36 (#6068)
03b7b72 
## [1.0.0-beta.36] - 2025-09-08
> [!warning]
> ### 💥 BREAKING CHANGES
> 
> - drop CJS format, increase minimum required node (#6025) by @sxzz


### 🚀 Features

- rolldown_plugin_reporter: statically imported dynamic import warning (#6065) by @shulaoda
- rolldown_plugin_reporter: warn large chunks (#6063) by @shulaoda
- rolldown: oxc v0.87.0 (#5975) by @Boshen

### 🐛 Bug Fixes

- allow keeping whitespace while enabling minify (#5893) by @sapphi-red
- dev/watch: build connection between file in `this.addWatchFile` and currently transformed module during transform hook (#6048) by @hyf0
- validator of `output.minify` (#6062) by @IWANABETHATGUY
- codspeed rust benchmark ci (#6052) by @IWANABETHATGUY
- just command in ci (#6045) by @IWANABETHATGUY
- watch: only consider files read from disk are able to watch (#6037) by @hyf0

### 🚜 Refactor

- dev: introduce `DevWatchOptions` for enhanced file watching configuration (#6057) by @hyf0
- unify to use `is_in_node_modules` from `rolldown_plugin_utils` (#6066) by @shulaoda

### 🧪 Testing

- rust: ensure unused pure function call got treeshaked (#4524) by @hyf0
- hmr: tweak improper test (#6034) by @hyf0
- hmr: add test of editing multiple files in the same timeframe (#6029) by @hyf0
- hmr: support to edit multiple files in the same timeframe (#6014) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance rust crates (#6003) by @renovate[bot]
- deps: lock file maintenance npm packages (#5995) by @renovate[bot]
- add auto-assign PR workflow for organization members (#6058) by @IWANABETHATGUY
- fix benchmark-node workflow (#6060) by @IWANABETHATGUY
- adding `test-node-rolldown-only` just command (#6055) by @IWANABETHATGUY
- just commands in ci (#6056) by @IWANABETHATGUY
- run test ci when `justfile` is changed (#6049) by @IWANABETHATGUY
- remove unused warning for conditional compiled`SimplifyMinifyOptions` (#6047) by @IWANABETHATGUY
- remove auto approval ci (#6051) by @IWANABETHATGUY
- adding rustfmt components for `repo-validation` (#6053) by @IWANABETHATGUY
- repo: check format/style in `just lint-rust` (#6050) by @hyf0
- repo/ai: refine `justfile` (#6038) by @hyf0
- repo/ai: add `AGENTS.md` and `CLAUDE.md` (#6039) by @hyf0
- deps: update github-actions (major) (#6041) by @renovate[bot]
- deps: update github-actions (#6040) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.1 (#6035) by @renovate[bot]

Co-authored-by: shulaoda <[email protected]>
@shulaoda shulaoda mentioned this pull request Sep 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ESM-only publishing

3 participants

@sxzz @IWANABETHATGUY @hyf0