test(dev): migrate hmr tests using new dev API#5980
Closed
hyf0 wants to merge 1 commit intographite-base/5980from
Closed
test(dev): migrate hmr tests using new dev API#5980hyf0 wants to merge 1 commit intographite-base/5980from
dev API#5980hyf0 wants to merge 1 commit intographite-base/5980from
Conversation
This was referenced Aug 30, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hyf0
force-pushed
the
08-30-feat_dev_support_import.meta.invalidate_
branch
from
6ebbbdc to
8a22b7d
Compare
hyf0
force-pushed
the
08-30-test_dev_migrate_hmr_tests_using_new_dev_api
branch
from
35ebf7f to
ea4173c
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| if (this.hasLiveConnections) { | ||
| const output = await build.hmrInvalidate(msg.moduleId); | ||
| if (this.#sockets.size > 0) { | ||
| const output = await this.#devEngine!.invalidate(msg.moduleId); |
Contributor
There was a problem hiding this comment.
The non-null assertion operator (!) on this.#devEngine could lead to a runtime error if #handleHmrInvalidate is called before #devEngine is initialized in the serve() method. Consider adding a null check before using the engine or ensuring proper initialization sequence. A safer approach would be:
if (!this.#devEngine) {
console.error('Dev engine not initialized');
return;
}
const output = await this.#devEngine.invalidate(msg.moduleId);This prevents potential null pointer dereferences while making the code more robust against timing issues.
Suggested change
| const output = await this.#devEngine!.invalidate(msg.moduleId); | |
| if (!this.#devEngine) { | |
| console.error('Dev engine not initialized'); | |
| return; | |
| } | |
| const output = await this.#devEngine.invalidate(msg.moduleId); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
hyf0
changed the base branch from
08-30-feat_dev_support_import.meta.invalidate_
to
graphite-base/5980
Contributor
Benchmarks Rust
|
This was referenced Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related code is merged into #5979.