feat(rolldown): oxc v0.87.0 by Boshen · Pull Request #5975 · rolldown/rolldown

Boshen · 2025-08-30T06:21:57Z

No description provided.

netlify · 2025-08-30T06:22:22Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`2f3207a`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68be5fce3d50a00008628387

socket-security · 2025-08-30T06:23:42Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
@oxc-project/types@0.87.0
@oxc-project/runtime@0.87.0
oxc-transform@0.82.3 ⏵ 0.87.0	⁺¹	⁺¹	⁺²
oxc-parser@0.82.3 ⏵ 0.87.0			⁺²

View full report

github-actions · 2025-08-30T06:38:22Z

Benchmarks Rust

target: main(d63973d)
pr: 08-30-feat_rolldown_oxc_v0.84.0(2f3207a)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     84.2±2.74ms        ? ?/sec    1.01     85.0±4.76ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     94.3±2.32ms        ? ?/sec    1.00     93.9±2.37ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    122.2±3.18ms        ? ?/sec    1.01    123.0±3.36ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    142.6±2.48ms        ? ?/sec    1.00    142.5±3.21ms        ? ?/sec
bundle/bundle@threejs                                        1.02     46.3±0.82ms        ? ?/sec    1.00     45.4±0.95ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     54.6±0.83ms        ? ?/sec    1.00     54.2±0.92ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    480.2±5.10ms        ? ?/sec    1.00    482.1±9.52ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    562.2±5.39ms        ? ?/sec    1.00   558.5±12.12ms        ? ?/sec
scan/scan@rome_ts                                            1.02     98.3±2.07ms        ? ?/sec    1.00     96.1±1.48ms        ? ?/sec
scan/scan@threejs                                            1.03     34.8±0.49ms        ? ?/sec    1.00     33.7±0.60ms        ? ?/sec
scan/scan@threejs10x                                         1.02    360.7±4.13ms        ? ?/sec    1.00    353.2±4.44ms        ? ?/sec

sapphi-red · 2025-08-30T07:12:59Z

feat(rolldown): oxc v0.87.0 #5975 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

crates/rolldown/tests/rolldown/issues/2833/main.js

crates/rolldown/tests/rolldown/topics/deconflict/default_function/artifacts.snap

sapphi-red · 2025-08-30T07:22:32Z

@Boshen It seems oxc-transform is missing optionalDependencies since 0.83.0.

crates/rolldown/tests/esbuild/dce/dce_of_iife/artifacts.snap

crates/rolldown/tests/esbuild/default/nested_require_without_call/artifacts.snap

crates/rolldown/tests/esbuild/default/require_without_call/artifacts.snap

crates/rolldown/tests/esbuild/default/require_without_call_inside_try/artifacts.snap

crates/rolldown/tests/esbuild/ts/ts_enum_jsx/artifacts.snap

Boshen · 2025-08-30T08:18:22Z

Bad news we have more failures from rollup tests

failures [
  "rollup@form@assignment-to-exports: declares updated variable in ES output (#755)@generates es",
  "rollup@form@deep-properties-access: handles deeply nested property accesses",
  "rollup@form@deep-properties: handles deeply nested properties",
  "rollup@form@handles-async-await: properly handles exporting async functions",
  "rollup@form@recursive-computed-members: handle recursive computed member access",
  "rollup@form@recursive-multi-expressions: handles recursive multi-expressions"
]

sapphi-red · 2025-08-30T08:43:59Z

All rollup tests failures are snapshot diffs and I think these are all fine.

IWANABETHATGUY · 2025-08-30T09:42:11Z

If @sapphi-red could ensure all those tests are only different in snapshot, then we could add these tests to │ ignored(behavior passed, snapshot different) category

…s to be preserved (#13422) Made the single use variable inlining to respect `keep_names` option. refs rolldown/rolldown#5975 (comment)

sapphi-red · 2025-08-31T09:21:20Z

On second thought, do we expect this inlining to happen for DCE? I wonder if I should skip this optimization for DCE.

hyf0 · 2025-08-31T09:33:03Z

On second thought, do we expect this inlining to happen for DCE? I wonder if I should skip this optimization for DCE.

My thoughts:

DCE visit is unavoidable, it's positive we could do more things during the visit.
Inlining seems to reduce overheads of the incoming scan phrase(reducing variables, top level statementts, maybe else)

Overall I think it's positive.

IWANABETHATGUY · 2025-08-31T09:57:03Z

On second thought, do we expect this inlining to happen for DCE? I wonder if I should skip this optimization for DCE.

I think that is acceptable, the biggest requirement of the extra dce pass in the scan phase is for deleting dead branches, e.g.

if (process.env.NODE_ENV === "development") {
  require('./a.js')
} else {
  require ('./b.js')
}

without inline, the dce pass can't handle scenario:

const cond = process.env.NODE_ENV
if (cond === "development") {
  require('./a.js')
} else {
  require ('./b.js')
}

Overall, I think it is reasonable to put the inline in DCE?

Note

the process.env.NODE_ENV will be replaced by define option

Boshen · 2025-08-31T11:36:40Z

@sapphi-red updated oxc, remaining issues are

failures [
  "rollup@form@assignment-to-exports: declares updated variable in ES output (#755)@generates es",
  "rollup@form@deep-properties-access: handles deeply nested property accesses",
  "rollup@form@deep-properties: handles deeply nested properties",
  "rollup@form@handles-async-await: properly handles exporting async functions",
  "rollup@form@recursive-computed-members: handle recursive computed member access",
  "rollup@form@recursive-multi-expressions: handles recursive multi-expressions",
  "rollup@form@reexport-star-deshadow: Star reexports scope deshadowing@generates es"
]

sapphi-red · 2025-08-31T13:23:37Z

oxc-project/oxc#13477 should fix the failing test.

crates/rolldown/tests/rolldown/issues/2833/main.js

one thing to check

IWANABETHATGUY · 2025-09-08T05:56:14Z

mapping issues tracked #6054

IWANABETHATGUY · 2025-09-08T06:22:21Z

flaky test

@sxzz

## [1.0.0-beta.36] - 2025-09-08 > [!warning] > ### 💥 BREAKING CHANGES > > - drop CJS format, increase minimum required node (#6025) by @sxzz ### 🚀 Features - rolldown_plugin_reporter: statically imported dynamic import warning (#6065) by @shulaoda - rolldown_plugin_reporter: warn large chunks (#6063) by @shulaoda - rolldown: oxc v0.87.0 (#5975) by @Boshen ### 🐛 Bug Fixes - allow keeping whitespace while enabling minify (#5893) by @sapphi-red - dev/watch: build connection between file in `this.addWatchFile` and currently transformed module during transform hook (#6048) by @hyf0 - validator of `output.minify` (#6062) by @IWANABETHATGUY - codspeed rust benchmark ci (#6052) by @IWANABETHATGUY - just command in ci (#6045) by @IWANABETHATGUY - watch: only consider files read from disk are able to watch (#6037) by @hyf0 ### 🚜 Refactor - dev: introduce `DevWatchOptions` for enhanced file watching configuration (#6057) by @hyf0 - unify to use `is_in_node_modules` from `rolldown_plugin_utils` (#6066) by @shulaoda ### 🧪 Testing - rust: ensure unused pure function call got treeshaked (#4524) by @hyf0 - hmr: tweak improper test (#6034) by @hyf0 - hmr: add test of editing multiple files in the same timeframe (#6029) by @hyf0 - hmr: support to edit multiple files in the same timeframe (#6014) by @hyf0 ### ⚙️ Miscellaneous Tasks - deps: lock file maintenance rust crates (#6003) by @renovate[bot] - deps: lock file maintenance npm packages (#5995) by @renovate[bot] - add auto-assign PR workflow for organization members (#6058) by @IWANABETHATGUY - fix benchmark-node workflow (#6060) by @IWANABETHATGUY - adding `test-node-rolldown-only` just command (#6055) by @IWANABETHATGUY - just commands in ci (#6056) by @IWANABETHATGUY - run test ci when `justfile` is changed (#6049) by @IWANABETHATGUY - remove unused warning for conditional compiled`SimplifyMinifyOptions` (#6047) by @IWANABETHATGUY - remove auto approval ci (#6051) by @IWANABETHATGUY - adding rustfmt components for `repo-validation` (#6053) by @IWANABETHATGUY - repo: check format/style in `just lint-rust` (#6050) by @hyf0 - repo/ai: refine `justfile` (#6038) by @hyf0 - repo/ai: add `AGENTS.md` and `CLAUDE.md` (#6039) by @hyf0 - deps: update github-actions (major) (#6041) by @renovate[bot] - deps: update github-actions (#6040) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.16.1 (#6035) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

Boshen requested a review from sapphi-red August 30, 2025 06:21

Boshen assigned sapphi-red Aug 30, 2025

sapphi-red force-pushed the 08-30-feat_rolldown_oxc_v0.84.0 branch from 739db2d to f5510f0 Compare August 30, 2025 07:12

sapphi-red reviewed Aug 30, 2025

View reviewed changes

crates/rolldown/tests/rolldown/issues/2833/main.js Show resolved Hide resolved

crates/rolldown/tests/rolldown/topics/deconflict/default_function/artifacts.snap Show resolved Hide resolved

hyf0 reviewed Aug 30, 2025

View reviewed changes

crates/rolldown/tests/esbuild/dce/dce_of_iife/artifacts.snap Show resolved Hide resolved

hyf0 reviewed Aug 30, 2025

View reviewed changes

Boshen changed the title ~~feat(rolldown): oxc v0.84.0~~ feat(rolldown): oxc v0.85.0 Aug 30, 2025

IWANABETHATGUY marked this pull request as draft August 30, 2025 09:37

sapphi-red mentioned this pull request Aug 30, 2025

fix(minifier): avoid inlining single use variables when the name needs to be preserved oxc-project/oxc#13422

Merged

Boshen force-pushed the 08-30-feat_rolldown_oxc_v0.84.0 branch from 0e606ef to ceaf924 Compare August 31, 2025 11:35

Boshen changed the title ~~feat(rolldown): oxc v0.85.0~~ feat(rolldown): oxc v0.86.0 Aug 31, 2025

sapphi-red force-pushed the 08-30-feat_rolldown_oxc_v0.84.0 branch from ceaf924 to a0a25f5 Compare August 31, 2025 12:21

shulaoda mentioned this pull request Sep 8, 2025

[Bug]: Minifier drops initialization guard in closure (factory runs multiple times) #6016

Closed

Boshen changed the title ~~feat(rolldown): oxc v0.86.0~~ feat(rolldown): oxc v0.87.0 Sep 8, 2025

Boshen marked this pull request as ready for review September 8, 2025 03:55

Boshen force-pushed the 08-30-feat_rolldown_oxc_v0.84.0 branch from 2f89001 to 3c79bd8 Compare September 8, 2025 03:56

graphite-app bot reviewed Sep 8, 2025

View reviewed changes

crates/rolldown/tests/rolldown/issues/2833/main.js Show resolved Hide resolved

Boshen and others added 5 commits September 8, 2025 13:46

feat(rolldown): oxc v0.84.0

85d648b

0.85.0

9ba9f78

0.86.0

57e3dc5

chore: add to ignored-passed-snapshot-different-tests

bd0ea85

0.87.0

2f3207a

sapphi-red force-pushed the 08-30-feat_rolldown_oxc_v0.84.0 branch from 3c79bd8 to 2f3207a Compare September 8, 2025 04:47

sapphi-red previously approved these changes Sep 8, 2025

View reviewed changes

IWANABETHATGUY approved these changes Sep 8, 2025

View reviewed changes

IWANABETHATGUY added this pull request to the merge queue Sep 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 8, 2025

IWANABETHATGUY merged commit a4e3899 into main Sep 8, 2025
26 checks passed

IWANABETHATGUY deleted the 08-30-feat_rolldown_oxc_v0.84.0 branch September 8, 2025 06:22

IWANABETHATGUY self-assigned this Sep 8, 2025

github-actions bot mentioned this pull request Sep 8, 2025

release: v1.0.0-beta.36 #6068

Merged

IWANABETHATGUY mentioned this pull request Sep 17, 2025

Module Resolution(?) Regression in >=beta.36 #6263

Closed

Copilot AI mentioned this pull request Oct 29, 2025

✅ Confirmed: oxc PR #15069 fixes invalid sourcemapping after upgrade #6750

Closed

Comments

Conversation

Boshen commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

socket-security bot commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

sapphi-red commented Aug 30, 2025

Uh oh!

Uh oh!

Uh oh!

sapphi-red commented Aug 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Boshen commented Aug 30, 2025

Uh oh!

sapphi-red commented Aug 30, 2025

Uh oh!

IWANABETHATGUY commented Aug 30, 2025

Uh oh!

sapphi-red commented Aug 31, 2025

Uh oh!

hyf0 commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Boshen commented Aug 31, 2025

Uh oh!

sapphi-red commented Aug 31, 2025

Uh oh!

Uh oh!

IWANABETHATGUY commented Sep 8, 2025

Uh oh!

Uh oh!

Uh oh!

IWANABETHATGUY commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Boshen commented Aug 30, 2025 •

edited

Loading

netlify bot commented Aug 30, 2025 •

edited

Loading

socket-security bot commented Aug 30, 2025 •

edited

Loading

github-actions bot commented Aug 30, 2025 •

edited

Loading

hyf0 commented Aug 31, 2025 •

edited

Loading

IWANABETHATGUY commented Aug 31, 2025 •

edited

Loading

IWANABETHATGUY commented Sep 8, 2025 •

edited

Loading