fix: __toESM function breaking ES module imports by IWANABETHATGUY · Pull Request #5966 · rolldown/rolldown

IWANABETHATGUY · 2025-08-29T14:35:48Z

es-module-lexer only recognize specific pattern to collect exports binding, see https://github.com/edison1105/rolldownToESM/blob/ce20866468677b1ac17946b6f8be9c00bf99827f/bug-repro.cjs?plain=1#L27-L46 as an example,
when the module is imported via import()
cjs-module-lexer can't recognize pattern like:

const __mock_library = __toESM(require("./mock-library.cjs"));

And assume it is dynamic, so that foo is not reexported, but it could recognize pattern like:

const __mock_library = require("./mock-library.cjs");

exports.bar = function bar() {}

Object.keys(__mock_library).forEach(function (k) {
  if (k !== 'default' && !Object.prototype.hasOwnProperty.call(exports, k)) Object.defineProperty(exports, k, {
    enumerable: true,
    get: function () { return __mock_library[k]; }
  });

  // still not working, due to __toESM processed properties as a getter function
  // exports[k] = __mock_library[k]
});

After doing some investigation, I found that it also could recognize pattern like:

let __mock_library = require("./mock-library.cjs");
__mock_library = __toESM(__mock_library);
// ... snip

So I changed the importing external module code to make sure we have better compatibility with cjs-module-lexer

IWANABETHATGUY · 2025-08-29T14:36:05Z

fix: __toESM function breaking ES module imports #5966 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-08-29T14:36:15Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`6ec8ac5`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68b1bac659edcb00080d405e

github-actions · 2025-08-29T14:52:15Z

Benchmarks Rust

target: main(76683cb)
pr: 08-29-fix_5934(6ec8ac5)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     78.0±2.96ms        ? ?/sec    1.04     81.3±2.28ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     87.2±1.99ms        ? ?/sec    1.04     90.6±2.15ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    119.0±1.81ms        ? ?/sec    1.01    120.4±2.26ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    138.1±1.72ms        ? ?/sec    1.02    141.2±3.13ms        ? ?/sec
bundle/bundle@threejs                                        1.00     44.5±1.32ms        ? ?/sec    1.01     45.1±2.38ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     53.3±2.25ms        ? ?/sec    1.01     53.8±1.09ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    459.3±5.27ms        ? ?/sec    1.01    463.5±5.51ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    540.3±6.35ms        ? ?/sec    1.02    548.5±4.59ms        ? ?/sec
scan/scan@rome_ts                                            1.00     94.3±1.56ms        ? ?/sec    1.01     94.9±1.94ms        ? ?/sec
scan/scan@threejs                                            1.02     34.0±2.05ms        ? ?/sec    1.00     33.3±1.34ms        ? ?/sec
scan/scan@threejs10x                                         1.01    350.2±3.94ms        ? ?/sec    1.00    348.1±4.86ms        ? ?/sec

IWANABETHATGUY · 2025-08-29T17:26:01Z

@sapphi-red Do you mean any better idea, I am not sure if there exists any other way to solve #5934

hyf0

Could add a test here: https://github.com/rolldown/rolldown/tree/main/crates/rolldown/tests/rolldown/topics/cjs_module_lexer_compat

@shulaoda

## [1.0.0-beta.35] - 2025-09-05 ### 🚀 Features - rolldown_plugin_vite_css_post: attch vite metadata to chunks (#6011) by @shulaoda - rolldown_plugin_vite_css_post: emit a single CSS asset for non–code-split builds (#6005) by @shulaoda - rolldown_plugin_vite_css_post: align empty CSS chunk removal logic (#6004) by @shulaoda - use frequent characters first for internal export names (#5524) by @AliceLanniste - rolldown_plugin_vite_css_post: align partial `generateBundle` logic (#5987) by @shulaoda - rolldown_plugin_vite_css_post: align `augmentChunkHash` logic (#5986) by @shulaoda - rolldown_watcher: introduce `WatcherConfig` for configurable watcher parameters (#5991) by @hyf0 - dev: support `import.meta.invalidate` and migrate tests (#5979) by @hyf0 - dev: adapt `TestDevServer` with `DevEngine` (#5976) by @hyf0 - propertyWriteSideEffects (#5977) by @IWANABETHATGUY - rolldown_plugin_vite_css_post: complete `transform` logic (#5985) by @shulaoda - dev: generate hmr updates for file changes (#5961) by @hyf0 - rolldown_plugin_vite_css_post: complete `finalize_css` (#5974) by @shulaoda - dev: manage cache by `DevEngine` (#5960) by @hyf0 - rolldown_plugin_vite_css_post: align `hoist_at_rules` (#5967) by @shulaoda - rolldown_plugin_vte_css_post: complete `resolve_asset_urls_in_css` (#5958) by @shulaoda - rolldown_plugin_utils: support common `to_output_file_path` (#5956) by @shulaoda - dev: default to not eager rebuild (#5949) by @hyf0 - treeshake.propertyReadSideEffects (#5945) by @IWANABETHATGUY - improve error message for `this.resolve` and `this.load` (#5596) by @sapphi-red - dev: accept `onHmrUpdates` callback (#5942) by @hyf0 - rolldown_plugin_vite_css_post: align partial `resolve_asset_urls_in_css` (#5929) by @shulaoda - mark `__export` runtime helper as pure (#5926) by @IWANABETHATGUY - rolldown_plugin_vite_css_post: extract `finalize_css_chunk` (#5916) by @shulaoda - implement inlineConst.pass (#5912) by @IWANABETHATGUY - rolldown_plugin_vite_css_post: align partial legacy logic (#5915) by @shulaoda - add inlineConst.pass options (#5911) by @IWANABETHATGUY - rolldown_plugin_vite_css_post: align partial css code split logic (#5906) by @shulaoda - inlineConst: safe (#5899) by @IWANABETHATGUY ### 🐛 Bug Fixes - rolldown: don't cleanup for browser build (#6024) by @sxzz - propertyWriteSideEffects for toplevel staticClassBlock (#5989) by @IWANABETHATGUY - handle `obj().prop` when `propertyReadSideEffects: false` (#5988) by @IWANABETHATGUY - handle objectSpread when `treeshake.propertyReadSideEffects` is enabled (#5981) by @IWANABETHATGUY - __toESM function breaking ES module imports (#5966) by @IWANABETHATGUY - merge `typescript.onlyRemoveTypeImports` correctly (#5962) by @shulaoda - should not generate `init_mod` when record is a ExportAllDeclaration and importee is a inner concatenate module (#5952) by @IWANABETHATGUY - use symbol existance to detect if a plugin is BuiltinPlugin (#5940) by @IWANABETHATGUY - handle errors thrown in `onLog` and `onwarn` options (#5931) by @sapphi-red - `replace_plugin` does not work as expected with .ts config (#5920) by @IWANABETHATGUY - `replace_plugin` support primitive values replacement (#5921) by @IWANABETHATGUY - node 20 test version (#5918) by @IWANABETHATGUY - trigger trace subscriber cleanup on Node.js side (#5913) by @sapphi-red - add friendly deprecation warning for `resolve.tsconfigFilename` (#5908) by @shulaoda - inlineConst inlines a var (#5903) by @IWANABETHATGUY - types: omit `sourcemap` property from `MinifyOptions` correctly (#5892) by @sapphi-red ### 🚜 Refactor - hmr: process changed files in one update (#6013) by @hyf0 - rolldown_plugin_vite_css_post: improve (#6006) by @shulaoda - migrate remaining crates from #[allow] to #[expect] attributes (#6002) by @hyf0 - crates/rolldown_common: migrate from #[allow] to #[expect] attributes (#6001) by @hyf0 - crates/rolldown_binding: migrate from #[allow] to #[expect] attributes (#6000) by @hyf0 - crates/rolldown: migrate from #[allow] to #[expect] attributes (#5999) by @hyf0 - extract all options usage in `impl_visit.rs` into `FlatOptionsFlag` (#5992) by @IWANABETHATGUY - rolldown_watcher: distinguish debounced and non-debounced watchers (#5990) by @hyf0 - dev: only use poll-based watch if required (#5984) by @hyf0 - dev: use dynamic dispatch watcher (#5982) by @hyf0 - improve plugin logic relate to `to_output_file_path` (#5959) by @shulaoda - make reference_needed_symbols lock free (#5964) by @IWANABETHATGUY - tweak module loader code (#5950) by @shulaoda - use less memory to store frequently accessed options field (#5948) by @IWANABETHATGUY - make `ecma_related` in `NormalModuleTaskResult` non-optional (#5947) by @shulaoda - dev: replace `BuildStatus` with `BuildStateMachine` (#5927) by @hyf0 - rename `inlineConst: 'safe'` to `inlineConst: 'smart'` (#5909) by @IWANABETHATGUY ### 📚 Documentation - add redirect for old plugin development page link (#5963) by @TheAlexLichter ### ⚡ Performance - rolldown: use allocator pool when minifying chunks (#5978) by @Boshen - merge two `PreProcessor` and `EnsureSpanUniqueness` (#5968) by @IWANABETHATGUY ### 🧪 Testing - cjs module lexer for named import external with cjs format (#5970) by @IWANABETHATGUY - hmr: import.meta.hot?.accept case (#5935) by @sapphi-red - hmr: accept outside circular case (#5938) by @sapphi-red - hmr: no accept outside circular dependencies case (#5937) by @sapphi-red - hmr: self accept within circular dependencies case (#5936) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update crate-ci/typos action to v1.36.2 (#6015) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to ^0.16.0 (#6023) by @renovate[bot] - ci: re-enable WASM tests in CI workflows (#6007) by @hyf0 - deps: update crate-ci/typos action to v1.35.8 (#6012) by @renovate[bot] - clippy: enable allow_attributes lint and migrate to #[expect] (#6008) by @hyf0 - remove unmaintained AGENTS.md file (#6009) by @hyf0 - deps: update github-actions (#5993) by @renovate[bot] - fix `knip` warnings and remove redundant `@rolldown/testing` (#5973) by @shulaoda - deps: update dependency rolldown-plugin-dts to v0.15.10 (#5925) by @renovate[bot] - deps: update rust crate tracing-subscriber to v0.3.20 [security] (#5972) by @renovate[bot] - fix wasi build failed (#5969) by @shulaoda - deps: update crate-ci/typos action to v1.35.7 (#5965) by @renovate[bot] - remove redundant code (#5943) by @shulaoda - npm trusted publisher (#5953) by @Brooooooklyn - deps: update crate-ci/typos action to v1.35.6 (#5957) by @renovate[bot] - Revert "feat: mark `__export` runtime helper as pure (#5926)" (#5928) by @IWANABETHATGUY - deps: update dependency rolldown-plugin-dts to v0.15.10 (#5900) by @renovate[bot] - validator: improve the diagnostic message (#5919) by @shulaoda - add more tracing instrumentation (#5914) by @sapphi-red - add proper error message when passing unexpected minify options in rust test (#5905) by @IWANABETHATGUY - deps: update dependency tsdown to v0.14.2 (#5901) by @renovate[bot] - add automatic issue closing (#5895) by @shulaoda Co-authored-by: shulaoda <[email protected]>

fix: 5934

6ec8ac5

IWANABETHATGUY marked this pull request as ready for review August 29, 2025 14:53

IWANABETHATGUY requested a review from hyf0 August 29, 2025 15:05

IWANABETHATGUY changed the title ~~fix: 5934~~ fix: __toESM function breaking ES module imports Aug 29, 2025

IWANABETHATGUY requested a review from sapphi-red August 29, 2025 17:25

hyf0 approved these changes Aug 29, 2025

View reviewed changes

IWANABETHATGUY added this pull request to the merge queue Aug 29, 2025

Merged via the queue into main with commit 3e45572 Aug 29, 2025
74 of 82 checks passed

IWANABETHATGUY deleted the 08-29-fix_5934 branch August 29, 2025 17:34

github-actions bot mentioned this pull request Sep 5, 2025

release: v1.0.0-beta.35 #6030

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: __toESM function breaking ES module imports#5966

fix: __toESM function breaking ES module imports#5966
IWANABETHATGUY merged 1 commit intomainfrom
08-29-fix_5934

IWANABETHATGUY commented Aug 29, 2025 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Aug 29, 2025

Uh oh!

netlify bot commented Aug 29, 2025

Uh oh!

github-actions bot commented Aug 29, 2025 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Aug 29, 2025

Uh oh!

hyf0 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Aug 29, 2025

Uh oh!

netlify bot commented Aug 29, 2025

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

github-actions bot commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

IWANABETHATGUY commented Aug 29, 2025

Uh oh!

hyf0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Aug 29, 2025 •

edited

Loading

github-actions bot commented Aug 29, 2025 •

edited

Loading