Skip to content

Comments

perf: remove redundant custom default-export expression and alias#5924

Closed
shulaoda wants to merge 1 commit intomainfrom
08-27-perf_remove_redundant_custom_default-export_expression_and_alias
Closed

perf: remove redundant custom default-export expression and alias#5924
shulaoda wants to merge 1 commit intomainfrom
08-27-perf_remove_redundant_custom_default-export_expression_and_alias

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Aug 27, 2025 •
edited
Loading

A small improvement

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Aug 27, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda marked this pull request as ready for review August 27, 2025 03:03
@netlify
Copy link

netlify bot commented Aug 27, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit e45d9a0
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68ae81350c331a0008889916
😎 Deploy Preview https://deploy-preview-5924--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

shulaoda
shulaoda commented Aug 27, 2025
View reviewed changes
crates/rolldown/src/ast_scanner/mod.rs
Comment on lines +682 to +683
// See https://github.com/rolldown/rolldown/issues/5847
|| scoping.symbol_flags(symbol_id).is_import()
Copy link
Member Author

@shulaoda shulaoda Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we can solve and improve it in the future.

@shulaoda shulaoda marked this pull request as draft August 27, 2025 03:11
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(28e8702)
  • pr: 08-27-perf_remove_redundant_custom_default-export_expression_and_alias(e45d9a0)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     78.3±1.39ms        ? ?/sec    1.01     79.1±1.29ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     90.6±4.51ms        ? ?/sec    1.00     88.6±1.20ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    118.7±1.46ms        ? ?/sec    1.02    120.7±2.92ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    138.4±2.34ms        ? ?/sec    1.02    141.2±3.02ms        ? ?/sec
bundle/bundle@threejs                                        1.03     45.3±3.45ms        ? ?/sec    1.00     44.1±1.26ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     53.3±1.21ms        ? ?/sec    1.01     53.7±1.01ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01   472.1±19.61ms        ? ?/sec    1.00    466.4±8.38ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01   561.4±12.40ms        ? ?/sec    1.00    555.5±7.79ms        ? ?/sec
scan/scan@rome_ts                                            1.00     96.3±1.34ms        ? ?/sec    1.08    104.4±3.45ms        ? ?/sec
scan/scan@threejs                                            1.00     34.3±0.52ms        ? ?/sec    1.01     34.8±2.19ms        ? ?/sec
scan/scan@threejs10x                                         1.00    359.0±6.38ms        ? ?/sec    1.00    358.5±5.19ms        ? ?/sec

@shulaoda shulaoda force-pushed the 08-27-perf_remove_redundant_custom_default-export_expression_and_alias branch from c01bb74 to 5f7c156 Compare August 27, 2025 03:31
@shulaoda shulaoda marked this pull request as ready for review August 27, 2025 03:34
@shulaoda shulaoda marked this pull request as draft August 27, 2025 03:49
@shulaoda shulaoda force-pushed the 08-27-perf_remove_redundant_custom_default-export_expression_and_alias branch from 5f7c156 to e45d9a0 Compare August 27, 2025 03:53
@shulaoda shulaoda marked this pull request as ready for review August 27, 2025 03:54
@IWANABETHATGUY IWANABETHATGUY self-assigned this Aug 27, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 27, 2025 •
edited
Loading

Merge activity

  • Aug 27, 4:48 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Aug 27, 4:48 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

sapphi-red
sapphi-red reviewed Aug 27, 2025
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should add a test case for #4013 (comment)

@shulaoda shulaoda marked this pull request as draft August 27, 2025 07:10
@sapphi-red
Copy link
Member

sapphi-red commented Feb 4, 2026

I guess this is done by #8127

@sapphi-red sapphi-red closed this Feb 4, 2026
@shulaoda shulaoda mentioned this pull request Feb 4, 2026
Merged
shulaoda added a commit that referenced this pull request Feb 4, 2026
@shulaoda
refactor: simplify import symbol check using SymbolFlags (#8193)
d0c1c36 
Related to #5924 and #8127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sapphi-red sapphi-red sapphi-red left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shulaoda @sapphi-red @IWANABETHATGUY