fix: allow keeping whitespace while enabling minify by sapphi-red · Pull Request #5893 · rolldown/rolldown

sapphi-red · 2025-08-25T05:06:22Z

output: { minify: { codegen: false } } was no longer possible to specify. This PR fixes that.

sapphi-red · 2025-08-25T05:06:37Z

fix: allow keeping whitespace while enabling minify #5893 👈 (View in Graphite)
fix: validator of output.minify #6062
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-08-25T05:32:41Z

Benchmarks Rust

target: main(139191d)
pr: 08-25-fix_allow_keeping_whitespace_while_enabling_minify(16bc7b8)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.05     84.2±2.69ms        ? ?/sec    1.00     80.2±2.12ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.04     93.9±3.00ms        ? ?/sec    1.00     89.9±2.14ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    123.2±2.54ms        ? ?/sec    1.00    120.8±2.21ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    143.0±2.87ms        ? ?/sec    1.00    141.7±2.60ms        ? ?/sec
bundle/bundle@threejs                                        1.02     47.6±2.39ms        ? ?/sec    1.00     46.8±2.42ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.03     56.0±1.59ms        ? ?/sec    1.00     54.1±1.03ms        ? ?/sec
bundle/bundle@threejs10x                                     1.04    484.2±8.61ms        ? ?/sec    1.00    467.4±5.80ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.04    570.0±8.20ms        ? ?/sec    1.00    549.9±4.65ms        ? ?/sec
scan/scan@rome_ts                                            1.01     97.3±1.76ms        ? ?/sec    1.00     96.5±2.19ms        ? ?/sec
scan/scan@threejs                                            1.06     36.0±1.89ms        ? ?/sec    1.00     33.8±2.08ms        ? ?/sec
scan/scan@threejs10x                                         1.03    363.0±4.79ms        ? ?/sec    1.00    352.4±5.24ms        ? ?/sec

netlify · 2025-09-08T07:54:30Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`361c466`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68bec19077c59f0008b0ee8f
😎 Deploy Preview	https://deploy-preview-5893--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

graphite-app · 2025-09-08T09:42:32Z

Merge activity

Sep 8, 9:42 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
Sep 8, 9:42 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
Sep 8, 10:54 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
Sep 8, 11:25 AM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
Sep 8, 11:31 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.

`output: { minify: { codegen: false } }` was no longer possible to specify. This PR fixes that. requires oxc-project/oxc#13288

@sxzz

## [1.0.0-beta.36] - 2025-09-08 > [!warning] > ### 💥 BREAKING CHANGES > > - drop CJS format, increase minimum required node (#6025) by @sxzz ### 🚀 Features - rolldown_plugin_reporter: statically imported dynamic import warning (#6065) by @shulaoda - rolldown_plugin_reporter: warn large chunks (#6063) by @shulaoda - rolldown: oxc v0.87.0 (#5975) by @Boshen ### 🐛 Bug Fixes - allow keeping whitespace while enabling minify (#5893) by @sapphi-red - dev/watch: build connection between file in `this.addWatchFile` and currently transformed module during transform hook (#6048) by @hyf0 - validator of `output.minify` (#6062) by @IWANABETHATGUY - codspeed rust benchmark ci (#6052) by @IWANABETHATGUY - just command in ci (#6045) by @IWANABETHATGUY - watch: only consider files read from disk are able to watch (#6037) by @hyf0 ### 🚜 Refactor - dev: introduce `DevWatchOptions` for enhanced file watching configuration (#6057) by @hyf0 - unify to use `is_in_node_modules` from `rolldown_plugin_utils` (#6066) by @shulaoda ### 🧪 Testing - rust: ensure unused pure function call got treeshaked (#4524) by @hyf0 - hmr: tweak improper test (#6034) by @hyf0 - hmr: add test of editing multiple files in the same timeframe (#6029) by @hyf0 - hmr: support to edit multiple files in the same timeframe (#6014) by @hyf0 ### ⚙️ Miscellaneous Tasks - deps: lock file maintenance rust crates (#6003) by @renovate[bot] - deps: lock file maintenance npm packages (#5995) by @renovate[bot] - add auto-assign PR workflow for organization members (#6058) by @IWANABETHATGUY - fix benchmark-node workflow (#6060) by @IWANABETHATGUY - adding `test-node-rolldown-only` just command (#6055) by @IWANABETHATGUY - just commands in ci (#6056) by @IWANABETHATGUY - run test ci when `justfile` is changed (#6049) by @IWANABETHATGUY - remove unused warning for conditional compiled`SimplifyMinifyOptions` (#6047) by @IWANABETHATGUY - remove auto approval ci (#6051) by @IWANABETHATGUY - adding rustfmt components for `repo-validation` (#6053) by @IWANABETHATGUY - repo: check format/style in `just lint-rust` (#6050) by @hyf0 - repo/ai: refine `justfile` (#6038) by @hyf0 - repo/ai: add `AGENTS.md` and `CLAUDE.md` (#6039) by @hyf0 - deps: update github-actions (major) (#6041) by @renovate[bot] - deps: update github-actions (#6040) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.16.1 (#6035) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

sapphi-red mentioned this pull request Aug 25, 2025

fix(types): omit sourcemap property from MinifyOptions correctly #5892

Merged

sapphi-red force-pushed the 08-25-fix_allow_keeping_whitespace_while_enabling_minify branch from ebce567 to 3b0f0a8 Compare August 25, 2025 05:17

sapphi-red mentioned this pull request Aug 25, 2025

chore(deps): update rolldown-related dependencies vitejs/vite#20675

Merged

1 task

Base automatically changed from 08-25-fix_types_omit_sourcemap_property_from_minifyoptions_correctly to main August 25, 2025 06:08

sapphi-red force-pushed the 08-25-fix_allow_keeping_whitespace_while_enabling_minify branch from 3b0f0a8 to 57f3894 Compare September 8, 2025 07:53

sapphi-red changed the base branch from main to graphite-base/5893 September 8, 2025 07:57

sapphi-red force-pushed the 08-25-fix_allow_keeping_whitespace_while_enabling_minify branch from 57f3894 to 53ebe64 Compare September 8, 2025 07:58

sapphi-red changed the base branch from graphite-base/5893 to 09-08-fix_validator_of_output.minify_ September 8, 2025 07:58

sapphi-red mentioned this pull request Sep 8, 2025

fix: validator of output.minify #6062

Merged

sapphi-red force-pushed the 08-25-fix_allow_keeping_whitespace_while_enabling_minify branch from 53ebe64 to 68f6f94 Compare September 8, 2025 08:06

sapphi-red marked this pull request as ready for review September 8, 2025 08:16

sapphi-red requested a review from IWANABETHATGUY September 8, 2025 08:16

sapphi-red assigned IWANABETHATGUY Sep 8, 2025

IWANABETHATGUY approved these changes Sep 8, 2025

View reviewed changes

Base automatically changed from 09-08-fix_validator_of_output.minify_ to main September 8, 2025 09:42

sapphi-red force-pushed the 08-25-fix_allow_keeping_whitespace_while_enabling_minify branch from 68f6f94 to f4c3e41 Compare September 8, 2025 09:47

sapphi-red added this pull request to the merge queue Sep 8, 2025

graphite-app bot force-pushed the 08-25-fix_allow_keeping_whitespace_while_enabling_minify branch from f4c3e41 to f2c17a8 Compare September 8, 2025 10:54

graphite-app bot pushed a commit that referenced this pull request Sep 8, 2025

fix: allow keeping whitespace while enabling minify (#5893)

f2c17a8

`output: { minify: { codegen: false } }` was no longer possible to specify. This PR fixes that. requires oxc-project/oxc#13288

graphite-app bot pushed a commit that referenced this pull request Sep 8, 2025

fix: allow keeping whitespace while enabling minify (#5893)

16bc7b8

`output: { minify: { codegen: false } }` was no longer possible to specify. This PR fixes that. requires oxc-project/oxc#13288

graphite-app bot force-pushed the 08-25-fix_allow_keeping_whitespace_while_enabling_minify branch from f2c17a8 to 16bc7b8 Compare September 8, 2025 11:05

IWANABETHATGUY added the graphite: merge label Sep 8, 2025

graphite-app bot removed the graphite: merge label Sep 8, 2025

IWANABETHATGUY added the graphite: merge label Sep 8, 2025

fix: allow keeping whitespace while enabling minify (#5893)

361c466

`output: { minify: { codegen: false } }` was no longer possible to specify. This PR fixes that. requires oxc-project/oxc#13288

graphite-app bot force-pushed the 08-25-fix_allow_keeping_whitespace_while_enabling_minify branch from 16bc7b8 to 361c466 Compare September 8, 2025 11:44

shulaoda merged commit 880acce into main Sep 8, 2025
14 of 20 checks passed

shulaoda deleted the 08-25-fix_allow_keeping_whitespace_while_enabling_minify branch September 8, 2025 11:45

graphite-app bot removed the graphite: merge label Sep 8, 2025

github-actions bot mentioned this pull request Sep 8, 2025

release: v1.0.0-beta.36 #6068

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: allow keeping whitespace while enabling minify#5893

fix: allow keeping whitespace while enabling minify#5893
shulaoda merged 1 commit intomainfrom
08-25-fix_allow_keeping_whitespace_while_enabling_minify

sapphi-red commented Aug 25, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Aug 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 25, 2025 •

edited

Loading

Uh oh!

netlify bot commented Sep 8, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

sapphi-red commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

netlify bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

graphite-app bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sapphi-red commented Aug 25, 2025 •

edited

Loading

sapphi-red commented Aug 25, 2025 •

edited

Loading

github-actions bot commented Aug 25, 2025 •

edited

Loading

netlify bot commented Sep 8, 2025 •

edited

Loading

graphite-app bot commented Sep 8, 2025 •

edited

Loading