Skip to content

Comments

feat(rollup-test): log error when pringStatus#5744

Merged
hyf0 merged 1 commit intorolldown:mainfrom
situ2001:situ/0817-refine-err-log-rollup-test
Aug 17, 2025
Merged

feat(rollup-test): log error when pringStatus#5744
hyf0 merged 1 commit intorolldown:mainfrom
situ2001:situ/0817-refine-err-log-rollup-test

Conversation

@situ2001
Copy link
Contributor

Print error after tests are all completed for better dev experience, if there is any error, to avoid searching for error in the extensive terminal output.

For example

rollup@function@sourcemap-base-url-invalid: throws for invalid sourcemapBaseUrl
AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:

{
  code: 'GenericFailure',
  message: 'Invalid value for `sourcemapBaseUrl` option, should be a valid URL: example.com'
}

should loosely deep-equal

{
  code: 'INVALID_OPTION',
  message: 'Invalid value for option "output.sourcemapBaseUrl" - must be a valid URL, received "example.com".',
  url: 'https://rollupjs.org/configuration-options/#output-sourcemapbaseurl'
}
    at compareError (test/utils.js:69:9)
    at /home/situ/Codes/rolldown/packages/rollup-tests/test/function/index.js:135:10 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: '{\n' +
    '  "code": "GenericFailure"\n' +
    '  "message": "Invalid value for `sourcemapBaseUrl` option, should be a valid URL: example.com"\n' +
    '}',
  expected: '{\n' +
    '  "code": "INVALID_OPTION"\n' +
    '  "message": "Invalid value for option \\"output.sourcemapBaseUrl\\" - must be a valid URL, received \\"example.com\\"."\n' +
    '  "url": "https://rollupjs.org/configuration-options/#output-sourcemapbaseurl"\n' +
    '}',
  operator: 'deepEqual'
}


rollup@sourcemaps@sourcemap-base-url-without-trailing-slash: add a trailing slash automatically if it is missing@generates es
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
actual expected

'//#end sourcegMappingURL=https://example.com/a/bundle.es.js.map'

    at Object.test (/home/situ/Codes/rolldown/rollup/test/sourcemaps/samples/sourcemap-base-url-without-trailing-slash/_config.js:12:10)
    at generateAndTestBundle (test/sourcemaps/index.js:69:15)
    at Context.<anonymous> (test/sourcemaps/index.js:44:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: '//#endregion',
  expected: '//# sourceMappingURL=https://example.com/a/bundle.es.js.map',
  operator: 'strictEqual'
}


rollup@sourcemaps@sourcemap-base-url: adds a sourcemap base url@generates es
AssertionError [ERR_ASSERTION]: '//#endregion' == '//# sourceMappingURL=https://example.com/a/bundle.es.js.map'
    at Object.test (/home/situ/Codes/rolldown/rollup/test/sourcemaps/samples/sourcemap-base-url/_config.js:13:10)
    at generateAndTestBundle (test/sourcemaps/index.js:69:15)
    at Context.<anonymous> (test/sourcemaps/index.js:44:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: '//#endregion',
  expected: '//# sourceMappingURL=https://example.com/a/bundle.es.js.map',
  operator: '=='
}


failures [
  "rollup@function@sourcemap-base-url-invalid: throws for invalid sourcemapBaseUrl",
  "rollup@sourcemaps@sourcemap-base-url-without-trailing-slash: add a trailing slash automatically if it is missing@generates es",
  "rollup@sourcemaps@sourcemap-base-url: adds a sourcemap base url@generates es"
]
┌──────────────────────────────────────────────┬────────┐
│ (index)                                      │ Values │
├──────────────────────────────────────────────┼────────┤
│ failed                                       │ 3      │
│ skipFailed                                   │ 2      │
│ ignored                                      │ 17     │
│ ignored(unsupported features)                │ 390    │
│ ignored(treeshaking)                         │ 282    │
│ ignored(behavior passed, snapshot different) │ 124    │
│ passed                                       │ 730    │
└──────────────────────────────────────────────┴────────┘

@hyf0 hyf0 added this pull request to the merge queue Aug 17, 2025
@hyf0
Copy link
Member

hyf0 commented Aug 17, 2025

Thank you!

Merged via the queue into rolldown:main with commit 7d794f7 Aug 17, 2025
17 checks passed
This was referenced Aug 18, 2025
hyf0 pushed a commit that referenced this pull request Aug 18, 2025
## [1.0.0-beta.33] - 2025-08-18

### 💥 BREAKING CHANGES

- only call `closeBundle` hook when bundling actually happens (#5715) by
@shulaoda

### 🚀 Features

- rolldown_plugin_vite_css_post: align transform logic except minify
(#5768) by @shulaoda
- rolldown_plugin_vite_css_post: align html inline css logic (#5767) by
@shulaoda
- support merge cjs ns in module group level (#5760) by @IWANABETHATGUY
- rolldown_plugin_vite_css_post: filter transform id (#5766) by
@shulaoda
- rolldown: oxc v0.82.2 (#5754) by @Boshen
- rollup-test: log error when `pringStatus` (#5744) by @situ2001
- rolldown_plugin_vite_css_post: initialize (#5743) by @shulaoda
- rolldown_plugin_vite_css: align `transform` hook logic (#5736) by
@shulaoda
- rolldown_plugin_vite_css: align partial transform hook logic (#5733)
by @shulaoda
- add original wrap_kind (#5729) by @IWANABETHATGUY
- concatenateWrappedModule (#5724) by @IWANABETHATGUY
- rolldown: oxc v0.82.1 (#5717) by @Boshen
- improve error message for `unresolved_import` when platform is
`neutral` (#5700) by @IWANABETHATGUY

### 🐛 Bug Fixes

- rolldown_plugin_transform: merge tsconfig jsx options even when
`oxc.jsx.runtime` is set (#5771) by @hi-ogawa
- jsx preserve break component which is default export (#5764) by
@shulaoda
- rolldown_plugin_asset: should directly stringify raw content (#5749)
by @situ2001
- resolve symbol deconfliction order for cross-chunk imports by
@IWANABETHATGUY
- rolldown_error: improve resolve diagnostic message (#5740) by
@shulaoda
- vitest ci failed (#5741) by @IWANABETHATGUY
- rolldown: options `context` should be available in renderStart (#5672)
by @situ2001
- ensure lazy module eval order when import variable from other chunk
(#5727) by @IWANABETHATGUY
- wasm build panic on stackblitz (#5723) by @shulaoda
- plugin/vite-resolve: try non-prefixed id before prefixed id (#5711) by
@sapphi-red
- devtool: shouldn't filter out spans for devtool use case (#5713) by
@hyf0
- plugin/vite-resolve: fallback on more resolution errors that happened
when trying with prefix (#5710) by @sapphi-red
- plugin/vite-resolve: don't consider ids with `npm:` prefix as a
built-in module (#5709) by @sapphi-red

### 🚜 Refactor

- rolldown_plugin_json: use common plugin utils (#5769) by @shulaoda
- hmr: remove unnecessary code of handling runtime module (#5752) by
@hyf0
- hmr: enhance HMR update logic and improve clarity (#5748) by @hyf0
- improve `ScopeHoistingFinalizerContext` (#5739) by @shulaoda
- move `finalize_normal_module` into `ScopeHoistingFinalizerContext`
(#5738) by @shulaoda
- private fields `wrap_kind` and `original_wrap_kind` and keep them sync
(#5730) by @IWANABETHATGUY

### 📚 Documentation

- rolldown_plugin_data_uri: update README (#5746) by @situ2001
- install guide for minor platforms (#5716) by @sapphi-red
- update description for platform `neutral` (#5701) by @IWANABETHATGUY

### ⚡ Performance

- hmr: only refetch changed modules (#5753) by @hyf0
- rolldown_plugin_reporter: gzip size computation (#5734) by
@IWANABETHATGUY
- hmr: reuse previous ast for non-changed modules (#5725) by @hyf0
- rolldown_ecmascript: do not run semantic twice for `dce-only` (#5707)
by @Boshen

### 🧪 Testing

- rolldown: should await for `toMatchFileSnapshot` (#5759) by @situ2001
- hmr: improve test of `import.meta.hot.invalidate` (#5747) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance (#5765) by @renovate[bot]
- deps: lock file maintenance rust crates (#5763) by @renovate[bot]
- deps: lock file maintenance npm packages (#5762) by @renovate[bot]
- deps: update github-actions (#5755) by @renovate[bot]
- deps: update dependency tinybench to v5 (#5756) by @renovate[bot]
- deps: update github-actions (major) (#5757) by @renovate[bot]
- deps: update crate-ci/typos action to v1.35.4 (#5714) by
@renovate[bot]
- prepare-release: regenerate `binding.js` after version bump (#5704) by
@shulaoda
- deps: update dependency tsdown to v0.14.1 (#5705) by @renovate[bot]
- rollup-tests: skip occasionally failing test case (#5703) by @shulaoda
- update binding.js (#5702) by @shulaoda

Co-authored-by: sapphi-red <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants