Skip to content

Comments

fix: ensure lazy module eval order when import variable from other chunk#5727

Merged
IWANABETHATGUY merged 1 commit intomainfrom
08-14-fix_ensure_lazy_module_eval_order_when_import_variable_from_other_chunk
Aug 14, 2025
Merged

fix: ensure lazy module eval order when import variable from other chunk#5727
IWANABETHATGUY merged 1 commit intomainfrom
08-14-fix_ensure_lazy_module_eval_order_when_import_variable_from_other_chunk

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

Copy link
Member Author

IWANABETHATGUY commented Aug 14, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2025

Benchmarks Rust

  • target: main(88e2fcb)
  • pr: 08-14-fix_ensure_lazy_module_eval_order_when_import_variable_from_other_chunk(e2ee3e2)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     79.4±2.33ms        ? ?/sec    1.00     78.0±1.74ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     88.5±1.97ms        ? ?/sec    1.00     88.4±2.08ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    118.0±3.70ms        ? ?/sec    1.00    117.5±1.30ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    139.0±1.81ms        ? ?/sec    1.00    139.0±1.55ms        ? ?/sec
bundle/bundle@threejs                                        1.01     44.5±2.97ms        ? ?/sec    1.00     43.9±2.43ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     53.3±1.47ms        ? ?/sec    1.00     53.0±0.75ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    462.1±5.85ms        ? ?/sec    1.00    459.2±5.23ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    544.7±3.47ms        ? ?/sec    1.00    539.7±7.60ms        ? ?/sec
scan/scan@rome_ts                                            1.02     94.6±1.34ms        ? ?/sec    1.00     92.7±1.95ms        ? ?/sec
scan/scan@threejs                                            1.02     34.0±2.04ms        ? ?/sec    1.00     33.4±2.05ms        ? ?/sec
scan/scan@threejs10x                                         1.01    349.2±3.34ms        ? ?/sec    1.00    346.3±4.58ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review August 14, 2025 14:04
@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 August 14, 2025 14:04
Base automatically changed from 08-11-feat_concatenatewrappedmodule to main August 14, 2025 14:11
@IWANABETHATGUY IWANABETHATGUY force-pushed the 08-14-fix_ensure_lazy_module_eval_order_when_import_variable_from_other_chunk branch from 1c78077 to e2ee3e2 Compare August 14, 2025 14:12
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 14, 2025

Merge activity

  • Aug 14, 2:13 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@netlify
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit e2ee3e2
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/689deed681030d0008c3480f

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Aug 14, 2025
Merged via the queue into main with commit 00938fb Aug 14, 2025
22 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 08-14-fix_ensure_lazy_module_eval_order_when_import_variable_from_other_chunk branch August 14, 2025 16:13
This was referenced Aug 18, 2025
hyf0 pushed a commit that referenced this pull request Aug 18, 2025
## [1.0.0-beta.33] - 2025-08-18

### 💥 BREAKING CHANGES

- only call `closeBundle` hook when bundling actually happens (#5715) by
@shulaoda

### 🚀 Features

- rolldown_plugin_vite_css_post: align transform logic except minify
(#5768) by @shulaoda
- rolldown_plugin_vite_css_post: align html inline css logic (#5767) by
@shulaoda
- support merge cjs ns in module group level (#5760) by @IWANABETHATGUY
- rolldown_plugin_vite_css_post: filter transform id (#5766) by
@shulaoda
- rolldown: oxc v0.82.2 (#5754) by @Boshen
- rollup-test: log error when `pringStatus` (#5744) by @situ2001
- rolldown_plugin_vite_css_post: initialize (#5743) by @shulaoda
- rolldown_plugin_vite_css: align `transform` hook logic (#5736) by
@shulaoda
- rolldown_plugin_vite_css: align partial transform hook logic (#5733)
by @shulaoda
- add original wrap_kind (#5729) by @IWANABETHATGUY
- concatenateWrappedModule (#5724) by @IWANABETHATGUY
- rolldown: oxc v0.82.1 (#5717) by @Boshen
- improve error message for `unresolved_import` when platform is
`neutral` (#5700) by @IWANABETHATGUY

### 🐛 Bug Fixes

- rolldown_plugin_transform: merge tsconfig jsx options even when
`oxc.jsx.runtime` is set (#5771) by @hi-ogawa
- jsx preserve break component which is default export (#5764) by
@shulaoda
- rolldown_plugin_asset: should directly stringify raw content (#5749)
by @situ2001
- resolve symbol deconfliction order for cross-chunk imports by
@IWANABETHATGUY
- rolldown_error: improve resolve diagnostic message (#5740) by
@shulaoda
- vitest ci failed (#5741) by @IWANABETHATGUY
- rolldown: options `context` should be available in renderStart (#5672)
by @situ2001
- ensure lazy module eval order when import variable from other chunk
(#5727) by @IWANABETHATGUY
- wasm build panic on stackblitz (#5723) by @shulaoda
- plugin/vite-resolve: try non-prefixed id before prefixed id (#5711) by
@sapphi-red
- devtool: shouldn't filter out spans for devtool use case (#5713) by
@hyf0
- plugin/vite-resolve: fallback on more resolution errors that happened
when trying with prefix (#5710) by @sapphi-red
- plugin/vite-resolve: don't consider ids with `npm:` prefix as a
built-in module (#5709) by @sapphi-red

### 🚜 Refactor

- rolldown_plugin_json: use common plugin utils (#5769) by @shulaoda
- hmr: remove unnecessary code of handling runtime module (#5752) by
@hyf0
- hmr: enhance HMR update logic and improve clarity (#5748) by @hyf0
- improve `ScopeHoistingFinalizerContext` (#5739) by @shulaoda
- move `finalize_normal_module` into `ScopeHoistingFinalizerContext`
(#5738) by @shulaoda
- private fields `wrap_kind` and `original_wrap_kind` and keep them sync
(#5730) by @IWANABETHATGUY

### 📚 Documentation

- rolldown_plugin_data_uri: update README (#5746) by @situ2001
- install guide for minor platforms (#5716) by @sapphi-red
- update description for platform `neutral` (#5701) by @IWANABETHATGUY

### ⚡ Performance

- hmr: only refetch changed modules (#5753) by @hyf0
- rolldown_plugin_reporter: gzip size computation (#5734) by
@IWANABETHATGUY
- hmr: reuse previous ast for non-changed modules (#5725) by @hyf0
- rolldown_ecmascript: do not run semantic twice for `dce-only` (#5707)
by @Boshen

### 🧪 Testing

- rolldown: should await for `toMatchFileSnapshot` (#5759) by @situ2001
- hmr: improve test of `import.meta.hot.invalidate` (#5747) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance (#5765) by @renovate[bot]
- deps: lock file maintenance rust crates (#5763) by @renovate[bot]
- deps: lock file maintenance npm packages (#5762) by @renovate[bot]
- deps: update github-actions (#5755) by @renovate[bot]
- deps: update dependency tinybench to v5 (#5756) by @renovate[bot]
- deps: update github-actions (major) (#5757) by @renovate[bot]
- deps: update crate-ci/typos action to v1.35.4 (#5714) by
@renovate[bot]
- prepare-release: regenerate `binding.js` after version bump (#5704) by
@shulaoda
- deps: update dependency tsdown to v0.14.1 (#5705) by @renovate[bot]
- rollup-tests: skip occasionally failing test case (#5703) by @shulaoda
- update binding.js (#5702) by @shulaoda

Co-authored-by: sapphi-red <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants