Skip to content

Comments

feat: concatenateWrappedModule#5724

Merged
IWANABETHATGUY merged 1 commit intomainfrom
08-11-feat_concatenatewrappedmodule
Aug 14, 2025
Merged

feat: concatenateWrappedModule#5724
IWANABETHATGUY merged 1 commit intomainfrom
08-11-feat_concatenatewrappedmodule

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Aug 14, 2025

The basic idea is try to find those single-entry isolated subgraphs that wrapKind is esm .
The definition of an ESM single-entry isolated subgraph:
All inner module of the moduleGroup can only be reachable in the graph from the root of the module group.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review August 14, 2025 08:58
Copy link
Member Author

IWANABETHATGUY commented Aug 14, 2025

@netlify
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 78047c4
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/689db263c3adbb0008dfbc58

@IWANABETHATGUY IWANABETHATGUY force-pushed the 08-11-feat_concatenatewrappedmodule branch from 2936222 to aa6c63e Compare August 14, 2025 08:59
@IWANABETHATGUY IWANABETHATGUY force-pushed the 08-11-feat_concatenatewrappedmodule branch 4 times, most recently from 80d6c11 to 55fb00d Compare August 14, 2025 09:49
@IWANABETHATGUY IWANABETHATGUY force-pushed the 08-11-feat_concatenatewrappedmodule branch from 55fb00d to 78047c4 Compare August 14, 2025 09:54
@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 August 14, 2025 10:06
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(087f638)
  • pr: 08-11-feat_concatenatewrappedmodule(78047c4)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     83.6±2.69ms        ? ?/sec    1.04     86.7±2.93ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     94.9±2.96ms        ? ?/sec    1.03     97.3±2.01ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    122.9±4.25ms        ? ?/sec    1.02    125.1±2.16ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    143.5±2.02ms        ? ?/sec    1.03    147.4±2.40ms        ? ?/sec
bundle/bundle@threejs                                        1.00     46.0±1.94ms        ? ?/sec    1.03     47.3±2.81ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     56.0±1.45ms        ? ?/sec    1.00     56.2±0.81ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    476.3±5.50ms        ? ?/sec    1.02    485.4±7.88ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    571.5±9.92ms        ? ?/sec    1.00    569.7±8.10ms        ? ?/sec
scan/scan@rome_ts                                            1.01     99.4±2.52ms        ? ?/sec    1.00     98.6±1.81ms        ? ?/sec
scan/scan@threejs                                            1.00     35.1±0.55ms        ? ?/sec    1.01     35.5±2.06ms        ? ?/sec
scan/scan@threejs10x                                         1.00    359.5±3.24ms        ? ?/sec    1.01    363.8±4.62ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Aug 14, 2025
Merged via the queue into main with commit 88e2fcb Aug 14, 2025
24 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 08-11-feat_concatenatewrappedmodule branch August 14, 2025 14:12
This was referenced Aug 18, 2025
hyf0 pushed a commit that referenced this pull request Aug 18, 2025
## [1.0.0-beta.33] - 2025-08-18

### 💥 BREAKING CHANGES

- only call `closeBundle` hook when bundling actually happens (#5715) by
@shulaoda

### 🚀 Features

- rolldown_plugin_vite_css_post: align transform logic except minify
(#5768) by @shulaoda
- rolldown_plugin_vite_css_post: align html inline css logic (#5767) by
@shulaoda
- support merge cjs ns in module group level (#5760) by @IWANABETHATGUY
- rolldown_plugin_vite_css_post: filter transform id (#5766) by
@shulaoda
- rolldown: oxc v0.82.2 (#5754) by @Boshen
- rollup-test: log error when `pringStatus` (#5744) by @situ2001
- rolldown_plugin_vite_css_post: initialize (#5743) by @shulaoda
- rolldown_plugin_vite_css: align `transform` hook logic (#5736) by
@shulaoda
- rolldown_plugin_vite_css: align partial transform hook logic (#5733)
by @shulaoda
- add original wrap_kind (#5729) by @IWANABETHATGUY
- concatenateWrappedModule (#5724) by @IWANABETHATGUY
- rolldown: oxc v0.82.1 (#5717) by @Boshen
- improve error message for `unresolved_import` when platform is
`neutral` (#5700) by @IWANABETHATGUY

### 🐛 Bug Fixes

- rolldown_plugin_transform: merge tsconfig jsx options even when
`oxc.jsx.runtime` is set (#5771) by @hi-ogawa
- jsx preserve break component which is default export (#5764) by
@shulaoda
- rolldown_plugin_asset: should directly stringify raw content (#5749)
by @situ2001
- resolve symbol deconfliction order for cross-chunk imports by
@IWANABETHATGUY
- rolldown_error: improve resolve diagnostic message (#5740) by
@shulaoda
- vitest ci failed (#5741) by @IWANABETHATGUY
- rolldown: options `context` should be available in renderStart (#5672)
by @situ2001
- ensure lazy module eval order when import variable from other chunk
(#5727) by @IWANABETHATGUY
- wasm build panic on stackblitz (#5723) by @shulaoda
- plugin/vite-resolve: try non-prefixed id before prefixed id (#5711) by
@sapphi-red
- devtool: shouldn't filter out spans for devtool use case (#5713) by
@hyf0
- plugin/vite-resolve: fallback on more resolution errors that happened
when trying with prefix (#5710) by @sapphi-red
- plugin/vite-resolve: don't consider ids with `npm:` prefix as a
built-in module (#5709) by @sapphi-red

### 🚜 Refactor

- rolldown_plugin_json: use common plugin utils (#5769) by @shulaoda
- hmr: remove unnecessary code of handling runtime module (#5752) by
@hyf0
- hmr: enhance HMR update logic and improve clarity (#5748) by @hyf0
- improve `ScopeHoistingFinalizerContext` (#5739) by @shulaoda
- move `finalize_normal_module` into `ScopeHoistingFinalizerContext`
(#5738) by @shulaoda
- private fields `wrap_kind` and `original_wrap_kind` and keep them sync
(#5730) by @IWANABETHATGUY

### 📚 Documentation

- rolldown_plugin_data_uri: update README (#5746) by @situ2001
- install guide for minor platforms (#5716) by @sapphi-red
- update description for platform `neutral` (#5701) by @IWANABETHATGUY

### ⚡ Performance

- hmr: only refetch changed modules (#5753) by @hyf0
- rolldown_plugin_reporter: gzip size computation (#5734) by
@IWANABETHATGUY
- hmr: reuse previous ast for non-changed modules (#5725) by @hyf0
- rolldown_ecmascript: do not run semantic twice for `dce-only` (#5707)
by @Boshen

### 🧪 Testing

- rolldown: should await for `toMatchFileSnapshot` (#5759) by @situ2001
- hmr: improve test of `import.meta.hot.invalidate` (#5747) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance (#5765) by @renovate[bot]
- deps: lock file maintenance rust crates (#5763) by @renovate[bot]
- deps: lock file maintenance npm packages (#5762) by @renovate[bot]
- deps: update github-actions (#5755) by @renovate[bot]
- deps: update dependency tinybench to v5 (#5756) by @renovate[bot]
- deps: update github-actions (major) (#5757) by @renovate[bot]
- deps: update crate-ci/typos action to v1.35.4 (#5714) by
@renovate[bot]
- prepare-release: regenerate `binding.js` after version bump (#5704) by
@shulaoda
- deps: update dependency tsdown to v0.14.1 (#5705) by @renovate[bot]
- rollup-tests: skip occasionally failing test case (#5703) by @shulaoda
- update binding.js (#5702) by @shulaoda

Co-authored-by: sapphi-red <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants