Skip to content

Comments

fix: wasm build panic on stackblitz#5720

Merged
Brooooooklyn merged 1 commit into08-13-refactor_improve_bundler_close_logicfrom
08-14-fix_wasm_build_panic_on_stackblitz
Aug 14, 2025
Merged

fix: wasm build panic on stackblitz#5720
Brooooooklyn merged 1 commit into08-13-refactor_improve_bundler_close_logicfrom
08-14-fix_wasm_build_panic_on_stackblitz

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Aug 13, 2025

@shulaoda shulaoda marked this pull request as draft August 13, 2025 17:20
shulaoda
shulaoda commented Aug 13, 2025
View reviewed changes
@netlify
Copy link

netlify bot commented Aug 13, 2025

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 84bdd81
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/689cc95b9b775a0008560966
😎 Deploy Preview https://deploy-preview-5720--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 13, 2025

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@5720

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@5720

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@5720

rolldown

npm i https://pkg.pr.new/rolldown@5720

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@5720

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@5720

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@5720

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@5720

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@5720

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@5720

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@5720

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@5720

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@5720

@rolldown/binding-openharmony-arm64

npm i https://pkg.pr.new/@rolldown/binding-openharmony-arm64@5720

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@5720

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@5720

@rolldown/binding-win32-ia32-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-ia32-msvc@5720

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@5720

commit: 84bdd81

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

Benchmarks Rust

  • target: main(c295619)
  • pr: 08-14-fix_wasm_build_panic_on_stackblitz(84bdd81)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     77.8±1.55ms        ? ?/sec    1.00     77.4±1.49ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     87.0±1.45ms        ? ?/sec    1.00     86.9±1.82ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    120.6±2.07ms        ? ?/sec    1.00    118.4±1.53ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    139.8±2.10ms        ? ?/sec    1.00    139.6±1.83ms        ? ?/sec
bundle/bundle@threejs                                        1.04     45.2±1.20ms        ? ?/sec    1.00     43.6±0.99ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     54.4±2.45ms        ? ?/sec    1.00     53.9±1.44ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    461.0±4.04ms        ? ?/sec    1.00    461.5±3.96ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    543.4±3.77ms        ? ?/sec    1.00    543.0±3.30ms        ? ?/sec
scan/scan@rome_ts                                            1.01     94.6±1.19ms        ? ?/sec    1.00     94.0±1.18ms        ? ?/sec
scan/scan@threejs                                            1.02     33.1±2.05ms        ? ?/sec    1.00     32.5±0.86ms        ? ?/sec
scan/scan@threejs10x                                         1.00    346.5±3.11ms        ? ?/sec    1.01   349.2±14.95ms        ? ?/sec

@shulaoda shulaoda changed the base branch from main to 08-13-refactor_improve_bundler_close_logic August 13, 2025 17:43
@shulaoda shulaoda marked this pull request as ready for review August 13, 2025 18:08
@shulaoda shulaoda requested a review from Brooooooklyn August 14, 2025 02:11
@Brooooooklyn Brooooooklyn merged commit 197bb0f into 08-13-refactor_improve_bundler_close_logic Aug 14, 2025
49 checks passed
@Brooooooklyn Brooooooklyn deleted the 08-14-fix_wasm_build_panic_on_stackblitz branch August 14, 2025 06:37
@shulaoda shulaoda restored the 08-14-fix_wasm_build_panic_on_stackblitz branch August 14, 2025 08:52
@shulaoda shulaoda mentioned this pull request Aug 14, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 14, 2025
@shulaoda
fix: wasm build panic on stackblitz (#5723)
d88c249 
Related to #5720

Since #5715 is still pending review, we will merge it separately for
now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

trigger: preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WASM build panic on stackblitz

3 participants

@shulaoda @Brooooooklyn @IWANABETHATGUY