Skip to content

Comments

feat: generate sourcemap#572

Closed
underfin wants to merge 13 commits intobump-oxcfrom
final-sourcemap
Closed

feat: generate sourcemap#572
underfin wants to merge 13 commits intobump-oxcfrom
final-sourcemap

Conversation

@underfin
Copy link
Contributor

@underfin underfin commented Mar 13, 2024

Description

Test Plan

@underfin
Copy link
Contributor Author

underfin commented Mar 13, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @underfin and the rest of your teammates on Graphite Graphite

@underfin underfin mentioned this pull request Mar 13, 2024
Closed
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #572 will not alter performance

⚠️ No base runs were found

Falling back to comparing final-sourcemap (4919d18) with main (8b0a28a)

Summary

✅ 4 untouched benchmarks

🆕 2 new benchmarks

Benchmarks breakdown

Benchmark main final-sourcemap Change
🆕 threejs-sourcemap N/A 1.8 s N/A
🆕 threejs10x-sourcemap N/A 18.5 s N/A

@underfin underfin marked this pull request as draft March 13, 2024 09:20
hyf0
hyf0 reviewed Mar 13, 2024
View reviewed changes
crates/rolldown/Cargo.toml
serde = { workspace = true }
serde_json = { workspace = true }
smallvec = { workspace = true }
string_wizard = { workspace = true }
Copy link
Member

@hyf0 hyf0 Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just sent the inventation of string_wizard to you on crate.io. You should have the publish permission now.

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2024

⚠️ No Changeset found

Latest commit: 4919d18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@underfin underfin closed this Mar 18, 2024
@Brooooooklyn Brooooooklyn deleted the final-sourcemap branch January 17, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@underfin @hyf0